Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d7gVB-00032M-U4 for pgadmin-hackers@arkaria.postgresql.org; Mon, 08 May 2017 11:06:54 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1d7gVB-0005e3-Bo for pgadmin-hackers@arkaria.postgresql.org; Mon, 08 May 2017 11:06:53 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1d7gUw-0005FO-V1 for pgadmin-hackers@postgresql.org; Mon, 08 May 2017 11:06:39 +0000 Received: from mail-it0-x22d.google.com ([2607:f8b0:4001:c0b::22d]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1d7gUt-0000x7-Qb for pgadmin-hackers@postgresql.org; Mon, 08 May 2017 11:06:37 +0000 Received: by mail-it0-x22d.google.com with SMTP id x188so35878526itb.0 for ; Mon, 08 May 2017 04:06:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=aFel4gfnz70HwfjYr10qQjGHpWYiLO+sAnL5mnCeJqk=; b=nl5rqzJ0XvLn6Ohy4KBhGHCJA9nLJ9qAD8mAvkozNzhZ2GaXae5jULSxSVoA1u/PvG EeFf+9M27BzkrfcZBFDTnfmIhVLjjHuTppfxJNH50lyIrigWMpTQB21y3ODQjr1aZa1P zGKitMWiJvJPr3fueuyLt2wyjDBIt6yDYMLpZxVtbgKO79LnXUXSW0CnfkRDvR1BG273 MtQFOqLB/MMNlCAyA4GTjhSi0BiMLGG8evMyh/flycD7/ip4hjT5+BUadMpQ28R3z0sS aIfGi1SpzrEqVzD8c4RWdnzjxgdWEuQKAPZxKlKa+vTSoh5eNN2P4qAFoWDaVmdLSnWs /IhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=aFel4gfnz70HwfjYr10qQjGHpWYiLO+sAnL5mnCeJqk=; b=gYKEpLiKnAGS+V94sBSKHILBEQyna2iEPvouuKmdKHTCutz7b3Kdky5lmsnR/M8aU6 22IQj1mns/WT7aXwKB7Ths6FoCuB4gkdj2/PqOiQLpfZkE9OhZ2818g1Gs29Ivl/65GS kZ9WawcTUuu7VvgFUwiN9hKHsMbfKka1e5JB/YVJphH9P4bg4XS+Dgn68ioBeO9jVsIn Pnfk0Czxo0RR+DcuKW34jUjggdhk/C01AetpOYsOw8A5t0FugjoZivbG5/jbCNzNqtNU BrRZGOMB30ZSCbGEbjOObb0H3SzItY5RHz0uxEn1x/caomTO7WZDfTf/KYp9vJzeHO/T F3Ow== X-Gm-Message-State: AN3rC/4k+aVZC/m2WQcKS96JhwSfA0nDlDyugJyMQm7GGi1X9uGZuNrI K4qA62BrqiTmXH+PxNkL9Pmy48qoig== X-Received: by 10.36.17.197 with SMTP id 188mr20688562itf.28.1494241594977; Mon, 08 May 2017 04:06:34 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.174.167 with HTTP; Mon, 8 May 2017 04:06:34 -0700 (PDT) In-Reply-To: <1494241045.2858.27.camel@gunduz.org> References: <8ca2ba41-b46f-a89e-6b1b-4b7277348685@berkus.org> <1492765022.3215.2.camel@gunduz.org> <9d48ca84-daaa-dca4-b6c4-ab7e99e9b74a@berkus.org> <31f14480-46d0-03d8-8f13-b1ff6294f326@berkus.org> <5c1f671e-ef59-ff82-5bd1-d6f9cf22abfd@berkus.org> <1494241045.2858.27.camel@gunduz.org> From: Dave Page Date: Mon, 8 May 2017 12:06:34 +0100 Message-ID: Subject: Re: Install of pgadmin4 from package fails ... To: =?UTF-8?B?RGV2cmltIEfDvG5kw7x6?= Cc: Josh Berkus , pgadmin-hackers Content-Type: multipart/alternative; boundary=001a11437efe7a5f15054f013bb2 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a11437efe7a5f15054f013bb2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Mon, May 8, 2017 at 11:57 AM, Devrim G=C3=BCnd=C3=BCz wrote: > > Hi Josh, > > Sorry for the late response, I have 10K unread emails as of now: > > On Tue, 2017-04-25 at 08:24 -0700, Josh Berkus wrote: > > > I know how to fix my personal install (and container image). But I wan= t > > to fix the RPM package so that it's fixed for most users. Right now, > > install from RPM is kind of broken. > > > > Here's the changes that need to happen on the RPM: > > > > 1. Remove the QT dependencies for pgadmin4-v1-web > > Why? I thought we need them to run pgadmin4? > Only in desktop mode. For web-only use, no Qt should be needed. > > > 2. Have the RPM create /usr/share/httpd/.pgadmin, owned by apache user. > > (is this the best location? If not, what is?) > > Good question. I think that location is good. > > > > 3. Fix the systemd unit file so that the pgadmin4 unit is owned by > apache. > > Why? I did not read all the emails in this thread (yet), but all of the > unit > files are owned by root, and I see no exception on my system. > > > 4. (optional) set up files according to FDL standards, putting configs > > for pgadmin4 in /etc/pgadmin and the db in /var/run/pgadmin (or similar= ). > > Red Hat does not care about that that much, does it? Especially for /etc > part. > Debian does though. That's been on my TODO list for a while. It's pretty easy to do though - we can have a config option in config.py to specify the location of config_local.py, defaulting to the current location. Packagers could then override that in config_distro.py. > > > Devrim, where is the source for this rpm build? > > https://yum.postgresql.org/srpms/testing/10/redhat/rhel- > 7-x86_64/repoview/pgadmin4-v1.html > > Regards, > -- > Devrim G=C3=BCnd=C3=BCz > EnterpriseDB: http://www.enterprisedb.com > PostgreSQL Dan=C4=B1=C5=9Fman=C4=B1/Consultant, Red Hat Certified Enginee= r > Twitter: @DevrimGunduz , @DevrimGunduzTR > --=20 Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a11437efe7a5f15054f013bb2 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On Mon, May 8, 2017 at 11:57 AM, Devrim G=C3=BCnd=C3=BCz <devrim@gundu= z.org> wrote:

Hi Josh,

Sorry for the late response, I have 10K unread emails as of now:

On Tue, 2017-04-25 at 08:24 -0700, Josh Berkus wrote:

> I know how to fix my personal install (and container image).=C2=A0 But= I want
> to fix the RPM package so that it's fixed for most users.=C2=A0 Ri= ght now,
> install from RPM is kind of broken.
>
> Here's the changes that need to happen on the RPM:
>
> 1. Remove the QT dependencies for pgadmin4-v1-web

Why? I thought we need them to run pgadmin4?
Only in desktop mode. For web-only use, no Qt should be needed= .
=C2=A0

> 2. Have the RPM create /usr/share/httpd/.pgadmin, owned by apache user= .
> =C2=A0=C2=A0 (is this the best location?=C2=A0 If not, what is?)

Good question. I think that location is good.


> 3. Fix the systemd unit file so that the pgadmin4 unit is owned by apa= che.

Why? I did not read all the emails in this thread (yet), but all of = the unit
files are owned by root, and I see no exception on my system.

> 4. (optional) set up files according to FDL standards, putting configs=
> for pgadmin4 in /etc/pgadmin and the db in /var/run/pgadmin (or simila= r).

Red Hat does not care about that that much, does it? Especially for = /etc part.

Debian does though. That'= ;s been on my TODO list for a while. It's pretty easy to do though - we= can have a config option in config.py to specify the location of config_lo= cal.py, defaulting to the current location. Packagers could then override t= hat in config_distro.py.
=C2=A0

> Devrim, where is the source for this rpm build?

htt= ps://yum.postgresql.org/srpms/testing/10/redhat/rhel-7-x86_64/rep= oview/pgadmin4-v1.html

Regards,
--
Devrim G=C3=BCnd=C3=BCz
EnterpriseDB: http://www.enterprisedb.com
PostgreSQL Dan=C4=B1=C5=9Fman=C4=B1/Consultant, Red Hat Certified Engineer<= br> Twitter: @DevrimGunduz , @DevrimGunduzTR



--
Dave Pa= ge
Blog: http:= //pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterpris= edb.com
The Enterprise PostgreSQL Company
--001a11437efe7a5f15054f013bb2--