Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1biMDW-0005LR-T8 for pgadmin-hackers@arkaria.postgresql.org; Fri, 09 Sep 2016 13:51:43 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1biMDW-0005r4-Fj for pgadmin-hackers@arkaria.postgresql.org; Fri, 09 Sep 2016 13:51:42 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1biMDV-0005oE-OG for pgadmin-hackers@postgresql.org; Fri, 09 Sep 2016 13:51:41 +0000 Received: from mail-oi0-x22d.google.com ([2607:f8b0:4003:c06::22d]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1biMDS-0004Us-Cf for pgadmin-hackers@postgresql.org; Fri, 09 Sep 2016 13:51:41 +0000 Received: by mail-oi0-x22d.google.com with SMTP id y2so142640979oie.0 for ; Fri, 09 Sep 2016 06:51:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=sxf59IWzTJmQ2BEkUHesO7hyEKNOgmzO/K+u0OP0iXA=; b=AKPhCuwjqJqWkkf4NsivfOh6xeahPiI6i3FJKQl3rAqNGzFFVQhpR7SE5jK3LW6JnT fOyiLdA90D1we/ERz1OnLh/O6L68EnYfEpL68y9STBXCxxDFmEzG5PgFrROsUhxalryj VyMLfCyPfscQ3wvSSVlaxLqUuo0Zuu8NifSdunYzBfRMKkh9Fk6VU3kz/kS5tY206+Sa My3BYCFMCSNHJYaMoJHOD0hoP0aRH/znxjSMt+8wNSW7m/uZMlaFAK3EMBpOycK2qHsX U11ABScBS6Nq8KGRhuK//vQQ2mbzHgVpyE7v4Jr8FIPDcF1rofjp0ifGOpPw0ZecpB3P K0Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=sxf59IWzTJmQ2BEkUHesO7hyEKNOgmzO/K+u0OP0iXA=; b=LnrpdrUYlECqM/i7hfYDEFLZOpkvr1U/a/WVooCwOeYAQgSyc9wZlQ0X/LK0PIvnK8 vnW905breF0eWZ7g4msrO0eOQCrHARevSHg95TlZRL4AHv6b7tcXI1GfB72TklEBMMqd OsBeRl1Zvj/JA11KcGX3jMjNjC3OKDuJISIbX0l+A/lOo1A3TS0+ZJcChkn89ePkeLII t8yZrTLcubNwj9Bn9K+KP6L/LSLs4sG1fCJA91k/2OCtR5s5WDXiVhe01ME4cOltZp8/ 886bZCzON4HzcEb5qv7w7igVMpWZcsZO5hvenF6aSO/zWLx5VHQT1xK6qyuhIAzmM/lY 38hg== X-Gm-Message-State: AE9vXwOOhLMbTFhy+G9oel/vyfRVocElE/WvBWdvOGM1vfu+O9uRB00khi2zaPEKyZC4lKcbsfZkTyGFyzRvUw== X-Received: by 10.202.216.8 with SMTP id p8mr5946360oig.140.1473429096779; Fri, 09 Sep 2016 06:51:36 -0700 (PDT) MIME-Version: 1.0 Received: by 10.64.1.203 with HTTP; Fri, 9 Sep 2016 06:51:36 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Fri, 9 Sep 2016 14:51:36 +0100 Message-ID: Subject: Re: PATCH: Python2.6 compatibility fixes (pgAdmin4) To: Surinder Kumar Cc: Murtuza Zabuawala , pgadmin-hackers Content-Type: text/plain; charset=UTF-8 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org Thanks, applied. On Fri, Sep 9, 2016 at 1:53 PM, Surinder Kumar wrote: > Please find attached patch with following fix: > > 1) While running pgAdmin4 with latest git pull on Windows x64 environment, I > got an exception on terminal console, >> >> NameError >> NameError: global name 'arch_keys' is not defined > > > Issue: arch_keys was defined inside the method add_server, but used outside > the method. > > I have handled this issue in attached patch. > > On Tue, Sep 6, 2016 at 6:52 PM, Dave Page wrote: >> >> Thanks, patch applied. >> >> On Tue, Sep 6, 2016 at 12:08 PM, Murtuza Zabuawala >> wrote: >> > +++ Adding related RM. >> > >> > RM#1636 & RM#1659 >> > >> > -- >> > Regards, >> > Murtuza Zabuawala >> > EnterpriseDB: http://www.enterprisedb.com >> > The Enterprise PostgreSQL Company >> > >> > On Tue, Sep 6, 2016 at 4:36 PM, Murtuza Zabuawala >> > wrote: >> >> >> >> Hi, >> >> >> >> PFA minor patch for Python2.6 compatibility with pgAdmin4. >> >> Please review. >> >> >> >> >> >> Regards, >> >> Murtuza Zabuawala >> >> EnterpriseDB: http://www.enterprisedb.com >> >> The Enterprise PostgreSQL Company >> > >> > >> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> >> -- >> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >> To make changes to your subscription: >> http://www.postgresql.org/mailpref/pgadmin-hackers > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers