Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ar3OU-0006EG-Mx for pgadmin-hackers@arkaria.postgresql.org; Fri, 15 Apr 2016 13:02:42 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1ar3OU-0001aw-2N for pgadmin-hackers@arkaria.postgresql.org; Fri, 15 Apr 2016 13:02:42 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ar3OT-0001ZV-5C for pgadmin-hackers@postgresql.org; Fri, 15 Apr 2016 13:02:41 +0000 Received: from mail-io0-x235.google.com ([2607:f8b0:4001:c06::235]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1ar3OP-0007fy-AK for pgadmin-hackers@postgresql.org; Fri, 15 Apr 2016 13:02:40 +0000 Received: by mail-io0-x235.google.com with SMTP id u185so133678552iod.3 for ; Fri, 15 Apr 2016 06:02:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=Vj+LRx1TtVfxwG5Rry10uneCGjBUeM4fKABrm+uVzwY=; b=d7f9QISbsX0BwhnFR9+kNaR//IjtCfYb7ZLsIktaoLnfRUcGbV5Bb/acDbz+UXddJY ABBvcml8RcRKtZT43hLJVIro60E5xF5u64H+ZrApiJ2W4cYLvgiVVUDO33b3NBHjjH8i 4g1nIaey0EB752ddimHXUHgBwXA8PUCbhu5cOJ0QjGdrpULjZee3iEOM3pJjfVLmMRps s9pN3BjV/Vb5Qf06RPixHsGplxV1BKYbS3ZkqHn4NzTQDc8obiqmKLJEsacTg86v/Z+A doC31d4PmZoMo8MP1Qx/Gq2DHXSInNIIfKGiIm455893ba/mmiVBlRID76gQmzBTt2bl uguA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=Vj+LRx1TtVfxwG5Rry10uneCGjBUeM4fKABrm+uVzwY=; b=ZanO5mbBxMtlGGMUVRtVR0VCxaiwDi25H1CcH3C279tamRiLGEPM6msJDH82G4HUJ5 zyrDLuKIiEG4jqSpXAzozqSjNxvvY+4iDn6nKymeoJUhbIpLnD8G/rIkjAFJc65CwHuh R2FTi8Hx+Jst6vbwsjNToZl//XnghqJyj2dElEkQwKKZCB3wwOEBJpg4h6Qx9CK+9QqC mxQuyF3vJhyFToGtIHM9TsJwn6jyB6nZA1pS7fjsQkDBR8kqKSnjhTPrIilA/kshvQWH g3wxYBEb4pdUru+/2VZ8chMHy8xpg1DLMmD43DecdnN8niCrae6R2zab5MbGcfISbyw6 ON0w== X-Gm-Message-State: AOPr4FVRohoTe21g22EE1sCA+bFgrfHkp0Xp0SNEq3VU1ADLAqYt7krnmtxWov58yZ/+i414kU0J29/5rt+ubQ== MIME-Version: 1.0 X-Received: by 10.107.56.196 with SMTP id f187mr22845021ioa.156.1460725355570; Fri, 15 Apr 2016 06:02:35 -0700 (PDT) Received: by 10.64.105.131 with HTTP; Fri, 15 Apr 2016 06:02:34 -0700 (PDT) In-Reply-To: References: Date: Fri, 15 Apr 2016 14:02:34 +0100 Message-ID: Subject: Re: Dialogues not closing From: Dave Page To: Ashesh Vashi Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=001a114ab7b0ef05e80530859fed X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a114ab7b0ef05e80530859fed Content-Type: text/plain; charset=UTF-8 That seems to have got it - thanks! On Fri, Apr 15, 2016 at 11:48 AM, Ashesh Vashi < ashesh.vashi@enterprisedb.com> wrote: > Oops.. clicked before attaching... > > > -- > > Thanks & Regards, > > Ashesh Vashi > EnterpriseDB INDIA: Enterprise PostgreSQL Company > > > > *http://www.linkedin.com/in/asheshvashi* > > > On Fri, Apr 15, 2016 at 4:18 PM, Ashesh Vashi < > ashesh.vashi@enterprisedb.com> wrote: > >> Hi Dave, >> >> I was able to reproduce the issue with the help of Murtuza. >> I missed one corner case - it was not able to close the dialog, when the >> parent/collection has not yet been loaded. >> >> Please find the updated patch. >> This patch only includes the dialog issue. >> Please let me know - if you still see the issue. >> >> I've committed the patch about the objects (model/collection/views) >> release. >> >> >> -- >> >> Thanks & Regards, >> >> Ashesh Vashi >> EnterpriseDB INDIA: Enterprise PostgreSQL Company >> >> >> >> *http://www.linkedin.com/in/asheshvashi* >> >> >> On Fri, Apr 15, 2016 at 1:36 PM, Ashesh Vashi < >> ashesh.vashi@enterprisedb.com> wrote: >> >>> Hi Dave, >>> >>> >>> On Fri, Apr 15, 2016 at 1:20 PM, Dave Page wrote: >>> >>>> >>>> >>>> On Fri, Apr 15, 2016 at 6:32 AM, Ashesh Vashi < >>>> ashesh.vashi@enterprisedb.com> wrote: >>>> >>>>> On Fri, Apr 15, 2016 at 2:23 AM, Dave Page wrote: >>>>> >>>>>> Hey Ashesh, >>>>>> >>>>>> We have an issue with dialogues not closing on Save button presses. >>>>>> One of the team told me yesterday or the day before that it's a >>>>>> general issue, not one specific to the patch I was reviewing at the >>>>>> time, which I've been finding seems to be the case. >>>>>> >>>>>> Any idea what this issue is? >>>>>> >>>>> Sure - I will look into it. >>>>> >>>> >>>> Thanks - please make it a priority; I'm at PG Conf NYC next week and >>>> expect to be doing lots of demos. >>>> >>> Please find the patch for the same. >>> >>> This also includes some of the cleanup required to solve some of the >>> memory leak issues. >>> >>> I was not able to reproduce the issue at my end, but - I've idea of when >>> it could fail to close the panel, which I have resolved in this patch. >>> Can you please test it? >>> >>> -- >>> >>> Thanks & Regards, >>> >>> Ashesh Vashi >>> EnterpriseDB INDIA: Enterprise PostgreSQL Company >>> >>> >>> >>> *http://www.linkedin.com/in/asheshvashi* >>> >>> >>> >>>> >>>> -- >>>> Dave Page >>>> Blog: http://pgsnake.blogspot.com >>>> Twitter: @pgsnake >>>> >>>> EnterpriseDB UK: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>> >>> >> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a114ab7b0ef05e80530859fed Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
That seems to have got it - thanks!

On Fri, Apr 15, 2016 at 11:48 AM, = Ashesh Vashi <ashesh.vashi@enterprisedb.com> wro= te:
Oops.. clicked befor= e attaching...



On Fri, Apr 15= , 2016 at 4:18 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com= > wrote:
H= i Dave,

I was able to reproduce the issue with the help = of Murtuza.
I missed one corner case - it was not able to close t= he dialog, when the parent/collection has not yet been loaded.
Please find the updated patch.
This patch only inclu= des the dialog issue.
Please let me know - if you still see the i= ssue.

I've committed the patch about the objec= ts (model/collection/views) release.


--=

Thanks & Regar= ds,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise Post= greSQL Company

<= br>

<= a href=3D"http://www.linkedin.com/in/asheshvashi" target=3D"_blank">http= ://www.linkedin.com/in/asheshvashi


On Fri, Apr 15, 2016 at 1:3= 6 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
<= p style=3D"margin:0pt">Hi Dave,


On Fri, Apr 15, 2016 at 1:20 PM, Dave Page <dpage@p= gadmin.org> wrote:



On Fri, Apr 15, 201= 6 at 6:32 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com&= gt; wrote:
<= p style=3D"margin:0pt">On Fri, Apr 15, 2016 at 2:23 AM, Dave Page <dpage@p= gadmin.org> wrote:

Hey Ashesh,

We have an issue with dialogues not closing on Save button presses.
One of the team told me yesterday or the day before that it's a
general issue, not one specific to the patch I was reviewing at the
time, which I've been finding seems to be the case.

Any idea what this issue is?
Sure - I will look= into it.

Th= anks - please make it a priority; I'm at PG Conf NYC next week and expe= ct to be doing lots of demos.=C2=A0
Please find the patch for the same.

This = also includes some of the cleanup required to solve some of the memory leak= issues.

I was not able to reproduce the issue at = my end, but - I've idea of when it could fail to close the panel, which= I have resolved in this patch.
Can you please test it?

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA:=C2=A0Enterprise PostgreSQL Company<= /span>


http://www.linkedin.com/in/asheshva= shi



=

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitt= er: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise Postg= reSQL Company






--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake=

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Compan= y
--001a114ab7b0ef05e80530859fed--