Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1haKov-0005sh-E1 for pgadmin-hackers@arkaria.postgresql.org; Mon, 10 Jun 2019 13:58:46 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1haKou-00016t-8U for pgadmin-hackers@arkaria.postgresql.org; Mon, 10 Jun 2019 13:58:44 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1haKot-00016m-TC for pgadmin-hackers@lists.postgresql.org; Mon, 10 Jun 2019 13:58:44 +0000 Received: from mail-it1-x144.google.com ([2607:f8b0:4864:20::144]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1haKom-0000bb-AJ for pgadmin-hackers@postgresql.org; Mon, 10 Jun 2019 13:58:43 +0000 Received: by mail-it1-x144.google.com with SMTP id q14so12189921itc.5 for ; Mon, 10 Jun 2019 06:58:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8npFJn1X7MxOnjdZrw2aKhk4o19dPteZMoHIDdeIrCg=; b=G1krZ7EsSKpsKftTG2+mJnFa5tD2Qz4FpiKyNiedt8L7VhQ5ErsA3DKwRGJ0vdWDj6 gDCBqHLvK7zE56WJgZQjaVYgsFBOcl0tGoFJZUU8exGDaucg/HmxzQCr6N+1sADGDrvA 6Gf1qPEMgSQWViCMir1qrIf/kvlnLLGLqEem1IqClK+4ghlEKGTKNTBm7lKk2PF87242 I+ihIzIL8Yy4wO/6s1rd2pM9/Jk8iynUQ7yTyQiygEw2ysiyQkiBzqUc/lBJM1/afdSZ eZxdYv53k/Ro0A3rQ8Yiv5Aa++/qdkooLsJMk2YKcDV3Tj0mj5NB9D0kw2UaDY1c5NSM WNtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8npFJn1X7MxOnjdZrw2aKhk4o19dPteZMoHIDdeIrCg=; b=b29rtwOvlkJfXS0qVItipiirIduEJKTbaIQEnwCHHbXyBnZxYc/P71b9Nm3L2+Aoxr ItzvrQ8HTdeY93KsHPEH6L5bedZbZ4GYM9Ywt5PextRuwdq3lFlJ8bnTj08P36fgAek6 L3Gxi8fDtRv/KEppgPMldpoG3uo2VTx6wXmLjlw08G0qGQrcnVPExpC0wIgmByQLqsuq hU/Ew3iX2MYJqb5syOdW7iQ0A7B9VD5vDWypBc6JbpMsXCwg8/6R/h7R6+GZflq92Q3y SGlZhX8hGYVwENoEwF12GkgP9DfsBORE0Cv/QXHn0i5AS0qq5dLtnxmngcYguSXCGuOa NQeA== X-Gm-Message-State: APjAAAU2/EaKvwsHUKTIIuopwRdxVPK2ASSD99nbx6mGDQrRmTvwnE3n AQcYCTjFCTC+DF87o0sAC4FYzc1ClfaBbUzlWZzygQ== X-Google-Smtp-Source: APXvYqyx548tK7jRxI6PVL18qUc0KHK/C0cT6+13IBEck+cuRNKBZk9btIprpEBvZOVGORpS75chvNbPQGeVXE9mVms= X-Received: by 2002:a05:660c:c1:: with SMTP id q1mr13414577itk.103.1560175113729; Mon, 10 Jun 2019 06:58:33 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dave Page Date: Mon, 10 Jun 2019 14:58:20 +0100 Message-ID: Subject: Re: [pgAdmin][RM4329] Initialization error when parameterised functions debugged in parallel in two separate tabs To: Aditya Toshniwal Cc: Akshay Joshi , pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000710ff1058af89353" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000710ff1058af89353 Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. On Mon, Jun 10, 2019 at 1:58 PM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the updated patch with fixes. > > On Mon, Jun 10, 2019 at 12:58 PM Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Hi Aditya >> >> Following are the review comments: >> >> - "Set breakpoint" option not working, when click it throws an error. >> >> Fixed. > >> >> - Create an empty function and try to debug that. It should show >> proper error message. >> >> This seems to be a bug in the debugger itself. I'll raise a bug with > simulation steps if it is. But, not sure where to raise. > >> >> - Got the following backend error when closing the connection, please >> fix this: >> - File >> "E:\Projects\pgadmin4\web\pgadmin\tools\debugger\__init__.py", line 2053, >> in close_debugger_session >> conn_id=dbg_obj['exe_conn_id']) >> >> Fixed. > >> >> On Fri, Jun 7, 2019 at 12:21 PM Aditya Toshniwal < >> aditya.toshniwal@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached is the patch for debugger improvements. The changes include: >>> 1) Change the way debug info is stored in session. Removed redundant >>> session related code in debugger code. All the session related handling >>> done at one place. >>> 2) Fixed a bug where debugger was not opening for EPAS package function. >>> 3) If a package is defined without body and we try to debug a proc/func, >>> the debugger opened a blank window. Changes made so that it will throw >>> error as "XYZ is not defined in package body." >>> >>> -- >>> Thanks and Regards, >>> Aditya Toshniwal >>> Software Engineer | EnterpriseDB India | Pune >>> "Don't Complain about Heat, Plant a TREE" >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --000000000000710ff1058af89353 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.

On Mon, Jun 10, 2019 at 1:58 PM Adit= ya Toshniwal <adity= a.toshniwal@enterprisedb.com> wrote:
Hi Hackers,
<= div class=3D"gmail_default" style=3D"font-family:verdana,sans-serif">
A= ttached is the updated patch with fixes.

On Mon, Jun 10, 2019 at 12:58= PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi=C2=A0Aditya
Following are the review comments:
  • &quo= t;Set breakpoint" option not working, when click it throws an error.
Fixed.=C2=A0
  • Create an= empty function and try to debug that. It should show proper error message.=
This seems to be a bug in the debugger = itself. I'll raise a bug with simulation steps if it is. But, not sure = where to raise.
  • Got the following backend error when cl= osing the connection, please fix this:
    • =C2=A0 =C2=A0 File "= ;E:\Projects\pgadmin4\web\pgadmin\tools\debugger\__init__.py", line 20= 53, in close_debugger_session
      =C2=A0 =C2=A0 conn_id=3Ddbg_obj['exe_c= onn_id'])
Fixed.=C2=A0

On Fri, Jun 7, 2019 at 12:2= 1 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
<= /div>
Hi Hackers,

Attached is the patch for debugger improvements. The changes in= clude:
1) Change the way= debug info is stored in session. Removed redundant session related code in= debugger code. All the session related handling done at one place.
2) Fixed a bug where debugger w= as not opening for EPAS package function.
3) If a package is defined without body and we try to debug a p= roc/func, the debugger opened a blank window. Changes made so that it will = throw error as "XYZ is not defined in package body."
=

--
=
Thanks and Regards,
Aditya Toshniwal=
Software Engineer |= =C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Complain about Heat, Plant a TREE&quo= t;


--
Thanks & Regards
Akshay Joshi
<= div>Sr. Software Arch= itect
EnterpriseDB Soft= ware India Private Limited
Mobile: +91 976-788-8246


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer |=C2=A0EnterpriseDB I= ndia |=C2=A0Pune
"Don't Complain about Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @p= gsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL = Company
--000000000000710ff1058af89353--