Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d9724-0003FL-Kw for pgadmin-hackers@arkaria.postgresql.org; Fri, 12 May 2017 09:38:44 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1d9724-0000gV-7d for pgadmin-hackers@arkaria.postgresql.org; Fri, 12 May 2017 09:38:44 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1d9723-0000eL-E7 for pgadmin-hackers@postgresql.org; Fri, 12 May 2017 09:38:43 +0000 Received: from mail-io0-x232.google.com ([2607:f8b0:4001:c06::232]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1d971u-0003Uy-Oi for pgadmin-hackers@postgresql.org; Fri, 12 May 2017 09:38:42 +0000 Received: by mail-io0-x232.google.com with SMTP id k91so36874819ioi.1 for ; Fri, 12 May 2017 02:38:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=p1YlSYRsQ9UVFskbeboKg7OM1mMUzIeFuPlepfRb2ro=; b=A0vaSZqf8YefUhsZGorXMoWXthOG8esU7DtOLpQ9LTRhBRnb9s7DX7P7mOx9PtMatc 2v0DuZXlgtRTF2sWv2UD94W9Fph1hcPvuA9E0s/fJqqBZJimGloFpwxHttMPxA0yCGih oEI6//GD9GaKUoIAd7conqhONdIfaww4pR2sqsAxCjwAmGMovw5DXPmicRDFrFGYvvwm kvrV6XM7ZK6DTEMbxl28ktWCuM4dFK80991w9w5iNPCkMeSLwXaM9GqEn0EPR96VdD+N GatWYTLk/lk02E8ZoDcZ5urwVxS3/F9XP9Ot1hPxNeBaKa7PiQcg44e2jKDlotzjWMkM VNNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=p1YlSYRsQ9UVFskbeboKg7OM1mMUzIeFuPlepfRb2ro=; b=VXGbJuAHe0pR7hjo5axr+YlvhH060NShvMzcCowyvobjk+W8m15kVJEp5jRX3vuj2r ZWS3QkPw1kQPCv3mpFif/9/HJ0M1SMEpudTduomkKwP4JAExQAJkzFkcnfShG8EhFZZC oZ8Qk4v3tjrmwh7QGHPsvx3R7GcpPsyw4BRrwmzDWh9piG5NmOXX3GYPyQg1qtdpSzP7 MjlW+hbBvVCAR39tjjCPP/wKGQG4pZiAnnzyisftFki0FAN1K+wL+nutvTu03Q/+vt4i yvNtrT489KIKOagFC+MUHQXXJEJPgDdQKEmLb4+491QNnlwW5pRSVnPTOoeTjf8AEdDZ tjZA== X-Gm-Message-State: AODbwcD+H1AHiBMW0p3M3bDNA74uhdH2oYNzHVKTuo4VvjbscvfKH3/+ 7dsY1XlP4KaGaeLwuBrIzxQ+L/T2Xg== X-Received: by 10.107.13.16 with SMTP id 16mr2526195ion.144.1494581912757; Fri, 12 May 2017 02:38:32 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.174.167 with HTTP; Fri, 12 May 2017 02:38:32 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Fri, 12 May 2017 10:38:32 +0100 Message-ID: Subject: Re: [pgAdmin4][PATCH] To fix the issues with CSV file download To: Murtuza Zabuawala Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="001a1140a358ff8888054f50773e" X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a1140a358ff8888054f50773e Content-Type: text/plain; charset="UTF-8" Thanks - patch applied. On Thu, May 11, 2017 at 3:21 PM, Murtuza Zabuawala < murtuza.zabuawala@enterprisedb.com> wrote: > Hi Dave, > > Please find patch to handle non-ascii column names in CSV for Pyhton2. > > Thanks to Harshal for pointing out the issue. > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Mon, May 8, 2017 at 6:06 PM, Dave Page wrote: > >> Thanks, patch applied. >> >> On Mon, May 8, 2017 at 1:14 PM, Murtuza Zabuawala < >> murtuza.zabuawala@enterprisedb.com> wrote: >> >>> Hi, >>> >>> Please find the patch to fix the issues in CSV file download feature, >>> >>> 1) To handle non-ascii filenames which we set from table name >>> RM#2314 >>> >>> 2) To handle non-ascii query data >>> RM#2353 >>> >>> 3) To dump JSON type columns properly in csv >>> RM#2360 >>> >>> Please review. >>> >>> -- >>> Regards, >>> Murtuza Zabuawala >>> EnterpriseDB: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >>> >>> -- >>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >>> To make changes to your subscription: >>> http://www.postgresql.org/mailpref/pgadmin-hackers >>> >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a1140a358ff8888054f50773e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks - patch applied.
On Thu, May 11, 2017 at 3:21 PM, Murtuza Zabua= wala <murtuza.zabuawala@enterprisedb.com> w= rote:
Hi Dave,

<= /div>
Please find patch to handle non-ascii column names in CSV for Pyh= ton2.

Thanks to Harshal for pointing out the issue= .

--Regards,
Murtuza Zabuawala
EnterpriseDB:=C2= =A0http://www.enterprisedb.co= m
The Enterprise PostgreSQL Company

On Mon, May 8,= 2017 at 6:06 PM, Dave Page <dpage@pgadmin.org> wrote:
Thanks, patch applied.
<= div class=3D"gmail_extra">
On Mon, May 8, 201= 7 at 1:14 PM, Murtuza Zabuawala <murtuza.zabuawala@enterp= risedb.com> wrote:
Hi,

Please find the patch to fix the issue= s in CSV file download feature,

1) To handle non-a= scii filenames which we set from table name
RM#2314

2) To handle non-ascii query data
RM#2= 353

3) To dump JSON type columns properly in c= sv
RM#2360

Please review.

--
Regards,Murt= uza Zabuawala
EnterpriseDB:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL Compan= y
=


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-ha= ckers




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter:= @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreS= QL Company




--
Dave Page
Blog: = http://pgsnake.bl= ogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com<= br>The Enterprise PostgreSQL Company
--001a1140a358ff8888054f50773e--