Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1eyyGz-0008R5-7i for pgadmin-hackers@arkaria.postgresql.org; Thu, 22 Mar 2018 11:20:45 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1eyyGx-0001u6-Sr for pgadmin-hackers@arkaria.postgresql.org; Thu, 22 Mar 2018 11:20:43 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1eyyGx-0001tv-MO for pgadmin-hackers@lists.postgresql.org; Thu, 22 Mar 2018 11:20:43 +0000 Received: from mail-wr0-x231.google.com ([2a00:1450:400c:c0c::231]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1eyyGp-00045S-QH for pgadmin-hackers@postgresql.org; Thu, 22 Mar 2018 11:20:43 +0000 Received: by mail-wr0-x231.google.com with SMTP id d10so8271587wrf.3 for ; Thu, 22 Mar 2018 04:20:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=fzBXvhYuGQK5kxcVT7XqD0ioHN10S0hKgoJ4DbMPDjg=; b=Vn2/2NCrij+IoEh7+013lr+QjTlMnoKqXCKx0PPzl2tfPSC+6ERUGJfxT77F/Fn/Uw N+x5ODSeaI3yx6c7HJAKSXnxmjJ/R1ZoEMs5S60lajNpFQS5rHJC0ABJqCTaYYTdVcrW TjlOTqfz04/S/BxzUzhvzMdvBIwpZ0rGS3i/vodKHTdMDZGm0EF+8OkfCamzkoR/1jo1 j7ew55gD/BtTEcil51RpjAc+Abu3Ct0tqsZthY+088SmzSQDSRdxLFXd1Jmo3aH5IFKX LaoT1IZM/qypmSNvEjSjPc6J3F0VuIlE3H06UF+PKqZUf4B3UVRf1j71beMBIWFIoDC0 KEhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=fzBXvhYuGQK5kxcVT7XqD0ioHN10S0hKgoJ4DbMPDjg=; b=XtZ9WB3t9uBzGMk3+7o6+BzRuzAgJMfGYr6wXfTad3X5bF6uSKQ77dAfCxGKzwLTtB gbMOaK1GmZmjYt041mkEnQS1QyU9kAH6miWeYtxUaU29eMxaO1vNi9vgfqDnvOq//jVr Fcuh3K/yT9ZQBFrNcCWdLXhfRIgkwGS3odv/cZdnjG/Kwz0grR2CLP1qeF8knwiGrYmF 2e08hFqpRytgea+1j1GVlKVzMPzskrvAIT5436TrIHgHiEh4xei0QHEUKLOVinVQMlgI n0TZf+cXqnKaNmaGxzGF99c8P/Gz9uDf/BngHtPrDt1Dnzj7CrBqRhTA6dG7N79fxfK+ 23cw== X-Gm-Message-State: AElRT7G8lkBVHwNrPsa2QIxc/oh2/66mW0VK7dvO2Mu72PKCNypFx9zW ApNUI6U7RrtcgLrg9AWgklXcPfbZV5vKYvPHPr50Vw== X-Google-Smtp-Source: AG47ELubEl2YDGz+odfuE+7iA4v4JMdFz766kCbpGNNCoUX+zqqXGqUr49poHg8CjU5I6v1TST/guW3e5cDTurS0NyY= X-Received: by 10.223.196.212 with SMTP id o20mr19027740wrf.144.1521717631828; Thu, 22 Mar 2018 04:20:31 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.69.220 with HTTP; Thu, 22 Mar 2018 04:20:31 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Thu, 22 Mar 2018 11:20:31 +0000 Message-ID: Subject: Re: Little patch for Runtime build from Top Level Directory($PGADMIN_SRC) MakeFile To: Rahul Soshte Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="f403045f7dbce4f70b0567fe7e5f" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --f403045f7dbce4f70b0567fe7e5f Content-Type: text/plain; charset="UTF-8" Thanks - patch applied with a minor change of the target name "runtime-release" to "runtime" (runtime-debug remains the same). On Thu, Mar 22, 2018 at 9:28 AM, Rahul Soshte wrote: > This is my first time trying to make a Patch. > > I am using Ubuntu 17.10. > > This patch is in reference to the Feature Added by Dave Page > https://redmine.postgresql.org/issues/1305 > > I just added code to call makefile in runtime directory( > $PGADMIN_SRC/runtime/Makefile ) from the top level directory's MakeFile ( > $PGADMIN_SRC/Makefile ) > > > I followed the checklist for submitting a patch sent by Murutuza Zabuawala > > <================================> > Hello, > > Here is the common checklist to follow before sending patch to > pgAdmin4-hackers group, > > 1) Get the latest pull from master branch. > > 2) Apply your patch and check if applies successfully on the latest code. > > 3) Check for PEP8 issues > - activate virtual env > - cd ../web > - yarn run pep8 > > 4) Run regression test > python regression/runtests.py > > - To run only UI/feature tests > python regression/runtests.py --pkg feature_tests > > - To run regression test (without UI/Feature tests) > python regression/runtests.py --exclude feature_tests > > 5) Run Jasmine tests > - activate virtual env > - cd ../web > yarn run test:karma-once > > 6) Make sure to add or update help docs and screenshot(s) if you have > added any new feature or changed any existing one. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > <===================================================> > > But I am facing some issues, > Step 1,2,3 and 5 had no issues > But when I tried step 4 it gave some errors > I executed the following command > > *python regression/runtests.py * > > I got the following errors: > 1)The screenshot attached show I wasnt able to connect to the server > 2) the error ouput on the command line: > =============Running the test cases for 'PostgreSQL 9.4'============= > Traceback (most recent call last): > File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", > line 128, in create_database > server['sslmode'] > File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", > line 36, in get_db_connection > sslmode=sslmode > File "/var/www/flask/pgadmin4/local/lib/python2.7/site-packages/psycopg2/__init__.py", > line 130, in connect > conn = _connect(dsn, connection_factory=connection_factory, **kwasync) > OperationalError: FATAL: password authentication failed for user > "postgres" > FATAL: password authentication failed for user "postgres" > > Traceback (most recent call last): > File "regression/runtests.py", line 350, in > server_information = test_utils.create_parent_server_node(server) > File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", > line 491, in create_parent_server_node > server_info['sslmode'] > File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", > line 36, in get_db_connection > sslmode=sslmode > File "/var/www/flask/pgadmin4/local/lib/python2.7/site-packages/psycopg2/__init__.py", > line 130, in connect > conn = _connect(dsn, connection_factory=connection_factory, **kwasync) > psycopg2.OperationalError: FATAL: password authentication failed for user > "postgres" > FATAL: password authentication failed for user "postgres" > > Traceback (most recent call last): > File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", > line 619, in _cleanup > connection = get_db_server(database["server_id"]) > File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", > line 593, in get_db_server > db_name, username, db_password, host, db_port, ssl_mode > File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", > line 36, in get_db_connection > sslmode=sslmode > File "/var/www/flask/pgadmin4/local/lib/python2.7/site-packages/psycopg2/__init__.py", > line 130, in connect > conn = _connect(dsn, connection_factory=connection_factory, **kwasync) > OperationalError: FATAL: password authentication failed for user > "postgres" > FATAL: password authentication failed for user "postgres" > > I have no password authentication errors when I am connecting from the > application.I had also changed password for postgres manually through the > command line. > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --f403045f7dbce4f70b0567fe7e5f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks - patch applied with a minor change of the target n= ame "runtime-release" to "runtime" (runtime-debug remai= ns the same).

On Thu, Mar 22, 2018 at 9:28 AM, Rahul Soshte <rahulsoshte360@gma= il.com> wrote:
This is my first time trying to make a Patch.
<= /div>
I am using Ubuntu 17.10.

This patch is in reference to the = Feature Added by Dave Page
https://redmine.postgresql.org/issues/130= 5

I just added code to call makefile in runtime directory(= $PGADMIN_SRC/runtime/Makefile ) from the top level directory's MakeFil= e=C2=A0 ( $PGADMIN_SRC/Makefile )


I followed the che= cklist for submitting a patch sent by Murutuza Zabuawala

<=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D>
Hello,

Here is the co= mmon checklist to follow before sending patch to pgAdmin4-hackers group,

1) Get the latest pull from mast= er branch.

2) Apply your patch= and check if applies successfully on the latest code.
=
3) Check for PEP8 issues
- act= ivate virtual env
- cd ../web
- yarn run pep8

4) Run regression test
python regression/runtests.py=C2=A0

- To run onl= y UI/feature tests
python regression/r= untests.py --pkg feature_tests=C2=A0

- To run regress= ion test (without UI/Feature tests)
python regression/runtests.py --exclude feat= ure_tests=C2=A0

5) Run Jasmine tests
- activate virtual env
- cd ../web
yarn run=C2=A0test:karma-once

6) Make sure to add or update help docs and= screenshot(s) if you have added any new=C2=A0f= eature=C2=A0or changed any existing one.

--
Regards,
= Murtuza Zabuawala
E= nterpriseDB:=C2=A0http://www.enterprisedb.com
The Enterprise= PostgreSQL Company
=
<=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D>

But I am facing some issues,
Step 1,2,3 and 5 had no issues
But when I tried step 4 it = gave some errors
I executed the following command
=C2=A0python regression/runtests.py=C2=A0

= I got the following errors:
1)The screenshot attached show I = wasnt able to connect to the server
2) the error ouput on the= command line:
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3DRunning the test c= ases for 'PostgreSQL 9.4'=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3DTraceback (most recent call last):
=C2=A0 File "/var/www/flask/pga= dmin4/pgadmin4/web/regression/python_test_utils/test_utils.py&quo= t;, line 128, in create_database
=C2=A0=C2=A0=C2=A0 server['sslmode&= #39;]
=C2=A0 File "/var/www/flask/pgadmin4/pgadmin4/web/regres= sion/python_test_utils/test_utils.py", line 36, in get_db_connect= ion
=C2=A0=C2=A0=C2=A0 sslmode=3Dsslmode
=C2=A0 File "/var/www/f= lask/pgadmin4/local/lib/python2.7/site-packages/psycopg2/__init__= .py", line 130, in connect
=C2=A0=C2=A0=C2=A0 conn =3D _connect(dsn= , connection_factory=3Dconnection_factory, **kwasync)
OperationalEr= ror: FATAL:=C2=A0 password authentication failed for user "postgres&qu= ot;
FATAL:=C2=A0 password authentication failed for user "postgres&= quot;

Traceback (most recent call last):
=C2=A0 File "regres= sion/runtests.py", line 350, in <module>
=C2=A0=C2=A0=C2=A0 s= erver_information =3D test_utils.create_parent_server_node(server)
= =C2=A0 File "/var/www/flask/pgadmin4/pgadmin4/web/regression/pyth= on_test_utils/test_utils.py", line 491, in create_parent_server_n= ode
=C2=A0=C2=A0=C2=A0 server_info['sslmode']
=C2=A0 File &qu= ot;/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_ut= ils/test_utils.py", line 36, in get_db_connection
=C2=A0=C2=A0=C2= =A0 sslmode=3Dsslmode
=C2=A0 File "/var/www/flask/pgadmin4/local/lib/python2.7/site-packages/psycopg2/__init__.py", line 130, i= n connect
=C2=A0=C2=A0=C2=A0 conn =3D _connect(dsn, connection_factory= =3Dconnection_factory, **kwasync)
psycopg2.OperationalError: FATAL:= =C2=A0 password authentication failed for user "postgres"
FATA= L:=C2=A0 password authentication failed for user "postgres"
Traceback (most recent call last):
=C2=A0 File "/var/www/flask/pg= admin4/pgadmin4/web/regression/python_test_utils/test_utils.py&qu= ot;, line 619, in _cleanup
=C2=A0=C2=A0=C2=A0 connection =3D get_db_serv= er(database["server_id"])
=C2=A0 File "/var/www/flas= k/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.p= y", line 593, in get_db_server
=C2=A0=C2=A0=C2=A0 db_name, username= , db_password, host, db_port, ssl_mode
=C2=A0 File "/var/www/flask/= pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py&= quot;, line 36, in get_db_connection
=C2=A0=C2=A0=C2=A0 sslmode=3Dsslmod= e
=C2=A0 File "/var/www/flask/pgadmin4/local/lib/python2.7/sit= e-packages/psycopg2/__init__.py", line 130, in connect
=C2=A0= =C2=A0=C2=A0 conn =3D _connect(dsn, connection_factory=3Dconnection_fa= ctory, **kwasync)
OperationalError: FATAL:=C2=A0 password authentication= failed for user "postgres"
FATAL:=C2=A0 password authenticati= on failed for user "postgres"

I have no passwor= d authentication errors when I am connecting from the application.I had als= o changed password for postgres manually through the command line.



--
Dave Page
Blog: = http://pgsnake.bl= ogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com<= br>The Enterprise PostgreSQL Company
--f403045f7dbce4f70b0567fe7e5f--