Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aoSJT-0002Iu-VM for pgadmin-hackers@arkaria.postgresql.org; Fri, 08 Apr 2016 09:02:48 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1aoSJT-0005PQ-I9 for pgadmin-hackers@arkaria.postgresql.org; Fri, 08 Apr 2016 09:02:47 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1aoSJT-0005PJ-2n for pgadmin-hackers@postgresql.org; Fri, 08 Apr 2016 09:02:47 +0000 Received: from mail-io0-x234.google.com ([2607:f8b0:4001:c06::234]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1aoSJO-0001Pk-7t for pgadmin-hackers@postgresql.org; Fri, 08 Apr 2016 09:02:46 +0000 Received: by mail-io0-x234.google.com with SMTP id g185so124661845ioa.2 for ; Fri, 08 Apr 2016 02:02:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=YUqX3+ri/jz9MMz6my0IHriUEhbXWvOAJxWp//QS5lY=; b=djuNXhJchpIGXJJppLZvnrFpl266GQCJhOd1HcQD5h9hAlGtGv655Ikaufl0uH7iW4 uSj37vifngj8z7Y00RzknNXXGhtUDtcWeB1yrtOsN0MmK0Gz+AQ1lmikBY1DC/4iw7hy eFyzrXYmaEw5JLC9F75M1BUkEJzwgNeBCtwj3DXyO4b7TC1KgtbvWVUkiQcud9IgeW1C FPywtQ/KRnfH+wBJW0txsjpeufwzYGazGCK36yPyVX3O3i211tYw143r92KrcPgpZUcz jy0OXD1XGDtQdQHVZtQOb2iaNab8WCScmpcZ+N7SyIil/wVlMBT6fFNNK6dlAFycc3st kogA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=YUqX3+ri/jz9MMz6my0IHriUEhbXWvOAJxWp//QS5lY=; b=abZSLciwNuwazWil+Lq/TXyjsuB7N9UcEpiVRw37IgkSKVyCK1wemd6kB+9/ajkjhX 6GhO8O3E9cJvQ8K3eRJumQ5ILymWLvpkKo2BsUlbhPOxBpGIrMuaDZgyHVyUflgQe8NE CCVqvd1zjTcsCpzNOBZZ2eL96RDn2UTYp2JHpubqWZhLGF4lmQNMXQ7SKiD9htE5K5Dg EZxhVyCmVleOGly9MkYuvpcPZSBFthT3r2sR2SAC+6XbSnNYkUiyWB2MQDRAW/dna7u7 fHZmCkcwfloP27qtBJxvi5lSPogv8QY2Y0X2eVVkiS5FSDedqYbIsgVu+7UVIqOwYphY nYwA== X-Gm-Message-State: AD7BkJKGJCWJfrZFItggC7rw/Ou3gEwT10cw1AgB3A4X7oslw5p7E3xHOPuCPYamqapYVIuW4F+4NCSd34wfMQ== MIME-Version: 1.0 X-Received: by 10.107.12.224 with SMTP id 93mr8338741iom.70.1460106160361; Fri, 08 Apr 2016 02:02:40 -0700 (PDT) Received: by 10.64.105.131 with HTTP; Fri, 8 Apr 2016 02:02:40 -0700 (PDT) In-Reply-To: References: Date: Fri, 8 Apr 2016 10:02:40 +0100 Message-ID: Subject: Re: [pgAdmin4] [Patch] Implementation of the Data Grid and Query Tool From: Dave Page To: Akshay Joshi Cc: pgadmin-hackers Content-Type: multipart/related; boundary=001a113f91ae064d1f052ff5753a X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a113f91ae064d1f052ff5753a Content-Type: multipart/alternative; boundary=001a113f91ae064d1c052ff57539 --001a113f91ae064d1c052ff57539 Content-Type: text/plain; charset=UTF-8 On Fri, Apr 8, 2016 at 7:43 AM, Akshay Joshi wrote: > > >>>>>> - The Query Tool menu icon should be a glyphicon, to match the others. >>>>>> >>>>> >>>>> There is no glyphicon available which match the Query Tool icon. I >>>>> have found one like below which is "database-search" or can you please >>>>> suggest some other icon. >>>>> [image: Inline image 1] >>>>> >>>> >>>> That one looks perfect. >>>> >>> > We can't use this icon because it's not come with Bootstrap , I > have picked this from "http://glyphicons.com/" and I am not sure we can > use it as per the Licence. > At the risk of annoying everyone immensely, on reflection I'm thinking we should use Font Awesome as our default generic icons, and fall back to Bootstrap's Glyphicons. I really hadn't realised how much larger the FA set is. For this particular issue, could we use FA's stacking? e.g. something like: https://jsfiddle.net/pa8x6nt3/ If not, how about using the execute icon we discussed, e.g. fa-bolt? -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a113f91ae064d1c052ff57539 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On Fri, Apr 8, 2016 at 7:43 AM, Akshay Joshi <akshay.joshi= @enterprisedb.com> wrote:
<= div class=3D"gmail_quote">

- The Query Tool menu icon should be a glyphico= n, to match the others.
=C2=A0
=C2=A0 =C2=A0There is no glyphicon available whi= ch match the Query Tool icon. I have found one like below which is "da= tabase-search" or can you please suggest some other icon.=C2=A0
<= div>=C2=A0 =C2=A0 =C2=A0 =C2=A03D"==C2= =A0

That one= looks perfect.

=
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0We can't use this icon be= cause it's not come with Bootstrap , I have picked this from "http://glyphicons.com/= " and I am not sure we can use it as per the Licence.

At the risk of annoying everyone im= mensely, on reflection I'm thinking we should use Font Awesome as our d= efault generic icons, and fall back to Bootstrap's Glyphicons. I really= hadn't realised how much larger the FA set is.

For this particular issue, could we use FA's stacking? e.g. somet= hing like:=C2=A0https://jsfiddle= .net/pa8x6nt3/=C2=A0

If not, how about using t= he execute icon we discussed, e.g. fa-bolt?

--=C2= =A0
Dave Page
Blog: http://pgsnake.blogspot.com=
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Ent= erprise PostgreSQL Company
--001a113f91ae064d1c052ff57539-- --001a113f91ae064d1f052ff5753a Content-Type: image/png; name="image.png" Content-Disposition: inline; filename="image.png" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: ii_153efa7c0422527f iVBORw0KGgoAAAANSUhEUgAAAGYAAABkCAYAAAB0F0VpAAAJMUlEQVR4Ae2cR4gUTRTH3wZzzjnn nHNCPAgiHgwHFVFBUBEDCC6CyKfgQfGkBxEzhosHj6KgKKKIiGIOmDCnNee0H7+C6q+nd2d3Zqdm 5rlfPSi6p6b6dfX/3/XqvVc1k1NYWFgkXtQhkKuuR75DBgFPjNIXwRPjiVGKgNJu+RHjiVGKgNJu +RHjiVGKgNJu+RHjiVGKgNJu+RHjiVGKgNJu+RHjiVGKgNJu+RHjiVGKgNJu+RHjiVGKgNJu+RHj iVGKgNJu+RHjiVGKgNJu+RHjiVGKgNJu+RHjiVGKgNJu+RHjiVGKgNJu+RGjlJh8pf0KuvXlyxd5 8OCBPHz4UD5+/CifPn0y5fPnz0KhjjZI9erVpWbNmqbUqFFDKLVq1TKldevW0rZtW9MmUK74JEfj zzCePHkiZ8+elfPnz8uzZ89KhA8S6tSpI9WqVTOFRl+/fjXl/fv3AVnRi5s1ayYDBw6UoUOHSosW LaJfq/msipi3b9/K/v37DSElIdS4cWOZNm2adO7cWZo0aSI5OTmmhNsWFRUJ5cWLF3L79m05ePCg vHz5MtwkOIegmTNnSr169YI6LSeq5pgtW7bEJQXAfv/+Lbm5uWaEQAry58+fmEId3zGSaMs18YQR yT01iqo5hje8NCksLJTNmzebJoDO/MGcgklDMGHMQcw7EJaIlHXPRHSko40qYpJ5QICHCApzUkUT VaasooGbyvN4YlJBL43XemLSCG4qqj0xqaCXxmtVEdOtW7c0PmrJqrNxz5J7Eluriphly5aZiDy2 i+n7RPTPPTWKqsi/atWqkpeXJ48ePZLTp0+btIxrV5g0DISMGDFCWrVqZQLQb9++qeNGFTGHDx82 oLVs2TIAikTl/fv3Tfnw4UOQyCSItElMgkrEJjA5EnySxKxdu7Yp7dq1Ewp1VghYT548KePHj7dV ao6qiJkzZ44Bpnfv3uaN7tmzp5Afcylv3ryRy5cvy7lz5+TSpUvy48cP2b17t8tbONGlMvIHOApC grFTp04madmoUSNp0KCB1K9f34wCMsxVqlQx5o+25MW+f/9uMsuMIpKiEEFC8+nTp2b54NWrV06A S7cSlcSEHxpwebv/b6KemFQJYf2FEUZhtFWqVEnevXsnr1+/lps3b5r1m1TvkY7rKyQxzZs3l1Gj Rsno0aNLnaN+/fplyEkHsKnqrFDE4IktWLBABg8eHOBCFtountmlANZrWDbANcfBwLvTJqqIwZ3F NS6P9OjRQxYvXmzMFQQwGpjo7927Z3SybwBh3d+6zjgWEKRRVLnLeFR79+6VM2fOJLzQBah9+/aV lStXmpVLdOCRsaR8/PjxUjEfN26cTJ06NdgzUGrjDH+pihi7HMzEfOTIERNnsDumtOVhVi83btxo AkpIuXbtmuzatcuMlkSwxAWfO3eudO/ePZHmGWujihjIYNIGLCsEgJi3O3fumHiE6B+viiOrl4sW LZI+ffoIaZXr16/Lhg0b7KXBkSC1Y8eOUrlyZXn+/LncunXLzDtBAxFZsWKFKnJUEUPkn5+fb7YX 9e/f35iosnawMLGzbYm9ZatXr44ZKWQQ5s+fX8wzY9fMnj17YuIjXoa1a9eqMWvqiAm/xXhPvO0k HinEJJguWwDz58+fxtQxNx07diy4fPr06TJ58mTzGWcg7JHhjWEeN23aZOYzexFzzqxZs+zHrB5V eWVRJOz+MFIqFy5ciH5tth4xL5EdCJPCSIEUm6JBT1ggHLO2ZMkS473ZzAI6Jk6cqGKfmU5fMYxi nHMieUhBoi425ou5iXknSgrtqcNR4Dh79uyYTYNRXXFun/bqv5aY8NKAjVFAC9NH6gUTV5ZADgR3 6dIlaBrWFVRm4aTCEYP3BeCJCiOradOmQXNPTADFfydE5IkK6X4rzBlWmDtKMl/2++iRtuH2WlYz VY2YgoICGTlyZEJpEuIRK+3bt7encX8dEDQo4SSsC89Pg6gihphl6dKlZn/ypEmTpEOHDnFJCoNJ OyvsRSZzkKjQNrx/OWzWEtWRjnaq3OVDhw7JsGHDhLS9jSeYL4j68ZZYo2dFkhI2OSQmrWCWDhw4 YDICxCulCe40ba0pwySyUUODqAswyfaSlBw+fLh07drVLCmXBBQBIxE/AgH79u0z+TXbltQ/bnM8 ciBl69atMdE/pJChTsSjs/dJ11HViOEhAZxg0gaUmDdMFT9UwhUm2ifyZ/cL6RtiGa7hB0gXL14M fqRE0Ejqf8aMGdKwYcMY/DBfjBR7D/tlmzZtzDX2czaP6kZMMmDgga1bt86QxTnJyTVr1sSowDzh QkMsQhYB02jNV0xjEZNpHjNmTLQ645//amJAq1evXrJ8+XIDHKOHDDO/Eov3875EEGYZINvkqPLK EgEt2ubKlStm1yb1OAosFbM+U9YmPkbSkCFDZMqUKVGVZj3nxIkTxeozWaFujinPw+/cuVPYXjtg wADjEBB8zps3zyQy7969K7bgyeEOU6z3x/3q1q0rO3bsiLk1mwAxd2PHjo2pz9QHVaZs/fr1cuPG jXI9O97XwoULzVoOCphz2KpUmuAc4DjQlkW67du3F2tOkjMb5OQVFBT8U6w3WaoYNGiQCQ4fP36c dA94u/HE8Lj4uTlEATxuMeAjtOGcesyeJYZ6Epl4e1FPjW206AuvqibduXJcoIoYNoOzCx8zw7nd RJ7Mc7FH4NSpU4YYMseYNUtGlCirl+/jkUO6Z8KECWWOPqvL1VGVKWNCxqwQn1hJdrc/+5nDf13S r18/sycgkW1K3Bcijx49Ktu2bTNu9qpVq0xayI462690H1URYx8WggCJkgig9jp75O0nnY8Z4zwZ seRcvXpVGC0QFU7/JKMrlbYqiYk+EOQwZ0AYwjFcwu0hIlwgh5KMWHK4Lhuk0Nf/bEYyPc9wW8xI Jk2JdQoyec8opH99gBl9IFefs0kKz+CJccWkYz2eGMeAulLniXGFpGM9nhjHgLpS54lxhaRjPZ4Y x4C6UueJcYWkYz2eGMeAulLniXGFpGM9nhjHgLpS54lxhaRjPZ4Yx4C6UueJcYWkYz2eGMeAulLn iXGFpGM9nhjHgLpS54lxhaRjPZ4Yx4C6UueJcYWkYz2eGMeAulLniXGFpGM9nhjHgLpS9y9BjyDx r+DRaQAAAABJRU5ErkJggg== --001a113f91ae064d1f052ff5753a--