Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1eulUZ-0003OH-6B for pgadmin-hackers@arkaria.postgresql.org; Sat, 10 Mar 2018 20:53:23 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1eulUW-0003qZ-G9 for pgadmin-hackers@arkaria.postgresql.org; Sat, 10 Mar 2018 20:53:20 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1eulUW-0003qL-69 for pgadmin-hackers@lists.postgresql.org; Sat, 10 Mar 2018 20:53:20 +0000 Received: from mail-wr0-x241.google.com ([2a00:1450:400c:c0c::241]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1eulUS-0004DV-0G for pgadmin-hackers@postgresql.org; Sat, 10 Mar 2018 20:53:19 +0000 Received: by mail-wr0-x241.google.com with SMTP id v18so12070700wrv.0 for ; Sat, 10 Mar 2018 12:53:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=rs3zeO637yWByDYPef3hCotqyhG49PQGScNVEwh73lI=; b=L9pesd5UUpP3fL0n1vIWc2ezr5hf8BhG6Al+vCmbMsn7FUy3+zR6GPfiNSAeXFhhAD nDYked4BWfJeU3Qj7L/Kl4eb2BAnUmu1AqzfBgphqcGq680oi/Nupc3LaGDoLZt6imGp gjj673s6hMTnAst5HJwPq+jBADhwWAVHrJuZvLle8GSF6DM6qzItE+X5uZZX5UiKU56p wG2QLCYKtjbxtQFNYgW+Qzh1G/2+aY8OOnmQUYLvimDf+QZN9p8GwzIS5ho7IBiLs9rH y6guumIe93sA86S0qqUFfZFOKUR9P67B3tyJ7z254NI/ko8t3tu5jZ10LhTSIrMm88vf z9Ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=rs3zeO637yWByDYPef3hCotqyhG49PQGScNVEwh73lI=; b=RQ6EKkDqtrkXLowwk3B0Lx0gVLp7xyF8x/7vNyeiDZ5TILWxSAqeDjBY613bo2Z8JH r+ffhUDIpCoK16zecYETWWP3+9X+mkenwf/WFjedmi1AIWp54dXg5o6Q/cagKa/Jqr3l 4pfd2/0CqPjyo7ynBqRzEKJGUHIkgqm3r1pBDHpmGpUJKfwm7M1Okt+uJ8RTf2lLRx4F //oIF1apjcDAHItt8kbEAfRcMIdKQVFdcbku/HsvWYHM+LE5GYlRzZOGzM31jkd7Soeo d9xePzqT1HReF0do1KPuZdl9ZZtKXGNozNgAGEanI55p7EMqyX/8RwucUq42eqx5tCPE O26A== X-Gm-Message-State: AElRT7HrQe1wsoX4+S42Qo8Jk2QSPv/Kv+fnRaLPX8axhhq5KGt1NSTf /BzB5JaqAKhNsuyaxZ7WfeSxApy6tdNdE2py013blw== X-Google-Smtp-Source: AG47ELtcG1PIurrxDO+LrfRVz1K9X9H0QT59J3bh7Gd5Ey/RmIHXkTx/Lhb9pF0Mbv3RwL7pMqoesYMgWp93DK2+sy4= X-Received: by 10.223.153.215 with SMTP id y81mr2261830wrb.144.1520715194496; Sat, 10 Mar 2018 12:53:14 -0800 (PST) MIME-Version: 1.0 Received: by 10.28.109.7 with HTTP; Sat, 10 Mar 2018 12:53:13 -0800 (PST) In-Reply-To: References: From: Dave Page Date: Sat, 10 Mar 2018 20:53:13 +0000 Message-ID: Subject: Re: [pgadmin4][patch] Unit test fail on GreenPlum (#3190) To: Joao De Almeida Pereira Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="f403045ce2eaf90e5e0567151878" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --f403045ce2eaf90e5e0567151878 Content-Type: text/plain; charset="UTF-8" Hi On Friday, March 9, 2018, Joao De Almeida Pereira < jdealmeidapereira@pivotal.io> wrote: > Hello Hackers, > > Attached you can find the patch that skip some tests and correct issues on > SQL that are failing when trying to connect to a GreenPlum database. > > We did this by adding a attribute to to test_json called "db_type" that > will carry the type of database we are running tests against. > Any reason we can't do that dynamically as we do with the EPAS-specific tests? > > When we run tests against a GreenPlum instance the configuration would > look like this: > > { > "name": "GreenPlum", > "comment": "GreenPlum DB", > "db_username": "gp", > "host": "localhost", > "db_password": "", > "db_port": 5433, > "maintenance_db": "postgres", > "sslmode": "prefer", > "tablespace_path": "", > "enabled": true, > "db_type": "gpdb" > } > > > > > Thanks > Joao > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --f403045ce2eaf90e5e0567151878 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi

On Friday, March 9, 2018, Joao De Almeida Pereira <jdealmeidapereira@pivotal.io> w= rote:
Hello Hackers,
Attached you can find the patch that skip some tests and co= rrect issues on SQL that are failing when trying to connect to a GreenPlum = database.

We did this by adding a attribute to to = test_json called "db_type" that will carry the type of database w= e are running tests against.

An= y reason we can't do that dynamically as we do with the EPAS-specific t= ests?
=C2=A0

When we run tests against a GreenPlum instance the con= figuration would look like this:
{
  "nam=
e": "GreenPlum",
  <=
span style=3D"color:rgb(152,118,170)">"comment": &=
quot;GreenPlum DB",
  "db_username": "gp",
  "host&q=
uot;: "localhost",
  "db_password": =
"",
  "db_port": 5433,
  =
"maintenance_db": "postgres",  "sslmode": "prefer"<=
/span>,
  "ta=
blespace_path": "",
  "enabled": true,
  "db_type": "gpdb"
}



Thanks
Joao


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @= pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL= Company

--f403045ce2eaf90e5e0567151878--