Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bL5Dp-00026G-GK for pgadmin-hackers@arkaria.postgresql.org; Thu, 07 Jul 2016 09:03:49 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bL5Dp-0005qO-3h for pgadmin-hackers@arkaria.postgresql.org; Thu, 07 Jul 2016 09:03:49 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bL5Db-0005NY-Nz for pgadmin-hackers@postgresql.org; Thu, 07 Jul 2016 09:03:35 +0000 Received: from mail-it0-x230.google.com ([2607:f8b0:4001:c0b::230]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bL5DX-0004yI-PN for pgadmin-hackers@postgresql.org; Thu, 07 Jul 2016 09:03:35 +0000 Received: by mail-it0-x230.google.com with SMTP id f6so15379638ith.0 for ; Thu, 07 Jul 2016 02:03:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=JjcYUg7YGhLDTjyuZQeHTtfkby58lZH88jjBhoPrQjU=; b=xKvnN8Cua8GUIT8i9U+d9ZlOs3cttnt5qVsKvrq+FY7sO/W0xL8iXwtzqyKXl724bK WstjJinfy0fJqwRkqzuDHriac52aAGzjO8PHYDu8h814e7DayfeUWkGXg9qTGyMXgS88 JXD3ZLSscHzhjaNnlSJVTb5X/q1YCcLR8ICKwHkd8e9de/xLrpTNxmvVvmWad2/TF+s/ 8ielbAtyTVFIpttKDWDqNuJs500bLPq3G5rOBMG7G/Qzgj5iOWbIoiyJFFtpRnJQk3WM v5AW/QYcQ6h6TLcRzCDGGSNop8b6atww6JRSUIxN2H9N00yxpSYvNqxwKDXzZn/oxT+Y 6+3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=JjcYUg7YGhLDTjyuZQeHTtfkby58lZH88jjBhoPrQjU=; b=VqrbjCb0fPSeOZooAwJLuVv7M6rg916VWE3S6IMAlVvMLGDtsIomzV7DhFDF0Q2/R2 zr2jrvZBZKiygSzUd/m9tBOQalAa8QzwJWNa5yoM/i8rxP+Wlg5pWw8qgfM58jKCtlVC XYAyPAwnvrA0PUrOJVueLBya1SAUxCG5Zv425yzBM5FHG9va3GD94jraJYbao8pwgy4N dbqRy4HD5oa118wWQzpaSZWZ83T25UBFHiesfV5l3Gev+sOsMtzY/sgQ6pgrDS4zqJBk frpnWLVbXKCEJZFOTL1+SuJaHnLZrEteqBlu6faVlrFhnZy5wm7qHTW/ATnZgsuMJufu sCIA== X-Gm-Message-State: ALyK8tLScz083GXCnm6XAv9monPh9uuLOebTUfJMLkt4nYHfepdRnbU+qJ/JoYzstNthagKxoPQZ9TwRzbvORw== X-Received: by 10.36.117.200 with SMTP id y191mr521328itc.35.1467882210227; Thu, 07 Jul 2016 02:03:30 -0700 (PDT) MIME-Version: 1.0 Received: by 10.64.24.208 with HTTP; Thu, 7 Jul 2016 02:03:29 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Thu, 7 Jul 2016 10:03:29 +0100 Message-ID: Subject: Re: patch for issue RM1260 [pgAdmin4] To: Harshal Dhumal Cc: Ashesh Vashi , pgadmin-hackers Content-Type: multipart/alternative; boundary=001a114aba52b693c6053707f53d X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a114aba52b693c6053707f53d Content-Type: text/plain; charset=UTF-8 Ashesh, can you review/commit please? Thanks. On Thu, Jul 7, 2016 at 7:50 AM, Harshal Dhumal < harshal.dhumal@enterprisedb.com> wrote: > Hi, > > By mistake I deleted a line which was not supposed to be deleted, and that > line of code was initialization of select2. > > -- > *Harshal Dhumal* > *Software Engineer* > > EnterpriseDB India: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Thu, Jul 7, 2016 at 12:13 PM, Ashesh Vashi < > ashesh.vashi@enterprisedb.com> wrote: > >> Hi Harshal, >> >> Can you please explain - what was missing in the last patch? >> >> -- >> >> Thanks & Regards, >> >> Ashesh Vashi >> EnterpriseDB INDIA: Enterprise PostgreSQL Company >> >> >> >> *http://www.linkedin.com/in/asheshvashi* >> >> >> On Thu, Jul 7, 2016 at 12:12 PM, Harshal Dhumal < >> harshal.dhumal@enterprisedb.com> wrote: >> >>> Hi, >>> >>> PFA updated patch for issue RM1260 >>> >>> -- >>> *Harshal Dhumal* >>> *Software Engineer* >>> >>> EnterpriseDB India: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >>> On Thu, Jul 7, 2016 at 12:04 PM, Harshal Dhumal < >>> harshal.dhumal@enterprisedb.com> wrote: >>> >>>> Hi, >>>> Please ignore this patch as this has some minor issue. I'll sent >>>> updated one. >>>> >>>> -- >>>> *Harshal Dhumal* >>>> *Software Engineer* >>>> >>>> EnterpriseDB India: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>>> On Wed, Jul 6, 2016 at 5:30 PM, Harshal Dhumal < >>>> harshal.dhumal@enterprisedb.com> wrote: >>>> >>>>> Hi, >>>>> >>>>> PFA patch for issue RM1260. >>>>> >>>>> Changes: Issue wasn't related to foreign table but was due the Select2 >>>>> control. Now I have improved select2 control to handle null value in >>>>> multi-select mode. Initial it was returning "null" instead it should return >>>>> [] (empty array). >>>>> >>>>> >>>>> -- >>>>> *Harshal Dhumal* >>>>> *Software Engineer* >>>>> >>>>> EnterpriseDB India: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>> >>>> >>> >>> >>> -- >>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >>> To make changes to your subscription: >>> http://www.postgresql.org/mailpref/pgadmin-hackers >>> >>> >> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a114aba52b693c6053707f53d Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Ashesh, can you review/commit please?

T= hanks.

On Thu, Jul 7, 2016 at 7:50 AM, Harshal Dhumal <harshal.dhu= mal@enterprisedb.com> wrote:
Hi,

By mistake I deleted a line which = was not supposed to be deleted, and that line of code was initialization of= select2.

--=C2=A0
Harshal Dhumal
Software Engineer

EnterpriseDB India:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL Company
<= /div>
On Thu, Jul 7,= 2016 at 12:13 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com= > wrote:
H= i Harshal,

Can you please explain - what was missing in = the last patch?

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Co= mpany

<= br>

<= a href=3D"http://www.linkedin.com/in/asheshvashi" target=3D"_blank">http= ://www.linkedin.com/in/asheshvashi


On Thu, Jul 7, 2016 at 12:12 PM, H= arshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,

PFA updated patch for issue RM1260
=

=
--=C2=A0
Harshal Dhumal
Software Enginee= r

EnterpriseDB India:=C2=A0http://www.enterprisedb.com
T= he Enterprise PostgreSQL Company

On Thu, Jul 7, 2016 at 12:04 PM= , Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,
Plea= se ignore this patch as this has some minor issue. I'll sent updated on= e.

<= div>
--=C2=A0
Harshal Dhumal
Soft= ware Engineer

EnterpriseDB India:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Jul 6, 2016 at 5:30= PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com>= wrote:
Hi,

PFA patch for issue RM1260.

Changes: Issue w= asn't related to foreign table but was due the Select2 control. Now I h= ave improved select2 control to handle null value in multi-select mode. Ini= tial it was returning "null" instead it should return [] (empty a= rray).


--=C2=A0
Harshal Dhumal
=
Software Engineer

EnterpriseDB India:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL Company




--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers=






--
Dave Page
Blog: = http://pgsnake.bl= ogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com<= br>The Enterprise PostgreSQL Company
--001a114aba52b693c6053707f53d--