public inbox for [email protected]  
help / color / mirror / Atom feed
From: Dave Page <[email protected]>
To: Florian Sabonchi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Cc: Khushboo Vashi <[email protected]>
Subject: Re: OAuth error when logging in
Date: Mon, 29 Mar 2021 08:27:41 +0000
Message-ID: <CA+OCxoweunYZGJ5kx=c8YCRjuAeOXV48YbBZrJ6BL3n8Mriz=Q@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>

Hi

On Mon, Mar 29, 2021 at 9:21 AM Florian Sabonchi <[email protected]> wrote:

> Hello I would like to integrate OAuth in PG-Admin. Unfortunately I have
> the error that I am redirected back to the home page. Unfortunately I
> could not find this error, what surprises me is that
> current_user.is_authenticated is set to True. For this reason I just
> wanted to ask maybe someone knows what the problem is. You can find my
> source code here:
>
>
> https://github.com/FlorianJSa/pgadmin4/blob/OAuth2/web/pgadmin/authenticate/__init__.py
>
>
> I would be very happy if someone could help me with this problem.
> Because I unfortunately have no idea what this could be for an issue
>

Khushboo (CC'd) is most familiar with this code as she wrote the plugin
auth system - hopefully she can help point you in the right direction.

However; we have discussed OAuth briefly in the past and never quite
figured out what to do about saving Postgres passwords. Have you thought
about that? The issue is that we won't have anything secret to use in an
encryption key as pgAdmin won't see the user's password. We have the same
issue with Kerberos, however the solution we came up with there was to
simply disable password saving which is fine because in most environments
the user will use Kerberos to authenticate to Postgres anyway (which
Khushboo is working on right now).

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EDB: http://www.enterprisedb.com


view thread (3+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: OAuth error when logging in
  In-Reply-To: <CA+OCxoweunYZGJ5kx=c8YCRjuAeOXV48YbBZrJ6BL3n8Mriz=Q@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox