MIME-Version: 1.0
In-Reply-To: 
 <CAKKotZRszTNg8-_eB=km-ESdpwwt20JKr4V68s4WZQwnwHJPWw@mail.gmail.com>
References: 
 <CAKKotZTLPHRfS0W13pw9X9yViuGho_D6gn31BtU54WbMsx3VBg@mail.gmail.com>
 <CA+OCxoy0ZVietUm3piNLjApyUwnqZBUGSUPq_ct=Mfh6WQn=DA@mail.gmail.com>
 <CAKKotZSrRATVsJNzdjRg4A9fQO3p=Y8SozuUZFKVN-z+U3xD+Q@mail.gmail.com>
 <CA+OCxozgrXCQjnUSpskFiURaPK3bFWnOSSWqqZihD-QuyJ9zsQ@mail.gmail.com>
 <CAKKotZRszTNg8-_eB=km-ESdpwwt20JKr4V68s4WZQwnwHJPWw@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Thu, 8 Sep 2016 09:13:01 +0100
Message-ID: 
 <CA+OCxowfrCodR4aqQE1=-7hZ5+--8npcnFfgOdyhsSoVxXa+eA@mail.gmail.com>
Subject: Re: PATCH: Adding more confirmations in query tool (pgAdmin4)
To: Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: text/plain; charset=UTF-8
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

Thanks, applied.

On Thu, Sep 8, 2016 at 7:18 AM, Murtuza Zabuawala
<murtuza.zabuawala@enterprisedb.com> wrote:
> Hi Dave,
>
> Please find updated patch.
> Please review.
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Wed, Sep 7, 2016 at 7:30 PM, Dave Page <dpage@pgadmin.org> wrote:
>>
>> I think it's better to warn them as early as possible, as we do in
>> pgAdmin 3 (actually, there we just prompt them to save the changes,
>> but I think either is fine).
>>
>> On Wed, Sep 7, 2016 at 2:04 PM, Murtuza Zabuawala
>> <murtuza.zabuawala@enterprisedb.com> wrote:
>> > Sure I'll do it, But I thought like let user traverse through file
>> > manager
>> > (he may or may not select any file to load) and warn only if he/she try
>> > to
>> > load file.
>> >
>> >
>> > --
>> > Regards,
>> > Murtuza Zabuawala
>> > EnterpriseDB: http://www.enterprisedb.com
>> > The Enterprise PostgreSQL Company
>> >
>> > On Wed, Sep 7, 2016 at 6:30 PM, Dave Page <dpage@pgadmin.org> wrote:
>> >>
>> >> Hi
>> >>
>> >> On Wed, Sep 7, 2016 at 10:38 AM, Murtuza Zabuawala
>> >> <murtuza.zabuawala@enterprisedb.com> wrote:
>> >> > Hi,
>> >> >
>> >> > PFA patch to add more confirmations in query tool before taking any
>> >> > actions
>> >> > which might cause lose changes,
>> >> > - Clearing editor
>> >> > - Clearing history
>> >> > - Load file data
>> >> >  RM#1666
>> >> >
>> >> > Please review.
>> >>
>> >> Can you tweak it so that the confirmation is requested as soon as the
>> >> open file button is clicked, rather than when a file is selected
>> >> please? I think that's a little more 'normal' :-).
>> >>
>> >> Thanks!
>> >>
>> >> --
>> >> Dave Page
>> >> Blog: http://pgsnake.blogspot.com
>> >> Twitter: @pgsnake
>> >>
>> >> EnterpriseDB UK: http://www.enterprisedb.com
>> >> The Enterprise PostgreSQL Company
>> >
>> >
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers