Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d5VrK-0004oN-LV for pgadmin-hackers@arkaria.postgresql.org; Tue, 02 May 2017 11:20:46 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1d5VrK-0004qN-4p for pgadmin-hackers@arkaria.postgresql.org; Tue, 02 May 2017 11:20:46 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1d5VrJ-0004ma-AY for pgadmin-hackers@postgresql.org; Tue, 02 May 2017 11:20:45 +0000 Received: from mail-it0-x22f.google.com ([2607:f8b0:4001:c0b::22f]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1d5VrF-0001v0-Km for pgadmin-hackers@postgresql.org; Tue, 02 May 2017 11:20:44 +0000 Received: by mail-it0-x22f.google.com with SMTP id x188so8002524itb.0 for ; Tue, 02 May 2017 04:20:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=wwXtPnOIgOsnv9vBwvxNKP11Ui55iUJxrNutugT091Y=; b=jCWxwi/OtFpJ0ap6oehyV/OyOgcmZiA0lq1G7prMJ1DBlxDe7TVptNgJidaM7SxUui kgWdhTtrSe0EROoqICWP9bBOXouKlFPQ0ky4et0NOmy+DbA660aNBIMNu9CwpSqrM1pb b/MFJrd8AAuGJvx2KVmwJRwC+N+c51t5bCJ9eMd3m/Ao6ueQhefdpIn23jZHveZGnMsP U6yy6l1JZDjbQozWeKcsIsczZf1obVjB0DT4awBedI7PVVV+WKpbaGR06eLzHArznraD rT2FLy714oBO07Pv3ep0wtDgMIV39fTTHCqa6eq4CA0sCSIXmMg+F45W4NHDMgDawq2B F5OQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=wwXtPnOIgOsnv9vBwvxNKP11Ui55iUJxrNutugT091Y=; b=AlUDMBXOoAO1uQhYXtud1EmQ80H8csVhw8P78u1kKZbFJ4NfN/tdZUmlx5HCwkx+2Z mKWA3Ha7/CUwFbn6FxnL/DcQ3OFgdUgoO4ytCTIvvYNzNE929wuP0DlKK0rdifivMq5u snTXqQVuc0TTzZjUUqnKzALWj8zxGiKbrFzn8GX18AoSETWq3rJAMnYCBAM5FThHVTWn 5rP1D6QT8KtHfd7A3fkSI4MbOZmHzYRQEaDJc4maDkBguSKTY+QicHSXmR/8bnY6Vqgt TTwWHPlBfxlYA+ZvPva2qiHKkFPZjCidI6NesrtpcUjyeJ++iWbqFd/1IOpDWufYjQfE 41XQ== X-Gm-Message-State: AN3rC/7b2dNvoKzjtTQfKhe6eCR2AeIR9zb5G/9Kyvfhi8iT5Xbl7Wjo EmcEWfZrS8hroV08uvT8b9hSyBWxoQ== X-Received: by 10.36.194.7 with SMTP id i7mr11497686itg.28.1493724040905; Tue, 02 May 2017 04:20:40 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.174.167 with HTTP; Tue, 2 May 2017 04:20:40 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Tue, 2 May 2017 12:20:40 +0100 Message-ID: Subject: Re: [pgAdmin4][Patch]: Delete row server error not shown to GUI user To: Surinder Kumar Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=94eb2c088da0d9f165054e88ba05 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --94eb2c088da0d9f165054e88ba05 Content-Type: text/plain; charset=UTF-8 Thanks, patch applied. On Fri, Apr 28, 2017 at 11:48 AM, Surinder Kumar < surinder.kumar@enterprisedb.com> wrote: > Hi > > The variable list_of_rowid doesn't keep track of rows to be deleted. > If this list is empty simply return 0 since '_rowid' is being used to > highlight the row for which error is occurred in only insert and update > operation. > > Please find attached patch and review. > > Thanks, > Surinder Kumar > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --94eb2c088da0d9f165054e88ba05 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.
On Fri, Apr 28, 2017 at 11:48 AM, Surinder Kuma= r <surinder.kumar@enterprisedb.com> wrote:
=
Hi

The variable=C2=A0list_of_rowid=C2=A0doesn't keep track of r= ows to be deleted.
If this list is empty = simply return 0 since '_rowid' is being used to highlight the row f= or which error is occurred in only insert and update operation.

Please find a= ttached patch and review.

Thanks,
Surinder = Kumar


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-ha= ckers




--
--94eb2c088da0d9f165054e88ba05--