Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fhv5t-00028j-0u for pgadmin-hackers@arkaria.postgresql.org; Tue, 24 Jul 2018 11:03:05 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fhv5o-0000iq-PL for pgadmin-hackers@arkaria.postgresql.org; Tue, 24 Jul 2018 11:03:00 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fhv5o-0000ij-9N for pgadmin-hackers@lists.postgresql.org; Tue, 24 Jul 2018 11:03:00 +0000 Received: from mail-wm0-x241.google.com ([2a00:1450:400c:c09::241]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1fhv5f-0000n2-Ow for pgadmin-hackers@postgresql.org; Tue, 24 Jul 2018 11:02:58 +0000 Received: by mail-wm0-x241.google.com with SMTP id o11-v6so2081079wmh.2 for ; Tue, 24 Jul 2018 04:02:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=AvqOFM4bCh9+/0ligZM3Uk9Cm6kYK5lUCD0gtTG0gtQ=; b=geqh4syZlXhkRlMpsiKnk9CXfu/68dGe6lHFwl6bgOP/jTaebtGA8tilQuJnQT7iFd aMzxo4Ic10GHvY+hg6RbhDMz2+yE8jnNCVwzXFv2of8yjuAkPzoNvM2U3fs1t/Nc5OES 8fF0J6uxxWnJHvdqukvbY4JbQ6gvsP5ONIted8MPB8F8htSbXEJDw4+spDCW8RefbATI Zlq7fkwU7a1OqFxNjmcNFfw+S0p44npfGjqf0fj75QairRzYtYOy6IBl1jhxXoxb2RyR pjgqCF6cYxHVF9siWxZRBE+0Ab3/HhiBxfoWj6gVZhHj3dI+CfoAD/eBuXW/bEYL78FA npRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=AvqOFM4bCh9+/0ligZM3Uk9Cm6kYK5lUCD0gtTG0gtQ=; b=lecVkqPy8ZON1WH67dxcVNG8AkeAyPFtf5plOkwZhum2xFJIPp1SpExEhEOHVRgZQL 37lCSGO/+uO1fW36f/OTHRVvhiCb1JafMa3TSneRsV6kRM6FERzn9tMNjX3kmDu7pINq QHaFTDHvw2wJs3wFx0kOnf8iv4t2qPSDFpn8sns7w+R8XwLSODdc4C5ZJ7jzRyaWwdNP 1af+wVHJarDF8h8wFv3D1R2rlWXW0djy0sdH36dW7IHiuM3xhdGTknqaH4cIicLrHvLM oNgaOfASnnzDKNuDxxyytrYhd7/x8nd1bEm7RwdNad/tJ7gSgq2LXhUVjKs2B6FNEsnV G6nQ== X-Gm-Message-State: AOUpUlGpU83sYPKJJGRGEwEepjs+TtTUT0MR0O5BFNid/ZwpHnt6I4Vj FMLiUwdnINl8MOD4fimhqujsHdjP9TSxjldq1/68dA== X-Google-Smtp-Source: AAOMgpd/oZiHz1HHB1LGOSYBN/T+XoGe2GMpiOvV92svLJxoNnUj0cWOBkpIFB51yoLQ64qekHmfKYgR6SR57X9Ebls= X-Received: by 2002:a1c:1d58:: with SMTP id d85-v6mr1805063wmd.140.1532430170172; Tue, 24 Jul 2018 04:02:50 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a1c:89d1:0:0:0:0:0 with HTTP; Tue, 24 Jul 2018 04:02:49 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Tue, 24 Jul 2018 12:02:49 +0100 Message-ID: Subject: Re: [pgAdmin4][RM3294] User need to reset the layout to see the changed preferences parameters To: Aditya Toshniwal Cc: Akshay Joshi , pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000efb9f30571bcb3bd" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000efb9f30571bcb3bd Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi On Tue, Jul 24, 2018 at 11:39 AM, Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the second part of the changes for making preferences > realtime. The patch includes dashboard and debugger modules. > All my dashboard graphs now seem to be straight lines. I'm guessing there's a bug somewhere, as I've never seen one PG server sustain it's I/O levels so perfectly, let alone the three I tested with :-) > I would also request to create RMs for javascript test cases for dashboar= d > and debugger modules as currently there is no setup for the test cases of > these two modules. > Please do. As well as that I'd also like to see a Python test to ensure that the invocation SQL for various different types of function/procedure is correct. We've messed that up a few times over the years. Thanks. The changes are on the JS side and so patch does not have any test cases > included. > > Kindly review. > > > On Thu, Jul 5, 2018 at 4:09 PM, Dave Page wrote: > >> Thanks - patch applied! >> >> On Wed, Jul 4, 2018 at 10:19 AM, Aditya Toshniwal < >> aditya.toshniwal@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached is the updated patch for the RM. Change of the flags like auto >>> commit, explain->verbose, etc. will reflect in all other open sql edito= rs. >>> Kindly review. >>> >>> On Fri, Jun 29, 2018 at 10:39 PM, Aditya Toshniwal < >>> aditya.toshniwal@enterprisedb.com> wrote: >>> >>>> Hi Dave, >>>> >>>> On Fri, Jun 29, 2018 at 9:30 PM, Dave Page wrote: >>>> >>>>> Hi >>>>> >>>>> On Fri, Jun 29, 2018 at 3:14 PM, Aditya Toshniwal < >>>>> aditya.toshniwal@enterprisedb.com> wrote: >>>>> >>>>>> Hi Hackers, >>>>>> >>>>>> Attached is the updated patch. >>>>>> >>>>> >>>>> This seems to work for the most part, however I saw what seemed like >>>>> odd behaviour. If I have 2 query tool windows open; >>>>> >>>>> - Changing a preference from the Preferences dialogue updates both >>>>> query tools. >>>>> >>>>> - Changing a preference from a Query Tool updates the Preferences >>>>> dialogue. >>>>> >>>>> - Changing a preference from a Query Tool does *not* update the other >>>>> Query Tool. >>>>> >>>>> The last point seems odd to me, though it also kinda makes sense to >>>>> not have one query tool affect the other. The problem with that is th= at it >>>>> could get quite confusing when they get out of sync. I think it would= be >>>>> better for a change in one Query Tool to update the other(s). >>>>> >>>>> What do you think? Was this behaviour intentional? >>>>> >>>> >>>> =E2=80=8BNo this was not intentional. It should reflect in other query= tools as >>>> well because changing the flags like Auto Commit changes the preferenc= es >>>> config and is not local to a Query tool. I missed the fact that some >>>> preferences can be changed from other than preference dialog.=E2=80=8B >>>> >>>> =E2=80=8BWill send the updated patch with the fix.=E2=80=8B >>>> >>>>> >>>>> (FYI, in case this was a one-off bug, I was testing using "Auto >>>>> Commit?") >>>>> >>>>> >>>>>> >>>>>> On Fri, Jun 29, 2018 at 4:46 PM, Aditya Toshniwal < >>>>>> aditya.toshniwal@enterprisedb.com> wrote: >>>>>> >>>>>>> Hi Akshay, >>>>>>> >>>>>>> On Fri, Jun 29, 2018 at 3:42 PM, Akshay Joshi < >>>>>>> akshay.joshi@enterprisedb.com> wrote: >>>>>>> >>>>>>>> Hi Aditya >>>>>>>> >>>>>>>> I have applied your patch and run pgAdmin4. I have found following >>>>>>>> two issue in the browser: >>>>>>>> >>>>>>>> - Found error while open Preferences dialog. Refer >>>>>>>> Open_Preferences_Dialog.png >>>>>>>> >>>>>>>> =E2=80=8BThis error occurs even with the latest pull without chang= es.=E2=80=8B >>>>>>> >>>>>>> >>>>>>>> >>>>>>>> - Set the preferences setting "Open in new browser tab" to True >>>>>>>> and open the query tool. Refer "Open_In_New_Broswer.png". >>>>>>>> >>>>>>>> =E2=80=8BWill look into this.=E2=80=8B >>>>>>> >>>>>>> >>>>>>>> I haven't review the code. >>>>>>>> >>>>>>>> On Thu, Jun 28, 2018 at 8:04 PM, Aditya Toshniwal < >>>>>>>> aditya.toshniwal@enterprisedb.com> wrote: >>>>>>>> >>>>>>>>> Hi Hackers, >>>>>>>>> >>>>>>>>> Attached is the patch for making preferences realtime and applyin= g >>>>>>>>> without reseting the layout. Please note, the patch is only for o= ne module >>>>>>>>> - SQL Editor and is the first part for the RM. There are lot of c= hanges to >>>>>>>>> be done to cover all and hence sending in parts. This will not af= fect/break >>>>>>>>> existing code. Further patches will cover other modules. >>>>>>>>> >>>>>>>>> Highlights of this patch include: >>>>>>>>> - Changes will affect SQL Editors in Create dialog boxes, SQL tab >>>>>>>>> of the main screen, Query tool, History entries in the query tool= , Query >>>>>>>>> tool opened in New Tab/Window >>>>>>>>> - All the components of SQL editor will refer to single source of >>>>>>>>> preferences which is cached in the Browser object. All other redu= ndant ajax >>>>>>>>> get preference calls are removed. >>>>>>>>> - SQL editor will not refer template JS variables anymore, once >>>>>>>>> all the references are removed the template variables will also b= e removed. >>>>>>>>> - Code refactoring wherever possible. >>>>>>>>> - Covered JS test cases wherever possible. >>>>>>>>> >>>>>>>>> Request you to kindly review. >>>>>>>>> >>>>>>>>> -- >>>>>>>>> Thanks and Regards, >>>>>>>>> Aditya Toshniwal >>>>>>>>> Software Engineer | EnterpriseDB Software Solutions | Pune >>>>>>>>> "Don't Complain about Heat, Plant a tree" >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> *Akshay Joshi* >>>>>>>> >>>>>>>> *Sr. Software Architect * >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Thanks and Regards, >>>>>>> Aditya Toshniwal >>>>>>> Software Engineer | EnterpriseDB Software Solutions | Pune >>>>>>> "Don't Complain about Heat, Plant a tree" >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Thanks and Regards, >>>>>> Aditya Toshniwal >>>>>> Software Engineer | EnterpriseDB Software Solutions | Pune >>>>>> "Don't Complain about Heat, Plant a tree" >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Dave Page >>>>> Blog: http://pgsnake.blogspot.com >>>>> Twitter: @pgsnake >>>>> >>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>> >>>> >>>> >>>> -- >>>> Thanks and Regards, >>>> Aditya Toshniwal >>>> Software Engineer | EnterpriseDB Software Solutions | Pune >>>> "Don't Complain about Heat, Plant a tree" >>>> >>> >>> >>> >>> -- >>> Thanks and Regards, >>> Aditya Toshniwal >>> Software Engineer | EnterpriseDB Software Solutions | Pune >>> "Don't Complain about Heat, Plant a tree" >>> >> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB Software Solutions | Pune > "Don't Complain about Heat, Plant a tree" > --=20 Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --000000000000efb9f30571bcb3bd Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi

On Tue, Jul 24, 2018 at 11:39 AM, Aditya Toshniwal = <= aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the second part = of the changes for making preferences realtime. The patch includes dashboar= d and debugger modules.

All my = dashboard graphs now seem to be straight lines. I'm guessing there'= s a bug somewhere, as I've never seen one PG server sustain it's I/= O levels so perfectly, let alone the three I tested with :-)
=C2= =A0
I would also request to create RMs for javascri= pt test cases for dashboard and debugger modules as currently there is no s= etup for the test cases of these two modules.
=
Please do. As well as that I'd also like to see a Python= test to ensure that the invocation SQL for various different types of func= tion/procedure is correct. We've messed that up a few times over the ye= ars.
=C2=A0
Thanks.

The changes are on the JS side and so patch does not have any test case= s included.

Kindly review.


On Thu, J= ul 5, 2018 at 4:09 PM, Dave Page <dpage@pgadmin.org> wrote:<= br>
Thanks - patch applied!<= /div>

On We= d, Jul 4, 2018 at 10:19 AM, Aditya Toshniwal <aditya.tosh= niwal@enterprisedb.com> wrote:
Hi = Hackers,

Attached is the updated patch for = the RM. Change of the flags like auto commit, explain->verbose, etc. wil= l reflect in all other open sql editors.
Kindly review.

= On Fri, Jun 29, 2018 at 10:39 PM, Aditya Toshniwal <aditya= .toshniwal@enterprisedb.com> wrote:
Hi Dave,

<= span>On Fri, Jun 29, 2018 at 9:30 PM, Dave Page <dpage@pgadmin.org>= wrote:
Hi

On Fri, Jun 29= , 2018 at 3:14 PM, Aditya Toshniwal <aditya.toshniwal@ente= rprisedb.com> wrote:
Hi Hac= kers,=C2=A0

Attached is the updated patch.<= /div>

This seems to work for the most= part, however I saw what seemed like odd behaviour. If I have 2 query tool= windows open;

- Changing a preference from the Pr= eferences dialogue updates both query tools.

- Cha= nging a preference from a Query Tool updates the Preferences dialogue.

- Changing a preference from a Query Tool does *not* u= pdate the other Query Tool.

The last point seems o= dd to me, though it also kinda makes sense to not have one query tool affec= t the other. The problem with that is that it could get quite confusing whe= n they get out of sync. I think it would be better for a change in one Quer= y Tool to update the other(s).=C2=A0

What do you t= hink? Was this behaviour intentional?
<= /span>
=C2=A0
=E2=80=8BNo this was not intentional. It should reflect in other query t= ools as well because changing the flags like Auto Commit changes the prefer= ences config and is not local to a Query tool. I missed the fact that some = preferences can be changed from other than preference dialog.=E2=80=8B=C2=A0
=E2=80= =8BWill send the updated patch with the fix.=E2=80=8B

(FYI, in case this was a on= e-off bug, I was testing using "Auto Commit?")
=C2=A0

On Fri, Jun 29, 2018 at 4:46 PM, Aditya Toshniwal <<= a href=3D"mailto:aditya.toshniwal@enterprisedb.com" target=3D"_blank">adity= a.toshniwal@enterprisedb.com> wrote:
Hi Akshay,

On Fri, Jun 29, 2018 at 3:42 PM, Akshay Joshi <= ;akshay.= joshi@enterprisedb.com> wrote:
Hi Aditya=C2=A0

I have applied= your patch and run pgAdmin4. I have found following two issue in the brows= er:
  • Found error while open Preferences dialog. Refer Open= _Preferences_Dialog.png
=E2=80=8BThis error= occurs even with the latest pull without changes.=E2=80=8B
=C2=A0
  • Set th= e preferences setting "Open in new browser tab" to True and open = the query tool. Refer "Open_In_New_Broswer.png".
<= /div>
=E2=80=8BWill look into this.=E2=80=8B
=C2=A0
I haven't review the= code.

On Thu, Jun 28, 2018 at 8:04 PM, Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote= :
Hi Hackers,

Attache= d is the patch for making preferences realtime and applying without resetin= g the layout. Please note, the patch is only for one module - SQL Editor an= d is the first part for the RM. There are lot of changes to be done to cove= r all and hence sending in parts. This will not affect/break existing code.= Further patches will cover other modules.

= Highlights of this patch include:
- Changes will affect SQL Editors in Create dialog boxes, SQL tab= of the main screen, Query tool, History entries in the query tool, Query t= ool opened in New Tab/Window
- All the components of SQL editor will refer to single source of pref= erences which is cached in the Browser object. All other redundant ajax get= preference calls are removed.
-=C2=A0SQL editor will not refer template JS variables anymore, on= ce all the references are removed the template variables will also be remov= ed.
- Code refact= oring wherever possible.
- Covered JS test cases wherever possible.

Request you to kindly review.

--
Thanks and Regards,
Aditya Toshniwal
Software Engineer |=C2=A0Enterpris= eDB Software Solutions |=C2=A0Pune
"Don't = Complain about Heat, Plant a tree"



--
<= div>
Akshay Joshi
Sr. Software Architect

=

Phone: +91 20-3058-9517
Mo= bile: +91 976-788-8246



--
Thanks and Regards,
Aditya Toshniwal
Software Engineer |=C2=A0EnterpriseDB So= ftware Solutions |=C2=A0Pune
"Don't Complain about Heat, = Plant a tree"



--
Thanks a= nd Regards,
Aditya T= oshniwal
Software Engineer |=C2=A0EnterpriseDB Software Solutions |=C2=A0Pune
"Don't Complain about Heat, Plant a tree"<= /div>
=


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
<= /div>



--
Thanks and Regards,
= Aditya Toshniwal<= /div>
Software Engineer |= =C2=A0EnterpriseDB Software Solutions |=C2=A0Pune
"Don't = Complain about Heat, Plant a tree"



--
Thanks and Regards,
Aditya Toshniwal
Software Engineer |=C2=A0EnterpriseDB Software Solutions |=C2= =A0Pune
"Don't Complain about Heat, Plant a tree"



--
=
Dave Page
Blog: http://pgsnake.blogspot.com
Twitt= er: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise Postg= reSQL Company



--
=
Thanks and Regards,Aditya Toshniwal=
Software Engineer |= =C2=A0EnterpriseDB Software Solutions |=C2=A0Pune
"Don't = Complain about Heat, Plant a tree"



--
=
Dave Page=
Blog: http://= pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprised= b.com
The Enterprise PostgreSQL Company
--000000000000efb9f30571bcb3bd--