public inbox for [email protected]help / color / mirror / Atom feed
[pgAdmin][RM4925] Missing spinner from process watcher 4+ messages / 3 participants [nested] [flat]
* [pgAdmin][RM4925] Missing spinner from process watcher @ 2019-11-14 11:15 Aditya Toshniwal <[email protected]> 0 siblings, 1 reply; 4+ messages in thread From: Aditya Toshniwal @ 2019-11-14 11:15 UTC (permalink / raw) To: pgadmin-hackers Hi Hackers, Attached is the patch to show some text on process watcher till the initial logs are loaded. Adding a spinner was not possible due to the complex DOM structure of the logs window. Below is the screenshot: [image: Screenshot 2019-11-14 at 16.39.12.png] -- Thanks and Regards, Aditya Toshniwal Sr. Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" Attachments: [image/png] Screenshot 2019-11-14 at 16.39.12.png (140.3K, 3-Screenshot%202019-11-14%20at%2016.39.12.png) download | view image [application/octet-stream] RM4925.patch (1.3K, 4-RM4925.patch) download | inline diff: diff --git a/web/pgadmin/misc/bgprocess/static/js/bgprocess.js b/web/pgadmin/misc/bgprocess/static/js/bgprocess.js index 01301cc64..76ffa96d4 100644 --- a/web/pgadmin/misc/bgprocess/static/js/bgprocess.js +++ b/web/pgadmin/misc/bgprocess/static/js/bgprocess.js @@ -212,6 +212,11 @@ define('misc.bgprocess', [ }); } + if(self.logs_loading) { + self.logs_loading.remove(); + self.logs_loading = null; + } + if (self.stime) { self.curr_status = self.other_status_tpl({status_text:gettext('Started')}); @@ -414,6 +419,8 @@ define('misc.bgprocess', [ setTimeout(function() { self.logs[0].scrollTop = self.logs[0].scrollHeight; }); + self.logs_loading = $(`<li class="pg-bg-res-out loading-logs">${gettext('Loading process logs...')}</li>`); + self.logs.append(self.logs_loading); // set bgprocess detailed description $header.find('.bg-detailed-desc').html(self.detailed_desc); } @@ -602,6 +609,7 @@ define('misc.bgprocess', [ showTitle: true, isCloseable: true, isPrivate: true, + isLayoutMember: false, content: '<div class="bg-process-details">' + '<div class="bg-detailed-desc"></div>' + '<div class="bg-process-stats d-flex py-1">' + ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: [pgAdmin][RM4925] Missing spinner from process watcher @ 2019-11-14 11:29 Dave Page <[email protected]> parent: Aditya Toshniwal <[email protected]> 0 siblings, 1 reply; 4+ messages in thread From: Dave Page @ 2019-11-14 11:29 UTC (permalink / raw) To: Aditya Toshniwal <[email protected]>; +Cc: pgadmin-hackers Hi On Thu, Nov 14, 2019 at 11:16 AM Aditya Toshniwal < [email protected]> wrote: > Hi Hackers, > > Attached is the patch to show some text on process watcher till the > initial logs are loaded. Adding a spinner was not possible due to the > complex DOM structure of the logs window. Below is the screenshot: > A definite improvement - but can we not consistently display the logs in realtime? I've noticed in the past that sometimes that happens, but other times they're only displayed when the process completes. I haven't yet had a chance to figure out exactly what circumstances each happens in. > [image: Screenshot 2019-11-14 at 16.39.12.png] > > -- > Thanks and Regards, > Aditya Toshniwal > Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company Attachments: [image/png] Screenshot 2019-11-14 at 16.39.12.png (140.3K, 3-Screenshot%202019-11-14%20at%2016.39.12.png) download | view image ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: [pgAdmin][RM4925] Missing spinner from process watcher @ 2019-11-14 12:13 Aditya Toshniwal <[email protected]> parent: Dave Page <[email protected]> 0 siblings, 1 reply; 4+ messages in thread From: Aditya Toshniwal @ 2019-11-14 12:13 UTC (permalink / raw) To: Dave Page <[email protected]>; +Cc: pgadmin-hackers Hi Dave, On Thu, Nov 14, 2019 at 4:59 PM Dave Page <[email protected]> wrote: > Hi > > On Thu, Nov 14, 2019 at 11:16 AM Aditya Toshniwal < > [email protected]> wrote: > >> Hi Hackers, >> >> Attached is the patch to show some text on process watcher till the >> initial logs are loaded. Adding a spinner was not possible due to the >> complex DOM structure of the logs window. Below is the screenshot: >> > > A definite improvement - but can we not consistently display the logs in > realtime? I've noticed in the past that sometimes that happens, but other > times they're only displayed when the process completes. I haven't yet had > a chance to figure out exactly what circumstances each happens in. > It is updated in real time. This is what happens when you open the process watcher and the logs web service is accessed to get the initial logs. After that, the logs are pulled and appended at regular intervals. > > >> [image: Screenshot 2019-11-14 at 16.39.12.png] >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> Sr. Software Engineer | EnterpriseDB India | Pune >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Thanks and Regards, Aditya Toshniwal Sr. Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" Attachments: [image/png] Screenshot 2019-11-14 at 16.39.12.png (140.3K, 3-Screenshot%202019-11-14%20at%2016.39.12.png) download | view image ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: [pgAdmin][RM4925] Missing spinner from process watcher @ 2019-11-15 06:43 Akshay Joshi <[email protected]> parent: Aditya Toshniwal <[email protected]> 0 siblings, 0 replies; 4+ messages in thread From: Akshay Joshi @ 2019-11-15 06:43 UTC (permalink / raw) To: Aditya Toshniwal <[email protected]>; +Cc: Dave Page <[email protected]>; pgadmin-hackers Thanks, patch applied. On Thu, Nov 14, 2019 at 5:44 PM Aditya Toshniwal < [email protected]> wrote: > Hi Dave, > > On Thu, Nov 14, 2019 at 4:59 PM Dave Page <[email protected]> wrote: > >> Hi >> >> On Thu, Nov 14, 2019 at 11:16 AM Aditya Toshniwal < >> [email protected]> wrote: >> >>> Hi Hackers, >>> >>> Attached is the patch to show some text on process watcher till the >>> initial logs are loaded. Adding a spinner was not possible due to the >>> complex DOM structure of the logs window. Below is the screenshot: >>> >> >> A definite improvement - but can we not consistently display the logs in >> realtime? I've noticed in the past that sometimes that happens, but other >> times they're only displayed when the process completes. I haven't yet had >> a chance to figure out exactly what circumstances each happens in. >> > It is updated in real time. This is what happens when you open the process > watcher and the logs web service is accessed to get the initial logs. After > that, the logs are pulled and appended at regular intervals. > >> >> >>> [image: Screenshot 2019-11-14 at 16.39.12.png] >>> >>> -- >>> Thanks and Regards, >>> Aditya Toshniwal >>> Sr. Software Engineer | EnterpriseDB India | Pune >>> "Don't Complain about Heat, Plant a TREE" >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > -- > Thanks and Regards, > Aditya Toshniwal > Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* Attachments: [image/png] Screenshot 2019-11-14 at 16.39.12.png (140.3K, 3-Screenshot%202019-11-14%20at%2016.39.12.png) download | view image ^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2019-11-15 06:43 UTC | newest] Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2019-11-14 11:15 [pgAdmin][RM4925] Missing spinner from process watcher Aditya Toshniwal <[email protected]> 2019-11-14 11:29 ` Dave Page <[email protected]> 2019-11-14 12:13 ` Aditya Toshniwal <[email protected]> 2019-11-15 06:43 ` Akshay Joshi <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox