Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d80Zz-00028p-M0 for pgadmin-hackers@arkaria.postgresql.org; Tue, 09 May 2017 08:33:11 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1d80Zz-0002zn-72 for pgadmin-hackers@arkaria.postgresql.org; Tue, 09 May 2017 08:33:11 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1d80Zk-0002b6-A5 for pgadmin-hackers@postgresql.org; Tue, 09 May 2017 08:32:56 +0000 Received: from mail-it0-x22c.google.com ([2607:f8b0:4001:c0b::22c]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1d80Zc-0007ma-HI for pgadmin-hackers@postgresql.org; Tue, 09 May 2017 08:32:54 +0000 Received: by mail-it0-x22c.google.com with SMTP id o5so1035993ith.1 for ; Tue, 09 May 2017 01:32:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=8AL12uIwZPRungfjwfnZj44KYUB95NMQTAuLjM4avok=; b=b6a5vPmqtcmz88dbht5gGApmOEoH/seFV1G+Q5MQ84OVrhDn07bQHryOCeTJYOlE36 ahWnZLYRlVwbJ6Oq13TIHSC0+moVNwCIRvldq0aGp3UNLLe7eZFVhDiyHN3wyW6Fbloh jYz2KC1kFrSiVPh5AgZ15J2G1TOdLgQ+bwBOvN+YyDzzkNeNheaRbKx2RcslxeqyjUq9 QZ8eZCTWdyMu2H55eSK0twId06/Pjifh0PcWAW6PvovqPob8BDE3UCIFwZOzrFv9ygwN qrcnrKTJR+AaEJkvi6Z5SYFXSOaEYQLUl9vcy+4ysWHIKhWnDMuWdvZWM6r6GsnZlNj/ PD+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=8AL12uIwZPRungfjwfnZj44KYUB95NMQTAuLjM4avok=; b=L91TNVFe9eSIOnzaaV3ytnhREuPvmqrl3bYhp/HcHTtj9rnUNEXp6msyFsFBW+zSam OmnyCnQqugsR3rJAbTTL2ZQeNhFEz30jmFu6tS5Y6H67HPUVQP/UJP+E+AHNhSYssoRx ThxJ6MhrhuztC34DNcq4YANCh+H3BmLssoZZnS4/jPwT5rwcDq+UKfzaMYE03l1s+XLZ 6IHW9ouIsGCEb/YeXV0G07dxQCxdoog4azrPQ2KzCrVRHxeoQh7gaVgk1EWLm2fZAGFw 9TEJ9Dd7pT39nhTIYuiRRBEVPrv4Y4mrY8C5Xm9HBIuCKJtXzXZAiYouBUkk1Iuqawoi GNIw== X-Gm-Message-State: AODbwcD3xlcM3WVrgG8wh/rXEnYlwIMVpR1mDPCj1WmN4lfvaRizbbZi C7Vf7HQrhofmobugW+rVrUApR5Tg0pO5nwj4vXRH0/YZBmvRw0iMtw1cVOMgHcLF63tD77GQECx kX3AIUeP0GqmoMuRHvjGjct5gIKHZ9MyOawQoq9tIZCd9XzGUBxuqJy0Ig0FcCujL0ZRvCI+S X-Received: by 10.36.46.193 with SMTP id i184mr192223ita.51.1494318767023; Tue, 09 May 2017 01:32:47 -0700 (PDT) Received: from mail-it0-f42.google.com (mail-it0-f42.google.com. [209.85.214.42]) by smtp.gmail.com with ESMTPSA id c62sm48888itd.11.2017.05.09.01.32.46 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 May 2017 01:32:46 -0700 (PDT) Received: by mail-it0-f42.google.com with SMTP id e65so52506492ita.1 for ; Tue, 09 May 2017 01:32:46 -0700 (PDT) X-Received: by 10.36.17.197 with SMTP id 188mr214206itf.28.1494318765985; Tue, 09 May 2017 01:32:45 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.174.167 with HTTP; Tue, 9 May 2017 01:32:45 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Tue, 9 May 2017 09:32:45 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [pgAdmin4][runtime]: RM #2328 - Unable to launch query tool and debugger in new browser tab To: Neel Patel Cc: Akshay Joshi , pgadmin-hackers Content-Type: multipart/alternative; boundary="001a11437efe3a6b11054f1333a7" X-Pg-Spam-Score: -2.1 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a11437efe3a6b11054f1333a7 Content-Type: text/plain; charset="UTF-8" It's running CentOS 7.3, with packages from EPEL: [dpage@jenkins ~]$ rpm -qa |grep qt qt5-qtbase-common-5.6.1-10.el7.noarch qt5-qtbase-devel-5.6.1-10.el7.x86_64 qt-4.8.5-13.el7.x86_64 qt5-qtbase-5.6.1-10.el7.x86_64 qt5-qtxmlpatterns-5.6.1-10.el7.x86_64 qt5-qtwebchannel-5.6.1-10.el7.x86_64 qt5-qtwebkit-5.6.1-3.b889f46git.el7.x86_64 qt5-qtdeclarative-devel-5.6.1-10.el7.x86_64 qt-devel-4.8.5-13.el7.x86_64 qt-settings-19-23.5.el7.centos.noarch qt5-qtbase-gui-5.6.1-10.el7.x86_64 qt5-qtlocation-5.6.1-10.el7.x86_64 qt5-qtwebsockets-5.6.1-10.el7.x86_64 qt5-qtwebkit-devel-5.6.1-3.b889f46git.el7.x86_64 qtwebkit-2.3.4-6.el7.x86_64 qt3-3.3.8b-51.el7.x86_64 qt5-qtdeclarative-5.6.1-10.el7.x86_64 qt5-rpm-macros-5.6.1-10.el7.noarch qtwebkit-devel-2.3.4-6.el7.x86_64 qt-x11-4.8.5-13.el7.x86_64 qt5-qtsensors-5.6.1-10.el7.x86_64 On Tue, May 9, 2017 at 9:28 AM, Neel Patel wrote: > Hi Dave, > > Yes, It looks like compilation fails on Qt4. We will fix this issue but > which version of Qt4 we are using in Jenkins ? > > Thanks, > Neel Patel > > On Tue, May 9, 2017 at 1:56 PM, Dave Page > wrote: > >> >> >> On Tue, May 9, 2017 at 9:18 AM, Akshay Joshi < >> akshay.joshi@enterprisedb.com> wrote: >> >>> Hi >>> >>> On Tue, May 9, 2017 at 1:42 PM, Dave Page >>> wrote: >>> >>>> This appears to have made Jenkins get all angry and red :-( >>>> >>>> https://jenkins.pgadmin.org/ >>>> >>> >>> We(Neel and I) have tested it and working fine. >>> >> >> It clearly doesn't compile on QT4. Please review the Jenkins logs. >> >> >>> >>>> >>>> On Tue, May 9, 2017 at 8:39 AM, Akshay Joshi < >>>> akshay.joshi@enterprisedb.com> wrote: >>>> >>>>> Thanks patch applied. >>>>> >>>>> On Mon, May 8, 2017 at 3:21 PM, Dave Page wrote: >>>>> >>>>>> Akshay, could you review this please? >>>>>> >>>>>> Thanks. >>>>>> >>>>>> On Fri, May 5, 2017 at 11:53 AM, Neel Patel < >>>>>> neel.patel@enterprisedb.com> wrote: >>>>>> >>>>>>> Hi, >>>>>>> >>>>>>> Please find attached patch file with the fix of RM #2328 - >>>>>>> [Runtime]: Unable to launch query tool and debugger in new browser tab. >>>>>>> >>>>>>> I have used Qt 5.8 with webkit mentioned in below URL. >>>>>>> >>>>>>> https://github.com/annulen/webkit/releases >>>>>>> >>>>>>> >>>>>>> As there was a bug in QWebKit regarding "unload" event. We have >>>>>>> raised and also they have provided patch file to fix this issue. I have >>>>>>> applied the patch in linux and compile the webkit and tested the attached >>>>>>> patch with compiled webkit which is now working fine. >>>>>>> >>>>>>> Below is the link for reference regarding unload issue. They have >>>>>>> provided test webkit release for Mac in below URL but for other platform we >>>>>>> need to apply the patch and compile the webkit until they provide >>>>>>> webkit-releases for all platforms. >>>>>>> >>>>>>> https://github.com/annulen/webkit/issues/519 >>>>>>> >>>>>>> Do review it and let me know in case of any issue. >>>>>>> >>>>>>> Thanks, >>>>>>> Neel Patel >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.or >>>>>>> g) >>>>>>> To make changes to your subscription: >>>>>>> http://www.postgresql.org/mailpref/pgadmin-hackers >>>>>>> >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Dave Page >>>>>> Blog: http://pgsnake.blogspot.com >>>>>> Twitter: @pgsnake >>>>>> >>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>> The Enterprise PostgreSQL Company >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> *Akshay Joshi* >>>>> *Principal Software Engineer * >>>>> >>>>> >>>>> >>>>> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 >>>>> 976-788-8246 <+91%2097678%2088246>* >>>>> >>>> >>>> >>>> >>>> -- >>>> Dave Page >>>> VP, Chief Architect, Tools & Installers >>>> EnterpriseDB: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>>> Blog: http://pgsnake.blogspot.com >>>> Twitter: @pgsnake >>>> >>> >>> >>> >>> -- >>> *Akshay Joshi* >>> *Principal Software Engineer * >>> >>> >>> >>> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 >>> 976-788-8246 <+91%2097678%2088246>* >>> >> >> >> >> -- >> Dave Page >> VP, Chief Architect, Tools & Installers >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> > > -- Dave Page VP, Chief Architect, Tools & Installers EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company Blog: http://pgsnake.blogspot.com Twitter: @pgsnake --001a11437efe3a6b11054f1333a7 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
It's running CentOS 7.3, with packages from EPEL:
=
[dpage@jenkins ~]$ rpm -qa |grep qt
qt5-qtbas= e-common-5.6.1-10.el7.noarch
qt5-qtbase-devel-5.6.1-10.el7.x86_64=
qt-4.8.5-13.el7.x86_64
qt5-qtbase-5.6.1-10.el7.x86_64<= /div>
qt5-qtxmlpatterns-5.6.1-10.el7.x86_64
qt5-qtwebchannel-= 5.6.1-10.el7.x86_64
qt5-qtwebkit-5.6.1-3.b889f46git.el7.x86_64
qt5-qtdeclarative-devel-5.6.1-10.el7.x86_64
qt-devel-4.8.= 5-13.el7.x86_64
qt-settings-19-23.5.el7.centos.noarch
q= t5-qtbase-gui-5.6.1-10.el7.x86_64
qt5-qtlocation-5.6.1-10.el7.x86= _64
qt5-qtwebsockets-5.6.1-10.el7.x86_64
qt5-qtwebkit-d= evel-5.6.1-3.b889f46git.el7.x86_64
qtwebkit-2.3.4-6.el7.x86_64
qt3-3.3.8b-51.el7.x86_64
qt5-qtdeclarative-5.6.1-10.el7.x= 86_64
qt5-rpm-macros-5.6.1-10.el7.noarch
qtwebkit-devel= -2.3.4-6.el7.x86_64
qt-x11-4.8.5-13.el7.x86_64
qt5-qtse= nsors-5.6.1-10.el7.x86_64

<= div class=3D"gmail_quote">On Tue, May 9, 2017 at 9:28 AM, Neel Patel <neel.patel@enterprisedb.com> wrote:
Hi Dave,

Yes, It looks l= ike compilation fails on Qt4. We will fix this issue but which version of Q= t4 we are using in Jenkins ?

Thanks,
Nee= l Patel

On Tue, May 9, 2017 at 1:56 PM, D= ave Page <dave.page@enterprisedb.com> wrote:


On Tue, May 9, 2017 at 9:18 AM, Aksha= y Joshi <akshay.joshi@enterprisedb.com> wro= te:
Hi

On Tue, May 9, 2017 at 1:42 P= M, Dave Page <dave.page@enterprisedb.com> wrote:
This appears to have made Jenkins get al= l angry and red :-(


=C2=A0 =C2=A0We(Neel and I) have tested it = and working fine.=C2=A0=C2=A0

=
It clearly doesn't compile on QT4. Please review the = Jenkins logs.
=C2=A0<= /div>


On Tue, May 9, 2017 at 8:39 AM, Akshay Joshi <akshay.joshi= @enterprisedb.com> wrote:
Thanks patch applied.

On Mon, May 8, 2= 017 at 3:21 PM, Dave Page <dpage@pgadmin.org> wrote:
Akshay, could you review this please?
Thanks.

= On Fri, May 5, 2017 at 11:53 AM, Neel Patel <neel.patel@enterp= risedb.com> wrote:
Hi,
Please find attached patch file with the fix of RM #2328 - = [Runtime]: Unable to launch query tool and debugger in new browser tab.

I have used Qt 5.8 wi= th webkit mentioned in below URL.

=


As there was a b= ug in QWebKit regarding "unload" event. We have raised and also t= hey have provided patch file to fix this issue. I have applied the patch in= linux and compile the webkit and tested the attached patch with compiled w= ebkit which is now working fine.

<= /div>
Below is the link for reference regard= ing unload issue. They have provided test webkit release for Mac in below U= RL but for other platform we need to apply the patch and compile the webkit= until they provide webkit-releases for all platforms.


Do review it and let= me know in case of any issue.
<= br>
Thanks,
Neel Patel


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-ha= ckers



<= br>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter= : @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise Postgre= SQL Company



--
Akshay Joshi
Principal Software Engineer=C2=A0

<= div>




--
Dave= Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprised= b.com
The Enterprise PostgreSQL Company

Blog: http:/= /pgsnake.blogspot.com
Twitter: @pgsnake



--
Akshay Joshi
Principal Software Engineer=C2=A0

=
=


--
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB= : http://www.ente= rprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.= com
Twitter: @pgsnake




--
=
Dave Page=
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com=
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Tw= itter: @pgsnake
--001a11437efe3a6b11054f1333a7--