Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hgSRE-0005LL-22 for pgadmin-hackers@arkaria.postgresql.org; Thu, 27 Jun 2019 11:19:36 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hgSRC-00058O-QK for pgadmin-hackers@arkaria.postgresql.org; Thu, 27 Jun 2019 11:19:34 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hgSRC-00058D-Ba for pgadmin-hackers@lists.postgresql.org; Thu, 27 Jun 2019 11:19:34 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hgSR9-0004H1-CP for pgadmin-hackers@postgresql.org; Thu, 27 Jun 2019 11:19:33 +0000 Received: by mail-wm1-x341.google.com with SMTP id 207so5336871wma.1 for ; Thu, 27 Jun 2019 04:19:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BXuezwd2NdgQEQOeudfe8UN0csxqcmRi6zFZtYKWIw0=; b=aZdf+sgighJv1ta7y5kOn+5cHk+hTfWwtOdRjoTJ02IxFXPcdkuu7nH2bLH5sRB0Im qHLi/mMn86ZsZguFEdSUrZW/uwq3xNOWxeODYtWuNwqFSV4d+X6A5XXH4scU94Tgi5Zs JKRNvVynBL1RNS2STuYpazF9Ov/KlFwmoTjIOzTeddifRiH9iXRT5Mgh2VUNIjUDAWMw wfYgSJDHua8vGe3/MK7/29fauuxna9lx/1iOZM/T8qGDVXwN0SNc5tMVdKqg0lyrSPck vY/C0tpjZZvUb2vI86Li+x+sw0a1EBH3V5MkJpk2aTH+3ibMQ4hAkVm4LjIDdAj9Y1S7 p4Tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BXuezwd2NdgQEQOeudfe8UN0csxqcmRi6zFZtYKWIw0=; b=V3YIa5+BgKJDK+qS43TYA0jOtncXhB5MALenDqasOGmMsHcBnxeqDcDOgA2n3esaTt B+xalSt1zTKYdoQhGF8L9Zel/EQFDBwVXaYI/k/jxyf/rJRXUJf5bdOkCSpIkxeshcng 8L6R9ePVv1RG8E4AjW70NfaPXM7b+XsRL7uhXr2KLO6ACbL9cJjHux+BqT5QsFuNL/gq C05Fwsk53KPpzhBwj4xLeGhiKC87OKzHA1H/2knTA1mlPO5M+sHDr2LzmzjWdTQzWdYh UlF0q1itgQJSqSAPyyjCpI9oLOgSTQUjQzFVp7TCat+vXtOK909vXJSpFJNCh97r9UhY dIMA== X-Gm-Message-State: APjAAAX6qr3IO2zuz83hOcZM1sUha4WhOWkYqhWU2q0XLMUf3Fc5fjqA R9kT/imJZu5swJtKFgUP2cnjVagKimgutmkswlPhuw== X-Google-Smtp-Source: APXvYqzvQ2J7SushtwIHI/FT2IMzqD/FPJGaCDUwlIdJpz7nbqtMPF5z+H0RHOyfzsg0mQkaaBsVQB9dXc5Ry6ODSCg= X-Received: by 2002:a1c:f018:: with SMTP id a24mr2791260wmb.66.1561634369542; Thu, 27 Jun 2019 04:19:29 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dave Page Date: Thu, 27 Jun 2019 07:19:17 -0400 Message-ID: Subject: Re: [pgAdmin][RM4335] Add EXPLAIN option SETTINGS and SUMMARY To: Aditya Toshniwal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000ddbb1e058c4c551a" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000ddbb1e058c4c551a Content-Type: text/plain; charset="UTF-8" Hi On Thu, Jun 27, 2019 at 12:32 AM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi, > > On Wed, Jun 26, 2019 at 8:22 PM Dave Page wrote: > >> Hi >> >> Something isn't working correctly - I turned on the summary option, and >> this is the query that was run when I hit the EXPLAIN button: >> >> EXPLAIN (FORMAT JSON,ANALYZE False,VERBOSE False,COSTS False,TIMING >> False,SUMMARY False,BUFFERS False) select * from pg_tables >> > >> Aside from the formatting (s/True/true, s/False/false, missing spaces >> etc), shouldn't it say SUMMARY true? I've cleared the browser and bundle >> caches, rebundled etc. >> > I think I misunderstood the documents - > https://www.postgresql.org/docs/12/sql-explain.html. Few of the > parameters are applicable only to EXPLAIN ANALYSE and not to EXPLAIN. Will > make the changes, along with formatting to existing codes as well. > I'm not sure that explains why the summary option is set to *false* for an EXPLAIN action, but anyway, please make sure it works :-) > >> Shouldn't there also be documentation updates? >> > Yeah. (I always miss that :/) > >> >> On Wed, Jun 26, 2019 at 7:59 AM Aditya Toshniwal < >> aditya.toshniwal@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached is the patch to add support for SETTINGS(v12+) and >>> SUMMARY(v10+) explain options. These options will be visible only if >>> version is supported. >>> >>> I have also created and fixed RM4395. The explain options changed on one >>> query tool should not change explain options on other query tools or >>> preferences. The initial values will be taken from preferences are usual. >>> >>> Kindly review. >>> >>> -- >>> Thanks and Regards, >>> Aditya Toshniwal >>> Software Engineer | EnterpriseDB India | Pune >>> "Don't Complain about Heat, Plant a TREE" >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --000000000000ddbb1e058c4c551a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi

On Thu, Jun 27, 2019 at 12:32 AM Aditya= Toshniwal <aditya.= toshniwal@enterprisedb.com> wrote:
Hi,

On Wed, Jun 26, 2019 at 8:22 PM Dav= e Page <dpage@pga= dmin.org> wrote:
Hi

Something isn't working = correctly - I turned on the summary option, and this is the query that was = run when I hit the EXPLAIN button:

EXPLAIN (FORMAT= JSON,ANALYZE False,VERBOSE False,COSTS False,TIMING False,SUMMARY False,BU= FFERS False) select * from pg_tables

Aside from the formatting (s/True/true, s/False/false, missing spa= ces etc), shouldn't it say SUMMARY true? I've cleared the browser a= nd bundle caches, rebundled etc.
I think I misun= derstood the documents -=C2=A0https://www.postgresql.org/docs= /12/sql-explain.html. Few of the parameters are applicable only to EXPLAIN = ANALYSE and not to EXPLAIN. Will make the changes, along with formatting to= existing codes as well.=C2=A0
I'm not sure that explains why the summary option is set t= o *false* for an EXPLAIN action, but anyway, please make sure it works :-)<= /div>
=C2=A0

Shouldn't there al= so be documentation updates?
Yeah. (I always miss = that :/)=C2=A0
On W= ed, Jun 26, 2019 at 7:59 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.= com> wrote:
Hi Hacker= s,

Attached is the p= atch to add support for SETTINGS(v12+) and SUMMARY(v10+) explain options. T= hese options will be visible only if version is supported.

I have also created and fixed RM4395. The explain options = changed on one query tool should not change explain options on other query = tools or preferences. The initial values will be taken from preferences are= usual.

Kindly review.

= --
Thanks and Regards,
Aditya Toshniwal
Software Engineer |=C2=A0EnterpriseD= B India |=C2=A0Pune
"Don't Complain about Heat, Plant a TREE"
=


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

Enterpri= seDB UK: http://w= ww.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer |=C2=A0EnterpriseDB I= ndia |=C2=A0Pune
"Don't Complain about Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @p= gsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL = Company
--000000000000ddbb1e058c4c551a--