MIME-Version: 1.0
In-Reply-To: 
 <CACCA4P3dHgkPte+NYf3yMCXGm=zHo5aEaK5CaSe2n1Hmz2Zg2w@mail.gmail.com>
References: 
 <CACCA4P0v_8JGTgqwmeL74Bfm1g7UmtCzw79_nD6g4BNhRPvjyg@mail.gmail.com>
 <CACCA4P3dHgkPte+NYf3yMCXGm=zHo5aEaK5CaSe2n1Hmz2Zg2w@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Mon, 25 Jul 2016 12:48:24 +0100
Message-ID: 
 <CA+OCxowkVgcJ=GORAUR9UP2L9xtwq1Yib_kpeDU2ErwEU7ArtA@mail.gmail.com>
Subject: Re: [pgAdmin4][patch]: Fix for RM 1320
To: Neel Patel <neel.patel@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: text/plain; charset=UTF-8
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

Thanks - applied.

On Mon, Jul 25, 2016 at 7:01 AM, Neel Patel <neel.patel@enterprisedb.com> wrote:
> Adding more details.
>
> Root cause:-
>
> When user change schema of already created fdw extension then while creating
> the new fdw we should append the <schema_name>.<fdw_handler_name>.
> Previously we added only <fdw_handler_name> so while executing the query it
> will not be able to find fdw handler name without schema name.
>
> e.g. If user changed the fdw handler 'postgres_fdw_handler' under schema
> 'test' then we should display the handler  name under fdw as "test.
> postgres_fdw_handler".
>
> Solution:-
>
> With this patch, we have added <schema_name>.<fdw_handler_name> so while
> creating or updating the fdw, proper sql will be generated.
>
> Thanks,
> Neel Patel
>
>
> On Mon, Jul 25, 2016 at 11:02 AM, Neel Patel <neel.patel@enterprisedb.com>
> wrote:
>>
>> Hi,
>>
>> Please find attached patch file for the fix of RM- 1320.
>>
>> RM-1320 - Unable to create foreign data wrapper when user change the
>> schema of extension 'postgres_fdw_handler'.
>>
>> Thanks,
>> Neel Patel
>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers