MIME-Version: 1.0
In-Reply-To: 
 <CAFiP3vxONZz5YOOMGJMwF_yRdKCXNfz=rONniA3EpO23AJsrxQ@mail.gmail.com>
References: 
 <CAFiP3vyQX28ZAbMB4cSnU3-o_s1O1VP6hdQjz6uq=oRFH-9scg@mail.gmail.com>
 <CA+OCxowcG2dX4XS-aTkbOm8GF=XqiV343aYz5c6qTUq4UYF4aQ@mail.gmail.com>
 <CAFiP3vyNABWTtNK+rtOByWOyeotHQFT7Kv_1jnrKORGTFBobaQ@mail.gmail.com>
 <CA+OCxoy=En44LrBR_or1pjBH4kQ8aFjncLfnLZMF3TCn3oWwyw@mail.gmail.com>
 <CAFiP3vxONZz5YOOMGJMwF_yRdKCXNfz=rONniA3EpO23AJsrxQ@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Wed, 3 Aug 2016 15:39:23 +0100
Message-ID: 
 <CA+OCxown3xx7=TE7gMbn8hwqDC1W+iju-_1Wr9UaFS0BqjLr=A@mail.gmail.com>
Subject: Re: Patch for RM1500 other issues [pgAdmin4]
To: Harshal Dhumal <harshal.dhumal@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: text/plain; charset=UTF-8
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

Thanks - applied.

On Wed, Aug 3, 2016 at 2:39 PM, Harshal Dhumal
<harshal.dhumal@enterprisedb.com> wrote:
> Hi Dave,
>
> Please find attached updated patch. I missed to change table __init__.py
> file that why you got the error sorry for that. Also patch has changes for
> both RM1500 and simplejson issue as both require changes in same file.
> Please discard old patch of RM1500 and simplejson.
>
>
>
>
> --
> Harshal Dhumal
> Software Engineer
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Wed, Aug 3, 2016 at 6:30 PM, Dave Page <dpage@pgadmin.org> wrote:
>>
>> Hi
>>
>> On Wed, Aug 3, 2016 at 12:43 PM, Harshal Dhumal
>> <harshal.dhumal@enterprisedb.com> wrote:
>> > Hi Dave,
>> >
>> > This because on python 2.X simplejson throws KeyError instead of
>> > TypeError
>> > if any error occurs while loading json data from given object. Now I
>> > have
>> > handled that exception as well in attached patch.
>> >
>> > I'm sending this as separate patch instead part of RM1500.
>>
>> I still see the same error, with both patches applied. I've restarted
>> the app server and cleared the browser cache and reloaded etc.
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers