Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fa0IY-0007X4-BL for pgadmin-hackers@arkaria.postgresql.org; Mon, 02 Jul 2018 14:59:26 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fa0IV-00073A-W2 for pgadmin-hackers@arkaria.postgresql.org; Mon, 02 Jul 2018 14:59:23 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fa0IV-000733-R9 for pgadmin-hackers@lists.postgresql.org; Mon, 02 Jul 2018 14:59:23 +0000 Received: from mail-wm0-x22d.google.com ([2a00:1450:400c:c09::22d]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1fa0IR-0006K8-QC for pgadmin-hackers@postgresql.org; Mon, 02 Jul 2018 14:59:22 +0000 Received: by mail-wm0-x22d.google.com with SMTP id v25-v6so8426603wmc.0 for ; Mon, 02 Jul 2018 07:59:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=y7/fva4D+vcXpli1gxK4RFGy24oCB8wc6tEZqm1UE14=; b=Y3zKB95yb80pFfE09JcnAl9fCYL/qtzReAg2SinqLHrjW/AqkVso6sPHFuEd3D4mJ5 N3/uVizAr9MrEhBMPKQa+21a5dk3FVuY/3W+DL89XBTtSYn2Q7C76GAtJhSxWDoyTLAs JZmsbW3mgfrBlKUm+NNcIjtvSKpQqaWoPVnrKN27ufIhSJZ12Lf6qRWpHXb1cxFst2IQ x9q3NyRaQYOzxMh/VPgp2kXqQ00ELsQWKbDxlSOP4dQhLCb4YgDrpDoOgbt4GLwhs9So KjuOWtgPUGsn+zrD8THwC9YPz7Xdi+ZgGs1v3eT4ULy+FZMk9yVi9bvQyEYYYsheLAAL gPFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=y7/fva4D+vcXpli1gxK4RFGy24oCB8wc6tEZqm1UE14=; b=ukDFZe0y8PACslKsG9ua0dMI/bRaSLqdwRoGGe+gr7O3I44ySU7Gar7TJ0zl+arsI9 G7vvB67kaD7B66kEmu3IA64G9VURSJ6nOQSdodSS+nbCFfDz2F8YD/UYhX4syyJ3lKhG xftQpdDqYuJ2HW6l8zDfm3FkfbdfXFZML9fdxYmPQAZiXL7IvbuDEFukZad2lLdlQXnd eBozc7pvL8P9Aj+EZMctBEzIaO7ja8UQ8YQSUx7a9Ns3sFrSr1Qugu8Cv0l7Fufpcjy7 TSrpQYqpi0ufEgUyiMYaqn2SYswkpWUBpGFVHfHtgiAip20vb+SZb0AvGQV6VMiHFmCQ KzTA== X-Gm-Message-State: APt69E1zvGGFdd7SCYOPWsmV957QXtbk1AKoyn5bi/5tRT577YE3TXFe 7x0RC2r3nFzhx5nemQFvH/AJxk2gidFMbwUmsOgtmQ== X-Google-Smtp-Source: AAOMgpepq2/EE/Ljparmm5oSAVKy3JPfYSboFfKlqAfFsOSAoSbGZZyeuB4mfpUc9/nmXwBLrbXURNDj4BwUIWLPaaE= X-Received: by 2002:a1c:b590:: with SMTP id e138-v6mr8816804wmf.154.1530543558234; Mon, 02 Jul 2018 07:59:18 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a1c:2907:0:0:0:0:0 with HTTP; Mon, 2 Jul 2018 07:59:17 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Mon, 2 Jul 2018 15:59:17 +0100 Message-ID: Subject: Re: [pgAdmin4][RM3371] Ping endpoint still send a pg4a_session cookie To: Aditya Toshniwal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000001a29db05700571b9" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000001a29db05700571b9 Content-Type: text/plain; charset="UTF-8" Hi I'm not in a position to test at the moment, but can you confirm this will work if the root of pgAdmin is at (for example) /pgadmin? So the actual root is /pgadmin/misc/ping ? On Mon, Jul 2, 2018 at 1:35 PM, Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch for fixing RM3371 where /misc/ping service generate > session file for each call and so cannot be used frequently. > The patch is to skip session file generation and session caching for the > URLs provided in SESSION_SKIP_PATH list config parameter. > pg4a_session_cookie value will still be generated but nothing will be > stored at the backend. > Also, I have separated the garbage collection code in current ping service > to a new url /misc/cleanup. /misc/ping will be purely for is alive check. > > Request you to kindly review. > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB Software Solutions | Pune > "Don't Complain about Heat, Plant a tree" > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --0000000000001a29db05700571b9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi

I'm not in a position to test at= the moment, but can you confirm this will work if the root of pgAdmin is a= t (for example) /pgadmin? So the actual root is /pgadmin/misc/ping ?
<= /div>

On Mon, Jul = 2, 2018 at 1:35 PM, Aditya Toshniwal <aditya.toshniwal@ent= erprisedb.com> wrote:
Hi Hackers,

Attached is the patch for fixing RM3371 where /misc= /ping service generate session file for each call and so cannot be used fre= quently.
The patch is to skip session file generation and session caching f= or the URLs provided in SESSION_SKIP_PATH list config parameter. pg4a_sessi= on_cookie value will still be generated but nothing will be stored at the b= ackend.
Also, I have separated the garbage collection code in current ping = service to a new url /misc/cleanup. /misc/ping will be purely for is alive = check.

Request you to kindly review.

--
Thanks and Regards,
Aditya Toshniwal
Software Engineer |=C2=A0EnterpriseDB Software Sol= utions |=C2=A0Pune
"Don't Complain about Heat, Plant a tr= ee"



--
Dave Page
Blog: = http://pgsnake.bl= ogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com<= br>The Enterprise PostgreSQL Company
--0000000000001a29db05700571b9--