Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bxc1r-0003mN-1E for pgadmin-hackers@arkaria.postgresql.org; Fri, 21 Oct 2016 15:46:43 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bxc1q-0006CQ-6H for pgadmin-hackers@arkaria.postgresql.org; Fri, 21 Oct 2016 15:46:42 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bxc1p-0006CJ-Nr for pgadmin-hackers@postgresql.org; Fri, 21 Oct 2016 15:46:41 +0000 Received: from mail-yb0-x22a.google.com ([2607:f8b0:4002:c09::22a]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bxc1i-0002QK-Bh for pgadmin-hackers@postgresql.org; Fri, 21 Oct 2016 15:46:41 +0000 Received: by mail-yb0-x22a.google.com with SMTP id 184so43797818yby.2 for ; Fri, 21 Oct 2016 08:46:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=aZV9GGtwq6zTcZac3X44BlJ38aDnX6hIJlDYp7DVC0E=; b=SzyV0F9tSTDFA/i9x4gy2/E49F7DQ/KZ6Q72zgB5JFGBjTYBur5i+PybEtmwKY+Y1P YLuj0OR+pukfuEMfg/fgLoLUj5igxs4/94qUQ67OTe6hVSnsO8SUywPT8wLjMUgV5BJ3 rOXBiRIhVCWSLGXJml4AgGycU+Qz4tMhXdfs39PENDyFf6RRbUqMqOoYz2lluzshc9uG o23PXWhgQalcMt42Ey4HM65imu8Mr3HObnQ6LjOc9yX7+3a7qcgJdhB2eINzjXf7pu3p FAySEFeYuLfX3VzzVIYmVDcvupp27TkW6VRtUFHiAzgpTzNUWs9lJcCRFtgBFdId3/3i V/FQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=aZV9GGtwq6zTcZac3X44BlJ38aDnX6hIJlDYp7DVC0E=; b=RRk/7/FkvsZu8au+nJs6hF2Q0jWBJU7Mc6aQIyIoQedaY2Zyl/cbnWiYmjzxg2bG6v /Jib9uWE2H74YyNSgmCNy1mFW/bw6c5pCn/WaW166w7/Ex7nYVUp5MqUT601I7JFgihY idRDo888rZ68aUx1QQq5Qe3yaObYHGjAm2HS/WMd7j1a5GhyOK7U/U8WGiCK5d5YJrYt RZEbO3zHlO4SdlpeDeSs8YUi1W1MePIS0t/Gzra+nF7hGH7+N3q0Jt5/aryF3VjXlQY4 Fh/RAzI5mljYT2Xwv93HVFBiwmIFj6JbiRbBncxsf2wj6kg/GiDRP+TDHUe3r9QptEpc F43A== X-Gm-Message-State: ABUngvdp6Opu0GRJ2YOHOQ40Ex4O5h8vCVVmBKU8N4UbrOwXGt3EWwgdAMOH5PIKMQ7rINFc0mIiqGIryJzkxg== X-Received: by 10.107.12.206 with SMTP id 75mr1635662iom.208.1477064792327; Fri, 21 Oct 2016 08:46:32 -0700 (PDT) MIME-Version: 1.0 Received: by 10.64.82.130 with HTTP; Fri, 21 Oct 2016 08:46:31 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Fri, 21 Oct 2016 16:46:31 +0100 Message-ID: Subject: Re: [pgAdmin4][Patch]: RM1840 - cannot create gist index due to enforced ASC, DESC options in generated SQL To: Surinder Kumar Cc: pgadmin-hackers Content-Type: text/plain; charset=UTF-8 X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org On Fri, Oct 21, 2016 at 4:42 PM, Surinder Kumar wrote: > On Fri, Oct 21, 2016 at 8:52 PM, Dave Page wrote: >> >> Hi >> >> On Fri, Oct 21, 2016 at 4:16 PM, Surinder Kumar >> wrote: >> > Hi >> > >> > This fix is for exclusion constraint. >> > The options like "order" and "nulls" must be conditional. i.e. include >> > only >> > when access method type is other than "gist". >> >> When creating an index, the asc/desc options are disabled if gist/gin >> used. I think they also should be here. >> >> Also, what about gin indexes in this case? > > As per documentation, > The access method must support amgettuple (see Chapter 52); at present this > means GIN cannot be used OK, but this patch (unlike the last one) only seems to check for gist. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers