Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1azl28-0005Lc-Vf for pgadmin-hackers@arkaria.postgresql.org; Mon, 09 May 2016 13:15:37 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1azl27-0003BA-UX for pgadmin-hackers@arkaria.postgresql.org; Mon, 09 May 2016 13:15:35 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1azl27-0003B3-77 for pgadmin-hackers@postgresql.org; Mon, 09 May 2016 13:15:35 +0000 Received: from mail-ig0-x22f.google.com ([2607:f8b0:4001:c05::22f]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1azl1z-0000pu-Hg for pgadmin-hackers@postgresql.org; Mon, 09 May 2016 13:15:33 +0000 Received: by mail-ig0-x22f.google.com with SMTP id s8so91224871ign.0 for ; Mon, 09 May 2016 06:15:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=lr0jB0182Rh4p3CdQKrlkzLMPY10ieQegcuSteAb+68=; b=T/ZH1eD5P/FsXTedABFQvhWVKkFCLaEi0DLSPDSwXvNJK3fFjfvDSv6MsbMkolYePZ 7RXP92ttwasgXJzYdjuYSjRJT//lj18mjnRCazSnSfuvG2Inmc/XZb7S4tOf27+huvSo wvUsan6KWJf99ZTq2+B5+qP8cjLWdcLrv+7QOedIJ9GcWFjyZzloGjgLoRBK2lwA/Mzy vTDYRb0Obct2vbw0QFV9W0WGqWoR7ynR+A71oi/6zZ5WvAQ96h52hrjH77nrGzsjMyxf jcmh4r8mXSR0uH8fAw2G/voVjf5FyhbvWR8RHWSuPtjvS11A1q2Vntj2GNXipU7S1uGH IOvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=lr0jB0182Rh4p3CdQKrlkzLMPY10ieQegcuSteAb+68=; b=UF/NRbI0bP2gEba1W4rzKycWEdFlZqZK7dvygrJqFFRE4NgI7nG4YPri4k/CXamZiW KDNEX6xs+tr6RoC3OkXYQa4F7RBFadgUX/bkCSMCISG0ysmmVKkAj0e5JoMRIBPqRdM5 2Npw9fB0eOP6q/KPhx+k9WSRRFA9T8TmqDz3Y82jXP9UOa/qP6eCOtfuslfUuXsg8My5 NBcQgORHekgV+Lz3cF5l4hc9vixS9314huQGvwznarKGSn++yw6FfhiFBiH3SiLSgXUe sRn5HvZNE3DMT9VS3hC5CVReMo+DHSsXvO4OO2/lgf01T2WoK/tyTHycBQDycDMVm+Fg 0h6Q== X-Gm-Message-State: AOPr4FVM4MnKd2mZ36GqtyqG+2BRkQlPbJ8hEwYEJ7N4k5gfXX4xT5fiZF7rBNQKyESMjPIrUyzFZH2pZNgFXM1wg6/H/v9mVIyzY5rXPorBWarGXkCpSvY0l5bGQHRtCjQe0bWaK0KqCExfE0k6vBKMnhTiY58bn3ovUrR70V05+0s6VB3gbeOlBeG21dX4cbSH5yawPg== X-Received: by 10.50.150.107 with SMTP id uh11mr10612333igb.1.1462799726646; Mon, 09 May 2016 06:15:26 -0700 (PDT) Received: from mail-io0-f178.google.com (mail-io0-f178.google.com. [209.85.223.178]) by smtp.gmail.com with ESMTPSA id 11sm13645619ioe.25.2016.05.09.06.15.24 for (version=TLSv1/SSLv3 cipher=OTHER); Mon, 09 May 2016 06:15:25 -0700 (PDT) Received: by mail-io0-f178.google.com with SMTP id 190so171853686iow.1 for ; Mon, 09 May 2016 06:15:24 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.107.56.198 with SMTP id f189mr37817368ioa.156.1462799724332; Mon, 09 May 2016 06:15:24 -0700 (PDT) Received: by 10.64.105.131 with HTTP; Mon, 9 May 2016 06:15:24 -0700 (PDT) In-Reply-To: References: Date: Mon, 9 May 2016 14:15:24 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: PATCH: pgAdmin4 debian installer From: Dave Page To: Paresh More Cc: pgadmin-hackers , Sandeep Thakkar , Hamid Quddus Content-Type: multipart/alternative; boundary=001a114a6b20f297f10532689965 X-Pg-Spam-Score: -2.2 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a114a6b20f297f10532689965 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Please see my earlier comments regarding the RPM packages - many of them apply to this patch as well: http://www.postgresql.org/message-id/CA+OCxoxBDt82P75Q4Cy4fBkznkPBW3YJwPz+w= FARbBBSoi3fgg@mail.gmail.com By way of additional comment, why does pkg/deb/README include a bunch of boiler-plate text that I wrote long ago for the top-level README? It's out of date now, and shouldn't be in a packaging README anyway. Thanks. On Tue, Apr 26, 2016 at 4:20 PM, Paresh More wrote: > Hi Team, Dave, > > debian package is located @ location > > pgadmin4-web > > https://uploads.enterprisedb.com/download.php?file=3D0196f693811b57088da5= ed7396cec284 > > pgadmin4-runtime > > https://uploads.enterprisedb.com/download.php?file=3D958528f7c619efa7b483= a6d2e0c23cd5 > > Attached herewith are two patches. > > pgadmin4_debian.patch - This is the main patch that includes > Makefile,README,debian scripts > > It will create two .deb i.e pgadmin4-runtime and pgadmin4-web. > The pgadmin4-runtime depends on web and the web debian depends on the > python packages. > I have listed some packages which are not available on some systems so > that Devrim can build them. > > The installation path for pgadmin4 is "/usr/pgadmin4/." and > pgadmin4-web is the site-packages/pgadmin4-web > > As per rpm patch (*sandeep mentioned*) below is the comment which applies > same for debian. > > *pgadmin4-server-ini.patch* - This is the patch for runtime/Server.cpp. > As said pgadmin4-web and runtime installation directories are different a= nd > that means web does not exists in parallel to runtime like in sources. > > *Sandeep comments* > > *=E2=80=9CI observed that the location of application settings was not de= fined in* > *Server.cpp. As per QSettings doc, the default location on Unix is the* > *$HOME/.config//.conf. Here, $HOME depends on the > user* > *that runs the application. So, I thought why not to define the > application* > *settings in application directory itself. RPM then knows where to define= * > *the ApplicationPath. I tested it and it worked fine with me. I haven't > done* > *this change for platform dependent* > > *Another change that I did in this file is that, I observed that > canonicalPath()* > *was not giving the absolute path (by removing the sym link and the* > *redundant ".." as per doc). Hence, I used absolutePath() for the paths[i= ]* > *that are relative (../web, etc) and not for the already absolute path > (ex.* > *ApplicationPath like /usr/lib/python2.7/site-packages/pgadmin4-web)=E2= =80=9D* > > What the patch will create ? > - It would create deb folder in pkg > - It would create Makefile, README and debian scripts > > > -- > > Thanks & Regards > > *Paresh More* > > [image: NEW-EDB-logo-4c] > > Pune, India. > Cell : +919922000564 | www.enterprisedb.com > --=20 Dave Page VP, Chief Architect, Tools & Installers EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company Blog: http://pgsnake.blogspot.com Twitter: @pgsnake --001a114a6b20f297f10532689965 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi

Please see my earlier comments regar= ding the RPM packages - many of them apply to this patch as well:=C2=A0http://www.postgresql.org/message-id/C= A+OCxoxBDt82P75Q4Cy4fBkznkPBW3YJwPz+wFARbBBSoi3fgg@mail.gmail.com
=

By way of additional comment, why does pkg/deb/README i= nclude a bunch of boiler-plate text that I wrote long ago for the top-level= README? It's out of date now, and shouldn't be in a packaging READ= ME anyway.

Thanks.

On Tue, Apr 26, 2016 at 4:20 PM, Pare= sh More <paresh.more@enterprisedb.com> wrote:
=
Hi Team, Dave,

debian package is located @ location

=
pgadmin4-web

pgadmin4-runtime

Attached= herewith are two patches.

pgadmin4_debian.patch -= This is the main patch that includes Makefile,README,debian scripts
<= div>
It will create two .deb i.e pgadmin4-runtime and pgadmin= 4-web.=C2=A0
The =C2=A0pgadmin4-runtime depends on web and the we= b debian depends on the python packages.=C2=A0
I have listed some= packages which are not available on some systems so that Devrim can build = them.

The installation path for pgadmin4 is "= /usr/pgadmin4/<major>.<minor>" and pgadmin4-web is the sit= e-packages/pgadmin4-web

As per rpm patch (sande= ep mentioned) below is the comment which applies same for debian.
=

pgadmin4-server-ini.patch=C2= =A0- This is the patch for runtime/Server.cpp. As said pgadmin4-web and run= time installation directories are different and
that means we= b does not exists in parallel to runtime like in sources.
<= i>
Sandeep comments

=E2=80=9CI observed that the location of application settings was not = defined in
Server.cpp. As per QSettings doc, the defau= lt location on Unix is the
$HOME/.config/<companyname&g= t;/<appname>.conf. Here, $HOME depends on the user
t= hat runs the application. So, I thought why not to define the application
settings in application directory itself. RPM then knows wh= ere to define
the ApplicationPath. I tested it and it work= ed fine with me. I haven't done
this change for platfo= rm dependent

Another change that I d= id in this file is that, I observed that canonicalPath()
w= as not giving the absolute path (by removing the sym link and the
=
redundant ".." as per doc). Hence, I used absolutePath() = for the paths[i]
that are relative (../web, etc) and not f= or the already absolute path (ex.
ApplicationPath like /us= r/lib/python2.7/site-packages/pgadmin4-web)=E2=80=9D

What the patch will create ?
- It would create deb folder = in pkg=C2=A0
- It would create Makefile, README and debian script= s

<= br>
--

Thanks & Regards

Paresh More

3D"NEW-EDB-log=

Pune, India.




--
Dave Page
VP, Chief Architect, Tools & Installe= rs
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
=
Blog: http://= pgsnake.blogspot.com
Twitter: @pgsnake
--001a114a6b20f297f10532689965--