MIME-Version: 1.0
References: 
 <CAM9w-_nA2VQYK8=++WQ2jnhkFF0qzK+995-ako1rOKuEqC5nsw@mail.gmail.com>
In-Reply-To: 
 <CAM9w-_nA2VQYK8=++WQ2jnhkFF0qzK+995-ako1rOKuEqC5nsw@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Wed, 12 Jun 2019 09:23:57 +0100
Message-ID: 
 <CA+OCxowox7eDXeYHDS4LmJW3ZTJmSZO8bttJpq8v5neq91bUUg@mail.gmail.com>
Subject: Re: [pgAdmin][RM3782] Debugger title should show connection and
 object details
To: Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000378a67058b1c23bf"
Precedence: bulk

--000000000000378a67058b1c23bf
Content-Type: text/plain; charset="UTF-8"

Hi

On Wed, Jun 12, 2019 at 7:03 AM Aditya Toshniwal <
aditya.toshniwal@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached is the patch to add more information on connection details to
> debugger panel title and content title similar to Query Tool and View/Edit
> data.
> Adding the object name with arguments is not a good idea for the panel
> title, so I have kept to connection details similar to query tool. The
> content title will have all the details.
>
> Kindly review.
>

I think not having the function name in there is a big limitation.

With all this hacking going on, I think what we need to do is stop and make
this configurable as has been both requested by users and suggested by us.

I propose adding 2 preference options for each tab type. Each of these
would be a string with placeholders, one for the tab title, and one for the
tab tooltip. For example:

- Query Tool
  * Placeholders: %DATABASE%, %SERVER%, %USERNAME%, %PORT%, %HOST%
  * Tab title default: %DATABASE% on %SERVER%
  * Tooltip title default: Query Tool: %DATABASE% on %USERNAME%@%SERVER%

- View Data
  * Placeholders: %TABLE%, %SCHEMA%, %DATABASE%, %SERVER%, %USERNAME%,
%PORT%, %HOST%
  * Tab title default: %SCHEMA%.%TABLE% in %DATABASE% on %SERVER%
  * Tooltip title default: View/Edit Data: %SCHEMA%.%TABLE% in %DATABASE%
on %USERNAME%@%SERVER%

- Script
  * Placeholders: %ACTION%, %OBJECT%, %SCHEMA%, %DATABASE%, %SERVER%,
%USERNAME%, %PORT%, %HOST%
  * Tab title default: %ACTION% %SCHEMA%.%OBJECT% in %DATABASE% on %SERVER%
  * Tooltip title default: %ACTION% Script: %SCHEMA%.%OBJECT% in %DATABASE%
on %USERNAME%@%SERVER%

- Debugger
  * Placeholders: %FUNCTION_ARGS%, %FUNCTION_NOARGS%, %SCHEMA%, %DATABASE%,
%SERVER%, %USERNAME%, %PORT%, %HOST%
  * Tab title default: %FUNCTION_NOARGS%.%OBJECT% in %DATABASE% on %SERVER%
  * Tooltip title default: Debugger: %SCHEMA%.%FUNCTION_ARGS% in %DATABASE%
on %USERNAME%@%SERVER%

Or something like that. Thoughts?

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--000000000000378a67058b1c23bf
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Hi</div><br><div class=3D"gmail_quote"><div dir=3D"lt=
r" class=3D"gmail_attr">On Wed, Jun 12, 2019 at 7:03 AM Aditya Toshniwal &l=
t;<a href=3D"mailto:aditya.toshniwal@enterprisedb.com">aditya.toshniwal@ent=
erprisedb.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" sty=
le=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);paddi=
ng-left:1ex"><div dir=3D"ltr"><div style=3D"font-family:verdana,sans-serif"=
>Hi Hackers,</div><div style=3D"font-family:verdana,sans-serif"><br></div><=
div style=3D"font-family:verdana,sans-serif">Attached is the patch to add m=
ore information on connection details to debugger panel title and content t=
itle similar to Query Tool and View/Edit data.</div><div style=3D"font-fami=
ly:verdana,sans-serif">Adding the object name with arguments is not a good=
=C2=A0idea for the panel title, so I have kept to connection details simila=
r to query tool. The content title will have all the details.</div><div><br=
></div><div><div style=3D"font-family:verdana,sans-serif">Kindly review.</d=
iv></div></div></blockquote></div><div><br></div><div>I think not having th=
e function name in there is a big limitation.</div><div><br></div><div>With=
 all this hacking going on, I think what we need to do is stop and make thi=
s configurable as has been both requested by users and suggested by us.</di=
v><div><br></div><div>I propose adding 2 preference options for each tab ty=
pe. Each of these would be a string with placeholders, one for the tab titl=
e, and one for the tab tooltip. For example:</div><div><br></div><div>- Que=
ry Tool</div><div>=C2=A0 * Placeholders: %DATABASE%, %SERVER%, %USERNAME%, =
%PORT%, %HOST%</div><div>=C2=A0 * Tab title default: %DATABASE% on %SERVER%=
</div><div>=C2=A0 * Tooltip title default: Query Tool: %DATABASE% on %USERN=
AME%@%SERVER%</div><div><br></div><div>- View Data</div><div><div>=C2=A0 * =
Placeholders: %TABLE%, %SCHEMA%, %DATABASE%, %SERVER%, %USERNAME%, %PORT%, =
%HOST%</div><div>=C2=A0 * Tab title default: %SCHEMA%.%TABLE% in %DATABASE%=
 on %SERVER%</div><div>=C2=A0 * Tooltip title default: View/Edit Data: %SCH=
EMA%.%TABLE% in=C2=A0%DATABASE% on %USERNAME%@%SERVER%</div></div><div><br>=
</div><div>- Script</div><div><div>=C2=A0 * Placeholders: %ACTION%, %OBJECT=
%, %SCHEMA%, %DATABASE%, %SERVER%, %USERNAME%, %PORT%, %HOST%</div><div>=C2=
=A0 * Tab title default: %ACTION% %SCHEMA%.%OBJECT% in %DATABASE% on %SERVE=
R%</div><div>=C2=A0 * Tooltip title default: %ACTION% Script: %SCHEMA%.%OBJ=
ECT% in=C2=A0%DATABASE% on %USERNAME%@%SERVER%</div></div><div><br></div><d=
iv>- Debugger</div><div><div>=C2=A0 * Placeholders: %FUNCTION_ARGS%, %FUNCT=
ION_NOARGS%, %SCHEMA%, %DATABASE%, %SERVER%, %USERNAME%, %PORT%, %HOST%</di=
v><div>=C2=A0 * Tab title default: %FUNCTION_NOARGS%.%OBJECT% in %DATABASE%=
 on %SERVER%</div><div>=C2=A0 * Tooltip title default: Debugger: %SCHEMA%.%=
FUNCTION_ARGS% in=C2=A0%DATABASE% on %USERNAME%@%SERVER%</div></div><div><b=
r></div><div>Or something like that. Thoughts?</div><div><br></div>-- <br><=
div dir=3D"ltr" class=3D"gmail_signature">Dave Page<br>Blog: <a href=3D"htt=
p://pgsnake.blogspot.com" target=3D"_blank">http://pgsnake.blogspot.com</a>=
<br>Twitter: @pgsnake<br><br>EnterpriseDB UK: <a href=3D"http://www.enterpr=
isedb.com" target=3D"_blank">http://www.enterprisedb.com</a><br>The Enterpr=
ise PostgreSQL Company<br></div></div>

--000000000000378a67058b1c23bf--