MIME-Version: 1.0
In-Reply-To: 
 <CAFiP3vxypqvRUNMNcQjM6Fqn19fvLdBH91W116ouBj=59qQ5SQ@mail.gmail.com>
References: 
 <CAFiP3vxypqvRUNMNcQjM6Fqn19fvLdBH91W116ouBj=59qQ5SQ@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Thu, 21 Jul 2016 13:48:20 +0100
Message-ID: 
 <CA+OCxowpT=WPamrmAvqrcNEqAx0yimHU13_iOLP4WBTXEEkVfg@mail.gmail.com>
Subject: Re: patch for RM1460 [pgAdmin4]
To: Harshal Dhumal <harshal.dhumal@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: text/plain; charset=UTF-8
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

Hi

Works nicely - committed!

One change I think we should make (please provide a patch when you get
a minute) is to always allow the dropdown menu and Save As to be used,
regardless of whether the file is dirty. Save should only be available
when there are changes of course.

Thanks!

On Wed, Jul 20, 2016 at 1:12 PM, Harshal Dhumal
<harshal.dhumal@enterprisedb.com> wrote:
> Hi,
>
> PFA patch for RM1460
>
> Changes:
> - Opening a file should set the tab name to the filename
> - Editing a file should add a * to the tab name to indicate the file is
> dirty
> - Saving changes to a file should clear the *
> - The Save button should have a drop-down menu, with a Save As option.
>
> --
> Harshal Dhumal
> Software Engineer
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers