MIME-Version: 1.0
References: 
 <CAM9w-_mxRdG6peLx3VdF1z-+yY11qQEPNTQ0ekT5TNaEWT05QQ@mail.gmail.com>
In-Reply-To: 
 <CAM9w-_mxRdG6peLx3VdF1z-+yY11qQEPNTQ0ekT5TNaEWT05QQ@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Wed, 26 Jun 2019 07:21:29 -0400
Message-ID: 
 <CA+OCxowrfff5pU-sKTpk8G4oDpxpYRSmJ-mZbrhWWTYPB7fubQ@mail.gmail.com>
Subject: Re: [pgAdmin][RM4139] Drag and drop object names in Query Editor from
 Browser Tree
To: Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000d92670058c383f0c"
Precedence: bulk

--000000000000d92670058c383f0c
Content-Type: text/plain; charset="UTF-8"

Hi

On Wed, Jun 26, 2019 at 2:24 AM Aditya Toshniwal <
aditya.toshniwal@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached is the patch to allow tree nodes to be dragged and dropped in
> query editor wherever you take the drop cursor. The drop text will be fully
> qualified and double quoted if required.
> For functions/procedures it will drop the the label stripping away the
> parameter names, with empty pair of round brackets. It will also set the
> focus cursor inside the brackets if there were params otherwiser to the end
> of text.
> For adding a node type, you need to register it in browser.js along with a
> callback function which will return drop text along with cursor positioning
> and selection. Currently, I have registered for "table partition type
> sequence package view mview foreign_table edbvar schema column edbfunc
> function edbproc procedure".
>
> Please note, the drag design customisation is not supported in IE.
>

I think for functions/procedures, we should include placeholders for the
parameters, so the user has a hint about what they need to fill in to
complete the call.

Also; shouldn't there be a doc update?

Thanks.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--000000000000d92670058c383f0c
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Hi</div><br><div class=3D"gmail_quote"><div dir=3D"lt=
r" class=3D"gmail_attr">On Wed, Jun 26, 2019 at 2:24 AM Aditya Toshniwal &l=
t;<a href=3D"mailto:aditya.toshniwal@enterprisedb.com">aditya.toshniwal@ent=
erprisedb.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" sty=
le=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);paddi=
ng-left:1ex"><div dir=3D"ltr"><div style=3D"font-family:verdana,sans-serif"=
>Hi Hackers,</div><div style=3D"font-family:verdana,sans-serif"><br></div><=
div style=3D"font-family:verdana,sans-serif">Attached is the patch to allow=
 tree nodes to be dragged and dropped in query editor wherever you take the=
 drop cursor. The drop text will be fully qualified and double quoted if re=
quired.</div><div style=3D"font-family:verdana,sans-serif">For functions/pr=
ocedures it will drop the the label stripping away the parameter names, wit=
h empty pair of round brackets. It will also set the focus cursor inside th=
e brackets if there were params otherwiser to the end of text.</div><div><s=
pan style=3D"font-family:verdana,sans-serif">For adding a node type, you ne=
ed to register it in browser.js along with a callback function which will r=
eturn drop text along with cursor positioning and selection. Currently, I h=
ave=C2=A0</span><font face=3D"verdana, sans-serif">registered for &quot;tab=
le partition type sequence package view mview foreign_table edbvar schema c=
olumn edbfunc function edbproc procedure&quot;.</font></div><div><font face=
=3D"verdana, sans-serif"><br></font></div><div><font face=3D"verdana, sans-=
serif">Please note, the drag design customisation is not supported in IE.</=
font></div></div></blockquote><div><br></div><div>I think for functions/pro=
cedures, we should include placeholders for the parameters, so the user has=
 a hint about what they need to fill in to complete the call.</div><div><br=
></div><div>Also; shouldn&#39;t there be a doc update?</div><div><br></div>=
<div>Thanks.</div><div>=C2=A0</div></div>-- <br><div dir=3D"ltr" class=3D"g=
mail_signature">Dave Page<br>Blog: <a href=3D"http://pgsnake.blogspot.com" =
target=3D"_blank">http://pgsnake.blogspot.com</a><br>Twitter: @pgsnake<br><=
br>EnterpriseDB UK: <a href=3D"http://www.enterprisedb.com" target=3D"_blan=
k">http://www.enterprisedb.com</a><br>The Enterprise PostgreSQL Company<br>=
</div></div>

--000000000000d92670058c383f0c--