Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cZdyb-0001Td-Uz for pgadmin-hackers@arkaria.postgresql.org; Fri, 03 Feb 2017 13:32:34 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1cZdyb-0000DD-Gy for pgadmin-hackers@arkaria.postgresql.org; Fri, 03 Feb 2017 13:32:33 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cZdyN-0008PM-NP for pgadmin-hackers@postgresql.org; Fri, 03 Feb 2017 13:32:19 +0000 Received: from mail-io0-x22d.google.com ([2607:f8b0:4001:c06::22d]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1cZdyJ-0000ui-Em for pgadmin-hackers@postgresql.org; Fri, 03 Feb 2017 13:32:18 +0000 Received: by mail-io0-x22d.google.com with SMTP id l66so17363566ioi.1 for ; Fri, 03 Feb 2017 05:32:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=eFWE71NL908X+5KB5tk5q4vBu+hEBB3MPStSv0V/4ZI=; b=DNZY8pdlmNHP/48O5MmPZjMrqqjTvGcEDvlK76qxo5/mdfdOlHBkdohqM9tMLe8B9O 6E1wUUzYVNPMfBt4kfI02teQmBrqb06mK2IUvkRMEdVku4kvbEkkSZzWH3FFsYwqO0Go UMvGo8gVtAF9m/Zn4sxJkTU6s04ulyXqvsg7ApzzMNv1oJQze3ZUVkOaPtTuNG+KHpEr MU9VWTYKsT+3mLrU4NF0pTM2Zbd4SDrp6QZ3iLviUCTZWHQK0tE3VAsiEpPr8PToR8zF t3R6c4fO54CSW0dE3KRHkPCn8lct9YH3Zj3mqDu4QEMjhxZgPBNb3qBccLhUSHXOuPYt TbMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=eFWE71NL908X+5KB5tk5q4vBu+hEBB3MPStSv0V/4ZI=; b=e432AU7JAV1gxlnYIfXhD/qp8kwtzzz/Hof0hpwd/ANL+slafmhgjilBV/eSiYz39y sBo/uhDawhy1hvNkSYBxKMOpinc8DNMHC6ZZkcfcXPgPSWXQHwrFhfik2Rj05OA2C89t HGxqSQkfqRdxrfGs7btOKVJIPEp510AopcJpZi7yx1yck2CAklTY+LBBTeAw7HrWeUN7 J65hWml+wJzotHEmGEOuYqEZIgbTQCv3wnT3ZWqxlSXT8MZWoWmAFfdhpg6KWLRN9nMG t4fJhaoY7idnYR0Tgn/+GTpzy5wvk9cRxiwvhJZszksm1YpUyN4+x2fRISAvg0GLqTFq 1JYg== X-Gm-Message-State: AIkVDXIBOrN4G5F/zfBlu1IcyzJtt1xCJn48DbIAVUplXeRGRKUpypF8YqyKXTHZUxMjwB8pg/j9mxvXWOWbmd+794+g+ukfzx2m+/WrBehKvan0CYKQa6Ci8pItYXBJFioIn6cuqNjdt6W7OuyPLkqMWTdby8vvc2N/UleqE4TBpSzIgzcZvWHZMJj2DSSvyAjC/zKJsQ== X-Received: by 10.107.12.88 with SMTP id w85mr9754696ioi.96.1486128733033; Fri, 03 Feb 2017 05:32:13 -0800 (PST) Received: from mail-io0-f170.google.com (mail-io0-f170.google.com. [209.85.223.170]) by smtp.gmail.com with ESMTPSA id 16sm920152itu.17.2017.02.03.05.32.12 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 03 Feb 2017 05:32:12 -0800 (PST) Received: by mail-io0-f170.google.com with SMTP id j13so17221821iod.3 for ; Fri, 03 Feb 2017 05:32:12 -0800 (PST) X-Received: by 10.107.53.215 with SMTP id k84mr5073168ioo.45.1486128731817; Fri, 03 Feb 2017 05:32:11 -0800 (PST) MIME-Version: 1.0 Received: by 10.64.224.198 with HTTP; Fri, 3 Feb 2017 05:32:11 -0800 (PST) In-Reply-To: References: From: Dave Page Date: Fri, 3 Feb 2017 13:32:11 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [pgAdmin4][Patch]: RM 2089 - PARALLEL SAFE support for functions missing To: Akshay Joshi Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=001a1144919826cc1d0547a04feb X-Pg-Spam-Score: -2.1 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a1144919826cc1d0547a04feb Content-Type: text/plain; charset=UTF-8 I doubt the order matters, but feel free to change it if it bugs you :-) On Fri, Feb 3, 2017 at 12:54 PM, Akshay Joshi wrote: > Hi Dave > > I have reviewed the patch and after applying it output in pgAdmin4 > > CREATE OR REPLACE FUNCTION public.st_intersects(geom1 geometry, geom2 > geometry) > RETURNS boolean > LANGUAGE 'sql' > COST 100.0 > *IMMUTABLE NOT LEAKPROOF * > * PARALLEL SAFE* > AS $function$ > SELECT $1 OPERATOR(public.&&) $2 AND public._ST_Intersects($1,$2) > $function$; > > but as per psql it should be > > CREATE OR REPLACE FUNCTION public.st_intersects(geom1 geometry, geom2 > geometry) > > RETURNS boolean > > LANGUAGE sql > > *IMMUTABLE PARALLEL SAFE* > > AS $function$SELECT $1 OPERATOR(public.&&) $2 AND > public._ST_Intersects($1,$2)$function$ > > > is this behaviour correct?? > > > > On Fri, Feb 3, 2017 at 5:31 PM, Khushboo Vashi < > khushboo.vashi@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached patch to fix RM 2089 : PARALLEL SAFE support for >> functions missing. >> >> Fix: Incorporated the PARALLEL SAFE support for the functions and >> procedures for PostgreSQL 9.6. >> >> Thanks, >> Khushboo >> >> >> >> -- >> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >> To make changes to your subscription: >> http://www.postgresql.org/mailpref/pgadmin-hackers >> >> > > > -- > *Akshay Joshi* > *Principal Software Engineer * > > > > *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 976-788-8246 > <+91%2097678%2088246>* > -- Dave Page VP, Chief Architect, Tools & Installers EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company Blog: http://pgsnake.blogspot.com Twitter: @pgsnake --001a1144919826cc1d0547a04feb Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
I doubt the order matters, but feel free to change it if i= t bugs you :-)

On Fri, Feb 3, 2017 at 12:54 PM, Akshay Joshi <akshay.joshi= @enterprisedb.com> wrote:
<= div dir=3D"ltr">Hi Dave=C2=A0

I have reviewed the patch = and after applying it output in pgAdmin4 =C2=A0

CREATE OR REPLACE FUNCTION public.st_intersects(geom1 geometry, geom2 ge= ometry)
=C2=A0 =C2=A0 RETURNS boolean
=C2=A0 =C2=A0 LANGUAGE 'sql'
<= div>=C2=A0 =C2=A0 COST 100.0
=C2=A0 =C2=A0 IMMUTABLE NOT LEAKPROOF=C2=A0
<= b>=C2=A0 =C2=A0 PARALLEL SAFE
AS $function$
SELECT = $1 OPERATOR(public.&&) $2 AND public._ST_Intersects($1,$2)
$function$;

but as per psql it should be=C2=A0

<= div>

CREATE OR REPLACE FUNCTION public.st_intersects(geom1 geometry, geom2 = geometry)

=C2=A0RETURNS boolean

=C2=A0LANGUAGE sql

=C2=A0IMMUTABLE PARALLEL SAFE

AS $function$SELECT $1 OPERATOR(public.&&) $2 AND public._ST_Inter= sects($1,$2)$function$


is this behaviour correct??



On Fri, F= eb 3, 2017 at 5:31 PM, Khushboo Vashi <khushboo.vashi@enterp= risedb.com> wrote:
Hi,

Ple= ase find the attached patch to fix RM 2089 : PARALLEL SAFE support for func= tions missing.

Fix: Incorporated the =C2=A0PARALLE= L SAFE support for the functions and procedures for PostgreSQL 9.6.

Thanks,
Khushboo



--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-ha= ckers




--
Akshay = Joshi
Principal Software Engineer=C2=A0
=
=



--
Dave Page
VP, Ch= ief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
Th= e Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pg= snake
--001a1144919826cc1d0547a04feb--