Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fT6NC-0003lR-Ma for pgadmin-hackers@arkaria.postgresql.org; Wed, 13 Jun 2018 14:03:43 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fT6NB-00052M-Gj for pgadmin-hackers@arkaria.postgresql.org; Wed, 13 Jun 2018 14:03:41 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fT6NB-00052B-5Y for pgadmin-hackers@lists.postgresql.org; Wed, 13 Jun 2018 14:03:41 +0000 Received: from mail-wr0-x241.google.com ([2a00:1450:400c:c0c::241]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1fT6N3-0007kf-S9 for pgadmin-hackers@postgresql.org; Wed, 13 Jun 2018 14:03:40 +0000 Received: by mail-wr0-x241.google.com with SMTP id f16-v6so2913865wrm.3 for ; Wed, 13 Jun 2018 07:03:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=BJNx6HVyJprYcFsgSVfV52ymZaBF2vpwUzD0sg1E4Fw=; b=DONcLl87hEnBNfyOWs6G4Gr0iDMjlCUJ1Lt4vKSbytIAMrPw/QoAMvCNSEovJQf6Vk RNUZOXib0Lj3aAZwQLDxVN4iuulYJcqkra0itdIu9IujCbUnqbE0sEdkpCaVeEUeEP/H rWdPXWapwx5viUu6Yr1SW9Xh0OaSRD54OA4QQ5djPNWDwpWkPYGBHjumK2jgLckP3GOK VHArKii8HYXAPeiR57Ehcc84I1+GasZPiQFFjwHXQke6Fo498J95Su1rEpc9iBPUMkr6 DdSzME091ulNmQO/7vl0rqbKjcfX1ZIUqrB63emD0n0aHEzsqF3Aiq8nl1YFhaevl6p4 CCDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=BJNx6HVyJprYcFsgSVfV52ymZaBF2vpwUzD0sg1E4Fw=; b=lDzN1vTpdsLFzBu2uo1JsI9g8CcOXwjNtoRqJdsk4G/1HAF7wfDKRadDRVaAUnslaG AyR0A1Qur1TJimmwskyhYLvCW+UgzRtFtfW3g+zcXwI/VILY8mIrjzuDl/DvfTSyi2bi XMGRmONlV/ITyaiQMs/MKEyFGQVYK9ImjhyigLgfSL1+kSLi0DxikMMMyarws2IskwmV nPNY2Zndl2ZRkzysExla4f0x9UrKHQYvi5nXjahVslEvTTobZ0pUw/bNBonORJmlKIGY bqMUKy2GV0VVJjUVNdYATDcrTMLYEdX/DBHiKdt5KNOGEznyTUn5Y8rMK9YsxuXKmRat ldaw== X-Gm-Message-State: APt69E0WB+ok4zgk2VgZvrswAi7vPl4uRLH9lyIkUloQIxGyjMPJiARo wBGE184CzVJNuT+CWCpmA4R3CKxaKnm2b3QlcGkeYQ== X-Google-Smtp-Source: ADUXVKLB4L111C9iqm6Bei1TE9KoDqUlRokMlrVx7T55GW44yI/wlHY5YrpB0eGuaZZ3LRnFx1fcAxzm1qRD4OYmECg= X-Received: by 2002:adf:8211:: with SMTP id 17-v6mr4288276wrb.144.1528898612918; Wed, 13 Jun 2018 07:03:32 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a1c:2907:0:0:0:0:0 with HTTP; Wed, 13 Jun 2018 07:03:32 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Wed, 13 Jun 2018 15:03:32 +0100 Message-ID: Subject: Re: [pgAdmin4][Patch]: RM 3362 - Fix the functions for PG v11, and add support procedure for PG v11 To: Khushboo Vashi Cc: Victoria Henry , pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000b8965d056e8672f8" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000b8965d056e8672f8 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thanks, patch applied. On Wed, Jun 13, 2018 at 12:43 PM, Khushboo Vashi < khushboo.vashi@enterprisedb.com> wrote: > Please ignore my previous patch. Find the attached updated patch. > > On Wed, Jun 13, 2018 at 9:32 AM, Khushboo Vashi < > khushboo.vashi@enterprisedb.com> wrote: > >> Hi Victoria, >> >> The updated patch is attached. >> >> On Tue, Jun 12, 2018 at 9:36 PM, Victoria Henry >> wrote: >> >>> Hi Khushboo, >>> >>> The following change is allowing the creation of procedures in >>> postgresql versions less then 11 and also GreenPlum >>> >>> --- a/web/pgadmin/browser/server_groups/servers/databases/schemas/funct= ions/static/js/procedure.js >>> +++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/funct= ions/static/js/procedure.js >>> @@ -71,11 +71,7 @@ define('pgadmin.node.procedure', [ >>> if ('catalog' in node_hierarchy) >>> return false; >>> >>> - // Procedures supported only in PPAS >>> - return ( >>> - 'server' in node_hierarchy && >>> - node_hierarchy['server'].server_type =3D=3D 'ppas' >>> - ); >>> + return true; >>> >>> Fixed. >> >>> Now that the Procedures are a thing in Postgresql maybe they should liv= e >>> in their own module. >>> >> The main functionalities of the functions and procedures are almost same >> and we have inherited most of the things from function itself. >> So, as per me they should live in one module. >> >>> In the tests for trigger functions we are not consistent on the naming >>> of the utils , in some places we call it funcs_utils in others >>> trigger_funcs_utils. >>> >> Fixed. >> >>> Thanks >>> =E2=80=8B >>> Victoria & Joao >>> >>> Thanks, >> Khushboo >> >>> On Tue, Jun 12, 2018 at 3:10 AM Khushboo Vashi < >>> khushboo.vashi@enterprisedb.com> wrote: >>> >>>> Hi, >>>> >>>> Please find the attached updated patch. >>>> >>>> On Fri, Jun 8, 2018 at 2:21 PM, Dave Page wrote: >>>> >>>>> Hi >>>>> >>>>> On Thu, Jun 7, 2018 at 11:27 AM, Khushboo Vashi < >>>>> khushboo.vashi@enterprisedb.com> wrote: >>>>> >>>>>> Hi, >>>>>> >>>>>> Please ignore my previous patch, find the attached updated one. >>>>>> >>>>> >>>>> I found a couple of issues with this: >>>>> >>>>> - Clicking the + button on the Parameters tab does nothing in either >>>>> Create or Edit modes >>>>> >>>>> Fixed >>>> >>>>> - The debugger fails to start (though, perhaps that's because the >>>>> plugin doesn't have Ashesh's latest patches in it). >>>>> >>>>> FYI, I was trying to test the debugger with: >>>>> >>>>> -- PROCEDURE: public.dummy_proc(integer) >>>>> >>>>> -- DROP PROCEDURE public.dummy_proc(integer); >>>>> >>>>> CREATE OR REPLACE PROCEDURE public.dummy_proc( >>>>> id integer) >>>>> LANGUAGE 'plpgsql' >>>>> >>>>> AS $BODY$BEGIN >>>>> raise notice 'id is %', id; >>>>> END;$BODY$; >>>>> >>>>> Fixed. Tested with the latest code of the plugin. >>>> >>>>> Thanks! >>>>> >>>>> Thanks, >>>> Khushboo >>>> >>>>> -- >>>>> Dave Page >>>>> Blog: http://pgsnake.blogspot.com >>>>> Twitter: @pgsnake >>>>> >>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>> >>>> >> > --=20 Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --000000000000b8965d056e8672f8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.
On Wed, Jun 13, 2018 at 12:43 PM, Khushboo Vash= i <khushboo.vashi@enterprisedb.com> wrote:
=
Please ignore my previous p= atch. Find the attached updated patch.

On Wed, = Jun 13, 2018 at 9:32 AM, Khushboo Vashi <khushboo.vashi@ente= rprisedb.com> wrote:
<= div dir=3D"ltr">Hi Victoria,

The updated patch is attach= ed.

On Tue, Jun 12, 2018 at 9:36 PM, Victoria Henry <vhenry@pivotal.io>= ; wrote:

Hi= Khushboo,

The following change is allowin= g the creation of procedures in postgresql versions less then 11 and also G= reenPlum

--- a/web/pgadmin/br=
owser/server_groups/servers/databases/schemas/functions/static/js=
/procedure.js
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas=
/functions/static/js/procedure.js
@@ -71,11 +71,7 @@ define('pgadmin.node.procedure', [
         if ('catalog' in node_hierarchy)
           return false;

-        // Procedures supported only in PPAS
-        return (
-          'server' in node_hierarchy &&
-            node_hierarchy['server'].server_type =3D=3D '=
ppas'
-        );
+        return true;

Fixed.=C2=A0

Now that the Procedures are a thing in Postgresql maybe they= should live in their own module.=C2=A0

=
The main functionalities of the functions and procedures are almost sa= me and we have inherited most of the things from function itself.=C2=A0
So, as per me they should live in one module.

In the tests for trigger functions we are n= ot consistent on the naming of the utils , in some places we call it funcs_utils in others trigger_funcs_util= s.

Fixed.=C2=A0

Thanks

=E2=80=8B
Victori= a & Joao
=
Thanks,
Khushboo=C2=A0
=
On Tue, Jun 12, 2018 at 3:10 AM Khushboo Vashi <khushboo.vash= i@enterprisedb.com> wrote:
Hi,

Please find the atta= ched updated patch.

On Fri, Jun 8, 2018 at 2:21 PM, Dave Page <dpage@pgadmin.org>= wrote:
Hi

On Thu, Jun 7,= 2018 at 11:27 AM, Khushboo Vashi <khushboo.vashi@enterprise= db.com> wrote:
Hi,

Please ign= ore my previous patch, find the attached updated one.

I found a couple of issues with this:

- Clicking the + button on the Parameters tab does nothin= g in either Create or Edit modes

Fixed=C2=A0
-= The debugger fails to start (though, perhaps that's because the plugin= doesn't have Ashesh's latest patches in it).

<= div>FYI, I was trying to test the debugger with:

<= div>-- PROCEDURE: public.dummy_proc(integer)

-- DR= OP PROCEDURE public.dummy_proc(integer);

CREATE OR= REPLACE=C2=A0 PROCEDURE public.dummy_proc(
id integer)
LANGUAGE 'plpgsql'

AS $BODY$BEGIN
=C2=A0 raise notice 'id= is %', id;
END;$BODY$;

Fixed. Tested with the latest code of the plugin.<= /div>
Thanks!

Thanks,
Khushboo=C2=A0
--
Dave Page
= Blog: http://pgsn= ake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.= com
The Enterprise PostgreSQL Company






--
=
Dave Page=
Blog: http://= pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprised= b.com
The Enterprise PostgreSQL Company
--000000000000b8965d056e8672f8--