MIME-Version: 1.0
References: 
 <CAM9w-_mhLAoL3ZgY3w8SCH6WbSF=_11tU3Ueh-voAWkfgVZtVw@mail.gmail.com>
In-Reply-To: 
 <CAM9w-_mhLAoL3ZgY3w8SCH6WbSF=_11tU3Ueh-voAWkfgVZtVw@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Wed, 5 Jun 2019 12:18:03 +0100
Message-ID: 
 <CA+OCxowteeh7yjQLToCGWPtFsqSKK10E3wX6o8k8i5Rub-DoGA@mail.gmail.com>
Subject: Re: [pgAdmin][RM4310] User can not connect to the Master Password
 with Enter button
To: Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="0000000000000454f3058a91c1b1"
Precedence: bulk

--0000000000000454f3058a91c1b1
Content-Type: text/plain; charset="UTF-8"

Hi

On Wed, Jun 5, 2019 at 8:14 AM Aditya Toshniwal <
aditya.toshniwal@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached is the patch to fix an issue where using browser autofills in
> alertify dialogs triggers the help page button (#4317).
> A workaround was added to master password dialog to avoid this, but that
> in turn disabled the 'OK' button tigger on pressing enter button. This is
> also fixed with this patch.(#4310)
>

This isn't quite right. When the browser auto-fills the password, the OK
button remains disabled. I can hit enter though - however, I shouldn't be
able to do that when the OK button is disabled (being the default button on
the dialogue, it should respond to enter, unless another control which also
accepts enter has focus (e.g. a multiline text area).

The OK button should be enabled - probably all the time, as the user could
have entered a blank password, and most systems won't prevent a user from
trying to use such a password.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--0000000000000454f3058a91c1b1
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Hi</div><br><div class=3D"gmail_quote"><div dir=3D"lt=
r" class=3D"gmail_attr">On Wed, Jun 5, 2019 at 8:14 AM Aditya Toshniwal &lt=
;<a href=3D"mailto:aditya.toshniwal@enterprisedb.com">aditya.toshniwal@ente=
rprisedb.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" styl=
e=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);paddin=
g-left:1ex"><div dir=3D"ltr"><div style=3D"font-family:verdana,sans-serif">=
Hi Hackers,<br clear=3D"all"></div><div style=3D"font-family:verdana,sans-s=
erif"><br></div><div style=3D"font-family:verdana,sans-serif">Attached is t=
he patch to fix an issue where using browser autofills in alertify dialogs =
triggers the help page button (#4317).</div><div style=3D"font-family:verda=
na,sans-serif">A workaround was added to master password dialog to avoid th=
is, but that in turn disabled the &#39;OK&#39; button tigger on pressing en=
ter button. This is also fixed with this patch.(#4310)</div></div></blockqu=
ote><div><br></div><div>This isn&#39;t quite right. When the browser auto-f=
ills the password, the OK button remains disabled. I can hit enter though -=
 however, I shouldn&#39;t be able to do that when the OK button is disabled=
 (being the default button on the dialogue, it should respond to enter, unl=
ess another control which also accepts enter has focus (e.g. a multiline te=
xt area).</div><div><br></div><div>The OK button should be enabled - probab=
ly all the time, as the user could have entered a blank password, and most =
systems won&#39;t prevent a user from trying to use such a password.</div><=
/div><div><br></div>-- <br><div dir=3D"ltr" class=3D"gmail_signature">Dave =
Page<br>Blog: <a href=3D"http://pgsnake.blogspot.com" target=3D"_blank">htt=
p://pgsnake.blogspot.com</a><br>Twitter: @pgsnake<br><br>EnterpriseDB UK: <=
a href=3D"http://www.enterprisedb.com" target=3D"_blank">http://www.enterpr=
isedb.com</a><br>The Enterprise PostgreSQL Company<br></div></div>

--0000000000000454f3058a91c1b1--