Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ewEJa-0004Qk-AQ for pgadmin-hackers@arkaria.postgresql.org; Wed, 14 Mar 2018 21:52:06 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1ewEJX-0005RU-Bg for pgadmin-hackers@arkaria.postgresql.org; Wed, 14 Mar 2018 21:52:03 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ewEJX-0005RK-64 for pgadmin-hackers@lists.postgresql.org; Wed, 14 Mar 2018 21:52:03 +0000 Received: from mail-wm0-x235.google.com ([2a00:1450:400c:c09::235]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ewEJP-0007x6-HM for pgadmin-hackers@postgresql.org; Wed, 14 Mar 2018 21:52:02 +0000 Received: by mail-wm0-x235.google.com with SMTP id i194so6822746wmg.1 for ; Wed, 14 Mar 2018 14:51:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=3HjsMs7du8lQk4+r+ZTG1+Hm8QZWCH80DoIbMPrSM4A=; b=2DOozLd4/3VWgmdRnU0VXpRovC+NFT1qX8GDWpOsZtWeIEBSTlYpr+EDguPBmxGrXJ mLtAfDMaNlqvcGwH3arpTM5G+a1ewJ4jvdr2ylEEAc4yKc0hKCR7Tn06uDJQUxAqzuOE z+kFZcxdcEbCdM3r5XoqbyrYxgAkY/KRR/3pOFqtEA4cQvoWEuNp+Ai09s7xky+2z8Kd mYAqRm11zRfVfw73zWYL+bnDlAxlb429MWFMiguBLSZQNtQsx4t3EKRKz7wi5TLD5G3s oqvvyKHt8S5f7NILIpF7oAhwEnUaAX1B4OqG6jfYMlAumC/NZa++A1XB4RRTwHGz02N7 v4lA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=3HjsMs7du8lQk4+r+ZTG1+Hm8QZWCH80DoIbMPrSM4A=; b=r6pB//vPuH3q+tUhxgWeG5u9Wb9Bw651LZiIpXiTTKNb9NG3ysaaIfsH+03J03hwIn Y99Cdok78DCXjjGGsVQXR4FdM6h0XSoDmDbBnNr4qVZ7fWpb4jYStoQxA7/4LeJcAjAT FWBv5BQ/fsuJWOr1kclY8gbhrWiekGvRTrTykGXq+J+OjxOB0OrVNwHAEMD45U4Cbv/x aQ6aYaDjKEv8zpzNrrfE0Iezs39B0D3jgKr2lDDHV5Uq6QzhSZs9OMuz6uV3jw3d5ydo c8lEKP0JI+mp2RSkjsIGlJvKAyQZ/LhiUNdesVXB4iYZdtXsWqi5EqOxrPE5f4Fn76Fo CSMw== X-Gm-Message-State: AElRT7GVpOx5eyqgYHwfD8d/uy1V1XGdDqsg2sJz0c+XqrWFXIFQvfg/ L1XCst1R0N8GoUjwZkXk2K3q+tp3NUDykdA1fFx5kQ== X-Google-Smtp-Source: AG47ELu2uQPvfF/vOQDLVIXE2QeipqACnvsJQyy51Ffex00qy014mHbej58zPfyW5CNEodmXeQOFUbjP1mWC9SuCtBI= X-Received: by 10.28.130.9 with SMTP id e9mr2764728wmd.161.1521064313612; Wed, 14 Mar 2018 14:51:53 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.109.7 with HTTP; Wed, 14 Mar 2018 14:51:53 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Wed, 14 Mar 2018 17:51:53 -0400 Message-ID: Subject: Re: [pgadmin4][Patch]: RM #3122 - Backup not working on certificate (SSL) protected servers To: Khushboo Vashi Cc: Murtuza Zabuawala , pgadmin-hackers Content-Type: multipart/alternative; boundary="001a11444b4417f64f0567666248" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --001a11444b4417f64f0567666248 Content-Type: text/plain; charset="UTF-8" Hi On Wed, Mar 14, 2018 at 10:55 AM, Khushboo Vashi < khushboo.vashi@enterprisedb.com> wrote: > Hi, > > Please find the attached updated patch. > Can you add a unit test for set_env_variables() please? > > Thanks, > Khushboo > > On Wed, Mar 14, 2018 at 1:07 PM, Khushboo Vashi < > khushboo.vashi@enterprisedb.com> wrote: > >> >> >> On Wed, Mar 14, 2018 at 12:48 PM, Murtuza Zabuawala < >> murtuza.zabuawala@enterprisedb.com> wrote: >> >>> ../pgadmin4/web/pgadmin/tools/import_export/__init__.py +310 without >>> your patch applied. >>> >>> Yes, good point. Will update and send the patch. >> >>> >>> On Wed, Mar 14, 2018 at 12:39 PM, Murtuza Zabuawala < >>> murtuza.zabuawala@enterprisedb.com> wrote: >>> >>>> Hi Khushboo, >>>> >>>> We can simplify this, we don't need to create any extra column, >>>> >>>> Check: ../pgadmin4/web/pgadmin/tools/import_export/__init__.py +322 >>>> where we are setting ENV variable we can create common utility function >>>> (let say in ../tools/utils/__init__.py) which will set all required the >>>> environment variables and then we will pass that function in p.start(..) >>>> method. >>>> >>>> >>>> -- >>>> Regards, >>>> Murtuza Zabuawala >>>> EnterpriseDB: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>>> >>>> On Wed, Mar 14, 2018 at 11:03 AM, Khushboo Vashi < >>>> khushboo.vashi@enterprisedb.com> wrote: >>>> >>>>> Hi, >>>>> >>>>> Please find the attached patch to fix RM #3122 : Backup not working on >>>>> certificate (SSL) protected servers. >>>>> >>>>> The attached patch fixes the issue in the following modules: >>>>> >>>>> 1. Backup >>>>> 2. Restore >>>>> 3. Import/Export >>>>> 4. Maintenance >>>>> >>>>> Thanks, >>>>> Khushboo >>>>> >>>>> >>>>> >>>> >>> >> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a11444b4417f64f0567666248 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi

On Wed, Mar 14, 2018 at 10:55 AM, Khushboo Vashi &l= t;khus= hboo.vashi@enterprisedb.com> wrote:
Hi,

Please find the attached u= pdated patch.

Can you add a uni= t test for set_env_variables() please?
=C2=A0

Thanks,
Khu= shboo

On Wed, Mar 14, 2018 at 1:07 PM, Kh= ushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:


On Wed, Mar 14, 20= 18 at 12:48 PM, Murtuza Zabuawala <murtuza.zabuawala@ente= rprisedb.com> wrote:
<= div dir=3D"ltr">
=C2=A0../pgadmin4/web/pg= admin/tools/import_export/__init__.py +310=C2=A0without your pa= tch applied.

<= /div>
Yes, good point. Will updat= e and send the patch.=C2=A0

On Wed, Mar 14, 2018 at 12:39 PM, Murtuza Za= buawala <murtuza.zabuawala@enterprisedb.com><= /span> wrote:
Hi Khushboo,
<= div style=3D"font-family:verdana,sans-serif;color:rgb(68,68,68)">
=
We can si= mplify this, we don't need to create any extra column,

Check: ../pgadmin4/web/pgadmin/tools/i= mport_export/__init__.py +322 where we are setting ENV variable we c= an create common utility function (let say in ../tools/utils/__init__.py) w= hich will set all required the environment variables and then we will pass = that function in p.start(..) method.


--
Regar= ds,
Murtuza Zabuawala
EnterpriseDB:=C2=A0http://www.enterp= risedb.com
The Enterprise PostgreSQL Company

=
<= /div>

On Wed, Mar 14, 2018 at 11:03 AM, Khushboo V= ashi <khushboo.vashi@enterprisedb.com> wr= ote:
Hi,

<= div>Please find the attached patch to fix RM #3122 :=C2=A0Backup not workin= g on certificate (SSL) protected servers.

The atta= ched patch fixes the issue in the following modules:

1. Backup
2. Restore
3. Import/Export
4. M= aintenance

Thanks,
Khushboo








--
=
Dave Page=
Blog: http://= pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprised= b.com
The Enterprise PostgreSQL Company
--001a11444b4417f64f0567666248--