Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1erl2A-0001li-74 for pgadmin-hackers@arkaria.postgresql.org; Fri, 02 Mar 2018 13:47:38 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1erl29-0006ay-8S for pgadmin-hackers@arkaria.postgresql.org; Fri, 02 Mar 2018 13:47:37 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1erl28-0006an-W5 for pgadmin-hackers@lists.postgresql.org; Fri, 02 Mar 2018 13:47:37 +0000 Received: from mail-wm0-x236.google.com ([2a00:1450:400c:c09::236]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1erl24-0001qd-P5 for pgadmin-hackers@postgresql.org; Fri, 02 Mar 2018 13:47:35 +0000 Received: by mail-wm0-x236.google.com with SMTP id 188so3151870wme.1 for ; Fri, 02 Mar 2018 05:47:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=rUYwZajSFdOkte51z4X5hXOLabMz6dBmrvjrxOgEw1g=; b=VKGjxzzh8zgZCir8wLhx98+16RCWv1nyvHebIr7UqPZsdV/7KZyHboN9SfUqrGddYo u9twwufvlGJk+IbQjjuR1fHr4tJCeFNc8mBEGDAk1OzUDo+JCiGj6pC6D5eFOYOeJrYV Qr+H5ZU8ZjjjNZ1a1FmRfZkHtO0lrqAwPJW33EBhQUt2Ok6Y+cXpEgm7NdfQisGX6XY8 liVMojsFVZH8vYDQDEejifQ7J/320GhLmIBRyd6XP6U3964JfcQof5RzabiGI0s+iGq3 P0QgQZpxp5QMZGOt9xxwIoxuVNm0PvmbHb9I+IzWUjGxCFUzCK89sm+Mu5PMTQKoSFV0 D0Jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=rUYwZajSFdOkte51z4X5hXOLabMz6dBmrvjrxOgEw1g=; b=AW0PmFq5Wpfx1phGMu9WiVUzF62R+RGdWh+PfGk8RmBoU1jBkXPJAxc0YTXQXiYxJh o3iMrO7wSUH1s7DG5zmMvsznj/85jE56SNF521myydNEDuhIQqGp1NqsaN9t1sbLBHM8 gftBQm18lSIWiPJ29S54/YYB+RSVDtjyWfmzzOccOS9brgvaqM+QKdJzF4AedALNCoBj iVOR77dWqQ2VfrJSlesgLLMqryfXyffmPpDuJtDvAMAowqSwUO2RfrP5DqcTyQINzVH/ vDIVRYUVfALw/APNZcHN+tA2OhGP734mpvMO2ccg7/+qW2lqGa7ilK5Ab5yb7KE2madC 9x+Q== X-Gm-Message-State: AElRT7FUYILj8SGFuZmRJ7tEbx+MX7ighavVlV9vHTCBjiPc93TtAhBB coCeaoi9ew/201vCCJRshZca6/mADD0HrzEBoz161w== X-Google-Smtp-Source: AG47ELsMpiEdk+5SdpS56NUjN/MauYnCSAJ7vXggc+lD0NwocniOA0gkjVhwNZQSB4K6zYAYAtHg20zky4gKSf3VwX0= X-Received: by 10.28.61.65 with SMTP id k62mr1226584wma.140.1519998451387; Fri, 02 Mar 2018 05:47:31 -0800 (PST) MIME-Version: 1.0 Received: by 10.28.109.7 with HTTP; Fri, 2 Mar 2018 05:47:30 -0800 (PST) In-Reply-To: References: From: Dave Page Date: Fri, 2 Mar 2018 13:47:30 +0000 Message-ID: Subject: Re: Bug #2309 fix To: Joao De Almeida Pereira Cc: Neethu Mariya Joy , pgadmin-hackers Content-Type: multipart/alternative; boundary="001a114af6cec1211b05666e3755" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --001a114af6cec1211b05666e3755 Content-Type: text/plain; charset="UTF-8" Hi Thank you both. I've committed this with a minor tweak to include a space before the { in the CSS, to match the existing formatting. Welcome to the project Neethu! On Thu, Mar 1, 2018 at 10:05 PM, Joao De Almeida Pereira < jdealmeidapereira@pivotal.io> wrote: > Hello Neethu, > > We run the patch though our test pipeline and all tests are green. > Everything looks good with this patch > > Thanks > Joao > > On Thu, Mar 1, 2018 at 10:37 AM Neethu Mariya Joy < > neethumariyajoy@gmail.com> wrote: > >> Hi, >> I am Neethu Mariya Joy, an undergraduate pursuing BE in Computer Science >> at BITS Pilani. >> >> I've attempted to fix https://redmine.postgresql.org/issues/2309. >> Codemirrors catches all the keyboard and mouse events when 'readOnly' >> option is set to 'noCursor' and does not allow copying. >> So, I've set 'readOnly' option to true. In order to hide the cursor, I've >> added a class 'hide-cursor-workaround' and applied css styles to hide the >> cursor. >> >> I'm attaching my patch as bug2309.diff below as per the contribution >> guidelines. >> >> Hope this helps. Thank you for your consideration! >> >> Sincerely, >> Neethu Mariya Joy >> GitHub | Linkedin >> >> >> >> -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a114af6cec1211b05666e3755 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi

Thank you both. I've committed t= his with a minor tweak to include a space before the { in the CSS, to match= the existing formatting.

Welcome to the project N= eethu!

On Thu,= Mar 1, 2018 at 10:05 PM, Joao De Almeida Pereira <jdealmeidape= reira@pivotal.io> wrote:
Hello Neethu,

We run the patch though our test = pipeline and all tests are green. Everything looks good with this patch

Thanks
Joao

On Thu, Mar 1, 2018 at 10:37 AM Neethu Mariya Jo= y <neethu= mariyajoy@gmail.com> wrote:
=
Hi,
I am Neethu Mariya Joy, an undergraduate purs= uing BE in Computer Science at BITS Pilani.

I'= ve attempted to fix=C2=A0https://redmine.postgresql.org/issues/2309.= Codemirrors catches all the keyboard and mouse events when 'readOnly&#= 39; option is set to 'noCursor' and does not allow copying.
So, I've set 'readOnly' option to true. In order to hide the= cursor, I've added a class 'hide-cursor-workaround' and applie= d css=C2=A0styles to hide the cursor.

I'm atta= ching my patch as bug2309.diff below as per the contribution guidelines.

Hope this helps. Thank you for your consideration!

Sincerely,
Neethu Mariya Joy
GitHub=C2=A0|=C2=A0Linkedin





--
Dave Page
Blog: = http://pgsnake.bl= ogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com<= br>The Enterprise PostgreSQL Company
--001a114af6cec1211b05666e3755--