MIME-Version: 1.0
In-Reply-To: 
 <CAFiP3vxn1oewux1O0gkvkKuciYeybq80apVtv2s10_Q0bfgq=A@mail.gmail.com>
References: 
 <CAM5-9D_P=5wEc5phxDcf41y09gnxgAU++ffxCQL9qMkkOb203w@mail.gmail.com>
 <CAM5-9D9sr70bxYvmOYdnpJdV+n+3PcEFXrUt_0dL-Mq9xtXboQ@mail.gmail.com>
 <CAM5-9D-QEO1TngHhG24ZJTxA+oQqzJo6a7PgyQaUbf-ZXR+_wQ@mail.gmail.com>
 <CAM5-9D84j2jj7nARiqsogOkXZw2oV71p+s2SamFesocVts50PQ@mail.gmail.com>
 <CAFiP3vxn1oewux1O0gkvkKuciYeybq80apVtv2s10_Q0bfgq=A@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Fri, 22 Jul 2016 16:38:36 +0100
Message-ID: 
 <CA+OCxowvg_nbkU4_a-ZqvV1EnNpSP1sM3B0YUWruY-aVojPw7w@mail.gmail.com>
Subject: Re: Re: [pgAdmin4][Patch]: RM#1293 - SQL pane is
 not displaying GRANT queries in Function, Procedure and Trigger node
To: Harshal Dhumal <harshal.dhumal@enterprisedb.com>
Cc: Surinder Kumar <surinder.kumar@enterprisedb.com>,
	pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: text/plain; charset=UTF-8
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

Thanks, applied.

On Fri, Jul 22, 2016 at 8:56 AM, Harshal Dhumal
<harshal.dhumal@enterprisedb.com> wrote:
> Hi,
>
> PFA rebased patch for RM1293 and RM1294.
>
> --
> Harshal Dhumal
> Software Engineer
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Mon, Jun 6, 2016 at 7:17 PM, Surinder Kumar
> <surinder.kumar@enterprisedb.com> wrote:
>>
>> Hi,
>>
>> Please find updated patch:
>> Issue: Code changes are not consistent with the present code in
>> functions/__init__.py, like don't rename variable func_def to func_defintion
>> until it is required.
>> Review comment given by Ashesh personally.
>>
>> Please review.
>>
>> On Fri, Jun 3, 2016 at 3:31 PM, Surinder Kumar
>> <surinder.kumar@enterprisedb.com> wrote:
>>>
>>> Hi,
>>>
>>> Please find attached patch for:
>>> 1. RM#1293 - SQL pane is not displaying GRANT queries in functions node
>>> 2. RM#1294 - Comments are not visible in sql pane for trigger functions
>>> and functions
>>>
>>> Explanation:
>>> Previously we we using 'get_defintion.sql' template to generate SQL for
>>> SQL pane for functions, procedure & trigger functions node.
>>> but GRANT statements and COMMENTS changes were missing. In order to fix
>>> that, now we have used both 'create.sql' and 'get_definition.sql' templates
>>> to generate full SQL query
>>> for SQL pane.
>>>
>>> Please review.
>>>
>>> On Thu, Jun 2, 2016 at 7:32 PM, Surinder Kumar
>>> <surinder.kumar@enterprisedb.com> wrote:
>>>>
>>>> Please ignore this patch. I will send another patch.
>>>>
>>>> On Thu, Jun 2, 2016 at 7:25 PM, Surinder Kumar
>>>> <surinder.kumar@enterprisedb.com> wrote:
>>>>>
>>>>> Hi,
>>>>>
>>>>> Please find attached patch for RM#1293.
>>>>> Add support to display GRANT privilege query in SQL Pane.
>>>>>
>>>>> Please review.
>>>>>
>>>>> Thanks,
>>>>> Surinder Kumar
>>>>
>>>>
>>>
>>
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers