Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l2FlB-0004GD-8v for pgadmin-hackers@arkaria.postgresql.org; Wed, 20 Jan 2021 15:51:06 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1l2Fkd-0006hA-KQ for pgadmin-hackers@arkaria.postgresql.org; Wed, 20 Jan 2021 15:50:31 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l2Fkc-0006h3-OO for pgadmin-hackers@lists.postgresql.org; Wed, 20 Jan 2021 15:50:31 +0000 Received: from mail-ej1-x636.google.com ([2a00:1450:4864:20::636]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1l2FkZ-0006MF-08 for pgadmin-hackers@postgresql.org; Wed, 20 Jan 2021 15:50:29 +0000 Received: by mail-ej1-x636.google.com with SMTP id l9so28486684ejx.3 for ; Wed, 20 Jan 2021 07:50:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qejchzrr80iBahr5RdcFMsv7uab+eAhn6OxVA+RbQZQ=; b=HcLSwgOmVnf8JEVHUygtrPZlM58j48D7XhY0wJxN5f/VWW3ucQaNnsxp15n2LM9wsP iM23vIBkVYel5lR1ZpnwKDYcURTQ8Aclr8BDaKiKfjFfvQYim2bP+wA5NEAQecJFxpBI 3ySO1AHwx8wymprg2Zsb+vN12GMYYUKe5BoXBvfjibD7FZ/PM8QrO842v8l0VsGDEraA +8RoANIAIDOZfB0aHJo7jguRpQEtyrrTp/6BqNy+OevN7FtrloxInckZqte0daebZTi0 GBlsItPiOxkGwki/T6NYGFb9uULbSVutGcqd2oIZQPmj+EUMvP1/cqmwNDG7q68V7Ux0 lSTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qejchzrr80iBahr5RdcFMsv7uab+eAhn6OxVA+RbQZQ=; b=mVYOhgX/1ouEQBxLcSAyE6w8Vcs1kKdHuRTJVIf9ppCo1IjbZ9cZiEoqn2rkqBImuA zVkjvBZ3nPnrGWPszkp908+BYd4y8l09aPRhzodzzLWNf5nglxPdXBdVC15t4/VyS8Ji PCjVCAty5s/SIhiCQ2ony7sgYPI9BbfnGVBcph7NCT6zQfPyYp3beaabsqGPmGkmXPTV Cve2adyfawmqn2UBJL3DqhhvEf/+LUmX5S1hNebSSGMI4v1ZP4s4H+z3BA2dAzvoS0pD kE90UjJV0GmczcWEsb7ZsFT90Y+F0UZKewprjMQAM9KZMtN/a6iwrnH9tXyxGuGbqbKQ tu9Q== X-Gm-Message-State: AOAM530kP4GqbTckDzhKD+/av5CNRcHH5qPErXn+VrzYbnrYMIDNG8zQ 9WJRbiyriirX7jwEO2te5Ep+sAbVxiIXUfZvA9r20Q== X-Google-Smtp-Source: ABdhPJwqotm/TVqO8h1z4IacF1ly1PiCn28OHaR9Gp2idHi+lsBIxt6L+k31klRvL+opinwHLc4Vzhriqp+6aPunApQ= X-Received: by 2002:a17:907:9f9:: with SMTP id ce25mr6998485ejc.352.1611157825360; Wed, 20 Jan 2021 07:50:25 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Dave Page Date: Wed, 20 Jan 2021 15:50:13 +0000 Message-ID: Subject: Re: [pgAdmin][RM1802] ERD Tool (Beta) To: Akshay Joshi Cc: Aditya Toshniwal , Khushboo Vashi , pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000dba79005b956e9bc" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000dba79005b956e9bc Content-Type: text/plain; charset="UTF-8" Hi Where's the Save Image button gone? I know Aditya was removing it whilst working on other things, but it's still required for phase 1 release. On Mon, Jan 18, 2021 at 11:45 AM Akshay Joshi wrote: > Thanks, patch applied. > > On Mon, Jan 18, 2021 at 5:08 PM Aditya Toshniwal < > aditya.toshniwal@enterprisedb.com> wrote: > >> OK, So the changes have worked. But still failing at one more place. >> Attached the patch fixes it. >> >> On Mon, Jan 18, 2021 at 4:40 PM Akshay Joshi < >> akshay.joshi@enterprisedb.com> wrote: >> >>> Thanks, patch applied. >>> >>> On Mon, Jan 18, 2021 at 2:58 PM Aditya Toshniwal < >>> aditya.toshniwal@enterprisedb.com> wrote: >>> >>>> Hi, >>>> >>>> The jasmine test cases are working fine on my local machine. The test >>>> cases are successful on jenkins other than on linux, not sure why. >>>> I have made some fixes by looking at the log. Please review and try. >>>> >>>> On Mon, Jan 18, 2021 at 1:10 PM Akshay Joshi < >>>> akshay.joshi@enterprisedb.com> wrote: >>>> >>>>> Thanks, patch applied. >>>>> >>>>> On Mon, Jan 18, 2021 at 10:34 AM Aditya Toshniwal < >>>>> aditya.toshniwal@enterprisedb.com> wrote: >>>>> >>>>>> Hi Akshay, >>>>>> >>>>>> I forgot to remove few of the dependencies which are not required as >>>>>> of now (may be in future). Attached patch removes those dependencies from >>>>>> package.json. >>>>>> >>>>>> On Sat, Jan 16, 2021 at 5:08 PM Akshay Joshi < >>>>>> akshay.joshi@enterprisedb.com> wrote: >>>>>> >>>>>>> Thanks, patch applied. >>>>>>> >>>>>>> On Fri, Jan 15, 2021 at 7:01 PM Aditya Toshniwal < >>>>>>> aditya.toshniwal@enterprisedb.com> wrote: >>>>>>> >>>>>>>> Hi, >>>>>>>> >>>>>>>> I've fixed the issues. You can find the comments inline. >>>>>>>> I've also added PropTypes for the components for increased >>>>>>>> validation. >>>>>>>> >>>>>>>> On Tue, Jan 12, 2021 at 12:18 PM Khushboo Vashi < >>>>>>>> khushboo.vashi@enterprisedb.com> wrote: >>>>>>>> >>>>>>>>> Hi Aditya, >>>>>>>>> >>>>>>>>> The functionalities and the code looks good to me, however some of the comments as below: >>>>>>>>> >>>>>>>>> >>>>>>>>> - Correct the comments at some places (3 occurrences found in /erd/__init__.py) which mention Schema diff instead of ERD. >>>>>>>>> >>>>>>>>> Some comments in the JS/JSX file regarding components/functions (For example, IconButton (forwardRef), Bodywidget etc.) would >>>>>>>>> >>>>>>>>> be great help as we all are new to React. >>>>>>>>> >>>>>>>>> Done. Added comments to the components. >>>>>>>> >>>>>>>>> >>>>>>>>> - Remove the unused imports (for ex bad_request) in /erd/__init__.py >>>>>>>>> >>>>>>>>> Removed. >>>>>>>> >>>>>>>>> >>>>>>>>> - Remove commented code >>>>>>>>> >>>>>>>>> # req_args = request.args >>>>>>>>> # if ('recreate' in req_args and >>>>>>>>> # req_args['recreate'] == '1'): >>>>>>>>> # connect = False >>>>>>>>> >>>>>>>>> Removed. >>>>>>>> >>>>>>>>> >>>>>>>>> - TableNode.jsx, below two lines can be combined. >>>>>>>>> >>>>>>>>> import { PortModelAlignment, DefaultNodeModel } from >>>>>>>>> '@projectstorm/react-diagrams'; >>>>>>>>> import { PortWidget } from '@projectstorm/react-diagrams'; >>>>>>>>> >>>>>>>>> Done. >>>>>>>> >>>>>>>>> >>>>>>>>> - onImageClick function in BodyWidget.jsx is no use I think, so it should be removed. >>>>>>>>> >>>>>>>>> I wanted to keep the code as it will be used in future. Anyway, >>>>>>>> I've removed the code. >>>>>>>> >>>>>>>>> >>>>>>>>> - I got some console errors while adding/editing tables. Refer to the attached screenshot. >>>>>>>>> >>>>>>>>> I tried but I didn't get any. Looking at the screenshot, the error >>>>>>>> is from the underlying library. Can't do much in this. >>>>>>>> >>>>>>>>> >>>>>>>>> - In the column Edit Mode, while deleting the primary key, it gives the error, which does not go away with any further modifications. >>>>>>>>> >>>>>>>>> Fixed. >>>>>>>> >>>>>>>>> >>>>>>>>> - While generating the SQL, if the server is disconnected, a proper error message should be thrown, right now some server side error is coming. >>>>>>>>> >>>>>>>>> It will show connection lost error now. Fixed. >>>>>>>> >>>>>>>>> >>>>>>>>> - Please remove ... from the menu title (New ERD Project(Beta)...) as it is not opening a dialog. >>>>>>>>> >>>>>>>>> Done. >>>>>>>> >>>>>>>>> >>>>>>>>> - For large data sets, generate ERD hangs. >>>>>>>>> >>>>>>>>> It shows the spinner and waits for the response to come from the >>>>>>>> back end. I've used the existing table fetching code which is used at other >>>>>>>> places. I'll create an RM to improve the back end code for fetching the >>>>>>>> tables data which will help the schema diff tool as well. >>>>>>>> >>>>>>>>> >>>>>>>>> - Opening the ERD panel in a new window is not working, it opens in the same tab even if you have set the Preference "Open in new browser tab" to True. >>>>>>>>> >>>>>>>>> Fixed. Added the setting in "Tab settings". >>>>>>>> >>>>>>>>> >>>>>>>>> - No shortcut is provided to open the ERD Tool. >>>>>>>>> >>>>>>>>> A shortcut is helpful if we are using it frequently. ERD tool >>>>>>>> won't be used that frequently. We already have a limited number of >>>>>>>> keys available for shortcuts. I think we should roll out without shortcut >>>>>>>> for now. If there is a user demand for it then we can think of adding it. >>>>>>>> >>>>>>>>> >>>>>>>>> - SonarQube fixes required. >>>>>>>>> >>>>>>>>> Fixed. >>>>>>>> >>>>>>>>> >>>>>>>>> - >>>>>>>>> >>>>>>>>> *Suggestion:* >>>>>>>>> >>>>>>>>> While removal of the FK link, If any of the table is selected, it is being deleted with FK link. >>>>>>>>> Either we should warn the user OR make 2 different buttons for FK removal and table removal as the user may be confused if the selected table is also removed with the FK. >>>>>>>>> >>>>>>>>> I've added a confirmation dialog which will show the number of >>>>>>>> tables and links selected. This way user will know what he has selected >>>>>>>> before deleting. >>>>>>>> >>>>>>>>> *Observations:* >>>>>>>>> >>>>>>>>> Lodash has been used in this module in place of Underscore, though >>>>>>>>> the dependency is already introduced by another module, >>>>>>>>> but we have mentioned it in the package.json file, which is >>>>>>>>> somewhat not convincing to me. >>>>>>>>> Lodash is more advanced than Underscore but we should pick anyone >>>>>>>>> as it will be easy to manage. >>>>>>>>> >>>>>>>>> TL;DR; we cannot. >>>>>>>> lodash is a peer dependency for react-diagrams (and some existing >>>>>>>> modules in pgAdmin) so it will come to package.json without choice. We >>>>>>>> cannot remove underscore because it is a dependency of backbone. Underscore >>>>>>>> is outdated, and I cannot migrate the complete pgAdmin code. So, I >>>>>>>> decided to go with 100/0 method. All the new codes will use lodash only as >>>>>>>> we'll phase out underscore with time. Just like jQuery vs ReactJS. >>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> Table dialog code is duplicate of the table node, as it was >>>>>>>>> difficult to extend it because it was attached to the tree. >>>>>>>>> So, we need to keep in mind that while implementing React in >>>>>>>>> pgAdmin, the nodes should be properly detached from the tree itself, so we >>>>>>>>> can reuse it. >>>>>>>>> >>>>>>>>> Yes. I agree. We need to separate out data source from UI going >>>>>>>> forward with React. >>>>>>>> >>>>>>>>> >>>>>>>>> Thanks, >>>>>>>>> Khushboo >>>>>>>>> >>>>>>>>> >>>>>>>>> On Mon, Dec 28, 2020 at 10:53 AM Khushboo Vashi < >>>>>>>>> khushboo.vashi@enterprisedb.com> wrote: >>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> On Fri, Dec 25, 2020 at 4:34 PM Akshay Joshi < >>>>>>>>>> akshay.joshi@enterprisedb.com> wrote: >>>>>>>>>> >>>>>>>>>>> Hi Khushboo, >>>>>>>>>>> >>>>>>>>>>> Can you please review it? >>>>>>>>>>> >>>>>>>>>>> On it. >>>>>>>>>> >>>>>>>>>>> On Fri, Dec 25, 2020 at 3:31 PM Aditya Toshniwal < >>>>>>>>>>> aditya.toshniwal@enterprisedb.com> wrote: >>>>>>>>>>> >>>>>>>>>>>> Hi Hackers, >>>>>>>>>>>> >>>>>>>>>>>> Attached patch introduces ERD Tool(Beta) to pgAdmin. Below are >>>>>>>>>>>> the details: >>>>>>>>>>>> 1) Create a diagram from scratch or generate for an existing DB. >>>>>>>>>>>> 2) Generate "Create" DDL from the diagram. >>>>>>>>>>>> 3) Save the diagram and resume it later. >>>>>>>>>>>> 4) Supports basic table fields, one-to-many relationships, >>>>>>>>>>>> many-to-many relationships, adding notes. >>>>>>>>>>>> 5) Test cases added with 75-80% test coverage. >>>>>>>>>>>> >>>>>>>>>>>> Please review. >>>>>>>>>>>> >>>>>>>>>>>> -- >>>>>>>>>>>> Thanks, >>>>>>>>>>>> Aditya Toshniwal >>>>>>>>>>>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* >>>>>>>>>>>> >>>>>>>>>>>> "Don't Complain about Heat, Plant a TREE" >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> -- >>>>>>>>>>> *Thanks & Regards* >>>>>>>>>>> *Akshay Joshi* >>>>>>>>>>> *pgAdmin Hacker | Principal Software Architect* >>>>>>>>>>> *EDB Postgres * >>>>>>>>>>> >>>>>>>>>>> *Mobile: +91 976-788-8246* >>>>>>>>>>> >>>>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Thanks, >>>>>>>> Aditya Toshniwal >>>>>>>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* >>>>>>>> >>>>>>>> "Don't Complain about Heat, Plant a TREE" >>>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> *Thanks & Regards* >>>>>>> *Akshay Joshi* >>>>>>> *pgAdmin Hacker | Principal Software Architect* >>>>>>> *EDB Postgres * >>>>>>> >>>>>>> *Mobile: +91 976-788-8246* >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Thanks, >>>>>> Aditya Toshniwal >>>>>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* >>>>>> >>>>>> "Don't Complain about Heat, Plant a TREE" >>>>>> >>>>> >>>>> >>>>> -- >>>>> *Thanks & Regards* >>>>> *Akshay Joshi* >>>>> *pgAdmin Hacker | Principal Software Architect* >>>>> *EDB Postgres * >>>>> >>>>> *Mobile: +91 976-788-8246* >>>>> >>>> >>>> >>>> -- >>>> Thanks, >>>> Aditya Toshniwal >>>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* >>>> >>>> "Don't Complain about Heat, Plant a TREE" >>>> >>> >>> >>> -- >>> *Thanks & Regards* >>> *Akshay Joshi* >>> *pgAdmin Hacker | Principal Software Architect* >>> *EDB Postgres * >>> >>> *Mobile: +91 976-788-8246* >>> >> >> >> -- >> Thanks, >> Aditya Toshniwal >> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* >> >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > *pgAdmin Hacker | Principal Software Architect* > *EDB Postgres * > > *Mobile: +91 976-788-8246* > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EDB: http://www.enterprisedb.com --000000000000dba79005b956e9bc Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi

Where's the Save Image button go= ne? I know Aditya was removing it whilst working on other things, but it= 9;s still required for phase 1 release.

On Mon, Jan 18, 2021 at 11:45 = AM Akshay Joshi <akshay= .joshi@enterprisedb.com> wrote:
Thanks, patch applied.

On Mon, Jan 1= 8, 2021 at 5:08 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com&g= t; wrote:
OK, So the changes have worked. But still failing at one more place.<= /div>
= Attached the patch fixes it.

On Mon, Jan 18, 2021 at 4:40 PM Akshay Jo= shi <= akshay.joshi@enterprisedb.com> wrote:
Thanks, patch applied.
<= br>
On Mon,= Jan 18, 2021 at 2:58 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com= > wrote:
=
Hi,

The jasmine test cases are working=C2=A0fine on my loc= al machine. The test cases are successful on jenkins other than on linux, n= ot sure why.
I have made some fixes by looking at the log. Please review an= d try.

On Mon, Jan 18, 2021 at 1:10 PM Akshay Joshi <akshay.joshi@enterpris= edb.com> wrote:
Thanks, patch applied.

On Mon, Jan 18, 2021 at 1= 0:34 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
=
Hi Ak= shay,

I forgot to remove few of the dependencies which are not require= d as of now (may be in future). Attached patch removes those dependencies f= rom package.json.

On Sat, Jan 16, 2021 at 5:08 PM Akshay Joshi <akshay.josh= i@enterprisedb.com> wrote:
Thanks, patch applied.

On Fri, Jan 15, 20= 21 at 7:01 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wr= ote:
Hi,

I've fixed the= issues. You can find the comments inline.
I've also added PropTypes for the components for increased validat= ion.

On Tue, Jan 12, 2021 at 12:18 PM Khushboo Vashi <khushboo= .vashi@enterprisedb.com> wrote:
Hi Aditya,
The functionali=
ties and the code looks good to me, however some of the comments as below:<=
/font>
  • Correct the comments at some places (3 occurrences found  in /erd/__init__.py)  which mention Sch=
ema diff instead of ERD.
Some comments in the=
 JS/JSX file regarding components/functions (For example, IconButton (forwa=
rdRef), Bodywidget etc.) would
=
be great help as we all are new to React. =
Done. Added comments to= the components.
    <=
li>Remove the unused imports (for ex bad_r=
equest) in /erd/__init__.py
=
Removed.=C2=A0
    Remove commented code
<=
font face=3D"arial, sans-serif"># req_args =3D request.args
# if ('r=
ecreate' in req_args and
# =C2=A0 =C2=A0 req_args['recreate'=
] =3D=3D '1'):
# =C2=A0 =C2=A0 connect =3D False
Removed.=C2=A0
  • TableNode.jsx, below two lines c=
an be combined.
import { = PortModelAlignment, DefaultNodeModel } from '@projectstorm/react-diagra= ms';
import { PortWidget } from '@projectstorm/react-diagrams= 9;;
Done.=C2=A0
  • onImageClick function in BodyWidget.jsx is no use I think, so it sho=
uld be removed.
I wanted to= keep the code as it will be used in future. Anyway, I've removed the c= ode.
  • I got some console errors while adding/editing tabl=
es. Refer to the attached screenshot.
I tried but I didn't get any. Looking at the screenshot, the= error is from the underlying library. Can't do much in this.=C2= =A0
  • In the column Edit Mode, while deleting the primary key, it=
 gives the error, which does not go away with any further modifications.
Fixed.=C2=A0
  • While generating the SQL, if the server is disconnected, a proper error =
message should be thrown, right now some server side error is coming.
It will show connection lost er= ror now. Fixed.=C2=A0
  • Please remove ... from the menu =
title (New ERD Project(Beta)...) as it is not opening a dialog.
    • =
Done.=C2=A0
=

  • For lar=
ge data sets, generate ERD hangs.
It shows the spinner and waits for the response to come from the bac= k end. I've used the existing table fetching code which is used at othe= r places. I'll create an RM to improve the back end code for fetching t= he tables data which will help the schema diff tool as well.
  • Opening the ERD panel in a new window is not working, it opens in th=
e same tab even if you have set the Preference "Open in new browser ta=
b" to True.
Fixed. Add= ed the setting in "Tab settings".
  • No shortcu=
t is provided to open the ERD Tool.
    • A shortcut is helpful if we are using it frequently. ERD tool won&= #39;t be used that frequently.=C2=A0We already have a limited number of = keys available for shortcuts. I think we should roll out without shortcut f= or now. If there is a user demand for it then we can think of adding it.
    • SonarQube fixes required.
    Fixed.=C2=A0
    Suggestion:=

    While removal of the FK link, If any of the table=
 is selected, it is being deleted with FK link.
    Either we should warn the=
 user OR make 2 different buttons for FK removal and table removal as the u=
ser may be confused if the selected table is also removed with the FK.
    <=
/font>
    I've added a co= nfirmation dialog which will show the number of tables and links selected. = This way user will know what he has selected before deleting.
    <=
/font>
    Observations:
    Lodash has been used in this module in place of Unde= rscore, though the dependency is already introduced by another module,
    b= ut we have mentioned it in the package.json file, which is somewhat not con= vincing to me.
    Lodash is more advanced than Underscore but we should pic= k anyone as it will be easy to manage.
    TL;DR; we cannot.
    lodash is a peer dependency for react= -diagrams (and some existing modules in pgAdmin) so it will come to package= .json without choice. We cannot remove underscore because it is a dependenc= y of backbone. Underscore is outdated, and I cannot migrate the complete pg= Admin code.=C2=A0So, I decided to go with 100/0 method. All the new code= s will use lodash only as we'll phase out underscore with time. Just li= ke jQuery vs ReactJS.


    Table dialog code is duplicate of the = table node, as it was difficult to extend it because it was attached to the= tree.
    So, we need to keep in mind that while implementing React in pgAd= min, the nodes should be properly detached from the tree itself, so we can = reuse it.
    Yes. I agree. We need = to separate out data source from UI going forward=C2=A0with React.

    Thanks,
    Khushboo


    On Mon, Dec 28, 2020 at 10:53 AM Khush= boo Vashi <khushboo.vashi@enterprisedb.com> wrote:


    On Fri, Dec 25, 2020 at 4:= 34 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
    Hi Khushboo,

    Can you plea= se review it?

    On it.=C2=A0
    = On Fri, Dec 25, 2020 at 3:31 PM Aditya Toshniwal <aditya.toshniwal@enterpris= edb.com> wrote:
    Hi Hac= kers,

    Attached patch introduces ERD Tool(Beta= ) to pgAdmin. Below are the details:
    1) Create a diagram from scratch or generate for an existing DB= .
    2) Generate "Creat= e" DDL from the diagram.
    3) Save the diagram and resume it later.
    4) Supports basic table fields, one-to-many relation= ships, many-to-many relationships, adding notes.
    5) Test cases added with 75-80% test coverage.

    Please review.

    --
    Thanks,
    Ad= itya Toshniwal
    <= /font>
    pgAdmin hacker=C2=A0| = Sr. Software Engineer | edbpostgres.com
    "Don't Complain about Heat, Plant a TREE"


    --
    Thanks & Regards
    Akshay Joshi
    = pgAdmin Hacker | Principal Software Ar= chitect
    EDB Po= stgres
    Mobile: +91 976-788-8246

    <= /div>


    --
    Thanks,
    Aditya Toshniwal=
    pgAdmin hacker=C2=A0| Sr. Software Engineer | edbpostgres.com
    &quo= t;Don't Complain about Heat, Plant a TREE"


    --
    Thank= s & Regards
    Akshay Joshi
    pgAdmin Hacker | Principal Softw= are Architect
    EDB Po= stgres
    Mobile: +91 976-788-8246



    --
    Thanks,
    Aditya Toshniwal=
    pgAdmin hacker=C2=A0| Sr. Software Engineer | edbpostgres.com
    &quo= t;Don't Complain about Heat, Plant a TREE"


    --
    Thank= s & Regards
    Akshay Joshi
    pgAdmin Hacker | Principal Softw= are Architect
    EDB Po= stgres
    Mobile: +91 976-788-8246



    --
    Thanks,
    Aditya Toshniwal=
    pgAdmin hacker=C2=A0| Sr. Software Engineer | edbpostgres.com
    &quo= t;Don't Complain about Heat, Plant a TREE"


    --
    Thank= s & Regards
    Akshay Joshi
    pgAdmin Hacker | Principal Softw= are Architect
    EDB Po= stgres
    Mobile: +91 976-788-8246



    --
    Thanks,
    Aditya Toshniwal=
    pgAdmin hacker=C2=A0| Sr. Software Engineer | edbpostgres.com
    &quo= t;Don't Complain about Heat, Plant a TREE"


    --
    Thank= s & Regards
    Akshay Joshi
    pgAdmin Hacker | Principal Softw= are Architect
    EDB Po= stgres
    Mobile: +91 976-788-8246



    --
    --000000000000dba79005b956e9bc--