Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1etur2-0007Jb-8W for pgadmin-hackers@arkaria.postgresql.org; Thu, 08 Mar 2018 12:41:04 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1etur1-0002ja-7q for pgadmin-hackers@arkaria.postgresql.org; Thu, 08 Mar 2018 12:41:03 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1etuqI-00085F-An for pgadmin-hackers@lists.postgresql.org; Thu, 08 Mar 2018 12:40:18 +0000 Received: from mail-wm0-x241.google.com ([2a00:1450:400c:c09::241]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1etuqD-0005en-R2 for pgadmin-hackers@postgresql.org; Thu, 08 Mar 2018 12:40:17 +0000 Received: by mail-wm0-x241.google.com with SMTP id s206so27163635wme.0 for ; Thu, 08 Mar 2018 04:40:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=uDBqUug5w3J00R0SAhnt1lMeU6Sv17MuKbB4cu6mzVY=; b=vuicel0qMz6kFHt/sHvYAEYlpKcTvORihsRfbPnHAwMXVf/0qVNrfFedDuHzN2zEs3 uZIgMNsa1oW9x591AFFhEhPhCbJO2XgRRUsyfvIBz/OSvHnWMrUb1hNbNlk1jFF7tTxL 5IVS4G2EICULDS4+I21lSTx2hgPrpAoW2oqpM9veN2lx2oFTTahwgX9SM9FSXNyArRbl ATO+M3EbQ3K1OmL1f8UVb47FKNuNCOFnlbeNFWhvC0cweuPtvuvIpA2wZErTaTBPvU+d YtOjOkj6bnmE1YoGxUrOtvSi7ZKLKG7JihbAWX9lre/bQa5mi7ND2c6WbEd7VSkhao8G J24w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=uDBqUug5w3J00R0SAhnt1lMeU6Sv17MuKbB4cu6mzVY=; b=kGPltkp9oikbFM+F70/UEfql6VJXhD3EEv+wX5Bowtv6s3Hj+I6Hys6e01D2IGXm7M OjjwaC1V6SQJZWL3kedY632sbwRMN9gVnWT59QJBb2KkznUayHmurNvDPp1HoFe+6UAj k52Ss821HEnmsRZ4H18x3OllI4sXizxx03cl9QgigNuKiNEjdkkozPuKM+6Qb7j6A94L FZlcB+6HamQOGpkdbnYEB3oazqxijiIGZd6h5XVRNmSfXqobfPjcZvGpa4asPHX3dTuG RJPVVIG4hiGI6KqSlDxvU1Vjz3Ahlu5gQhiBzqvAz03BWGVFms5fcVl9auQryUqSrokF VHWA== X-Gm-Message-State: AElRT7Hh51tJg1wuRNoz95sDiTPmRfDec9nuWWCmGcDb6g5vOmHShLgt l59jA5EVyajjG8dYe5D1Epg1zW3+0IUrO64OO0s2hg== X-Google-Smtp-Source: AG47ELvzeEOfgVW649KxmhMeyJu21KicjWlA41iXUZ2w5fu3jW4QXhy3kFXE9HpMGcf+FGzkaKveaEds9OIMfp03nfw= X-Received: by 10.28.167.151 with SMTP id q145mr18830427wme.64.1520512812512; Thu, 08 Mar 2018 04:40:12 -0800 (PST) MIME-Version: 1.0 Received: by 10.28.109.7 with HTTP; Thu, 8 Mar 2018 04:40:11 -0800 (PST) In-Reply-To: References: From: Dave Page Date: Thu, 8 Mar 2018 12:40:11 +0000 Message-ID: Subject: Re: [pgAdmin4][RM#2989] To fix the issue in Table node To: Murtuza Zabuawala Cc: Joao De Almeida Pereira , pgadmin-hackers Content-Type: multipart/alternative; boundary="001a114b3cd4112c6c0566e5fa24" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --001a114b3cd4112c6c0566e5fa24 Content-Type: text/plain; charset="UTF-8" Can you rebase this please? Thanks. On Thu, Mar 8, 2018 at 9:00 AM, Murtuza Zabuawala < murtuza.zabuawala@enterprisedb.com> wrote: > Hi Dave, > > Please find updated patch & updated test case to cover that as well. > > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > On Wed, Mar 7, 2018 at 9:59 PM, Dave Page wrote: > >> Hi >> >> On Wed, Mar 7, 2018 at 2:59 PM, Murtuza Zabuawala < >> murtuza.zabuawala@enterprisedb.com> wrote: >> >>> Hi Dave, >>> >>> PFA updated patch. >>> >>> >> Using your example on the ticket, I added a "character varying (32)" >> column with NOT NULL to the table. When I then edit the column, and turn >> off NOT NULL (making no other changes), the SQL generated is: >> >> ALTER TABLE public.test_drop >> ALTER COLUMN col2 TYPE character varying (32) COLLATE >> pg_catalog."default"; >> ALTER TABLE public.test_drop >> ALTER COLUMN col2 DROP NOT NULL; >> >> I didn't see that when turning off NOT NULL for col1. >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a114b3cd4112c6c0566e5fa24 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Can you rebase this please?

Thanks.

On Thu, M= ar 8, 2018 at 9:00 AM, Murtuza Zabuawala <murtuza.zabuawa= la@enterprisedb.com> wrote:
Hi Dave,

Please= find updated patch & updated test case to cover that as well.



--
Reg= ards,
Murtuza Zabuawala
EnterpriseDB:=C2=A0http://www.ent= erprisedb.com
The Enterprise PostgreSQL Company
<= /div>
<= br>

On Wed, Mar 7, 2018 at 9:59 PM, Dave Page <= dpage@pgadmin.org> wrote:
<= div dir=3D"ltr">Hi

On Wed, Mar 7, 2018 at 2:59 PM, Murtuza Zabuawala &l= t;m= urtuza.zabuawala@enterprisedb.com> wrote:
Hi Dave,

PFA updated patch.


Using your example on the ticket, I added a "character varying (32)= " column with NOT NULL to the table. When I then edit the column, and = turn off NOT NULL (making no other changes), the SQL generated is:

ALTER TABLE public.test_drop
=C2=A0 =C2=A0 = ALTER COLUMN col2 TYPE character varying (32) COLLATE pg_catalog."defa= ult";
ALTER TABLE public.test_drop
=C2=A0 =C2=A0 A= LTER COLUMN col2 DROP NOT NULL;

I didn't= see that when turning off NOT NULL for col1.

--
Dave = Page
Blog: htt= p://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: <= a href=3D"http://www.enterprisedb.com" target=3D"_blank">http://www.enterpr= isedb.com
The Enterprise PostgreSQL Company




--
Dave Page
Blog: = http://pgsnake.bl= ogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com<= br>The Enterprise PostgreSQL Company
--001a114b3cd4112c6c0566e5fa24--