Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f3LD1-000718-Ig for pgadmin-hackers@arkaria.postgresql.org; Tue, 03 Apr 2018 12:38:43 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1f3LD0-0007ee-2v for pgadmin-hackers@arkaria.postgresql.org; Tue, 03 Apr 2018 12:38:42 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f3LCz-0007eT-Ts for pgadmin-hackers@lists.postgresql.org; Tue, 03 Apr 2018 12:38:41 +0000 Received: from mail-wm0-x22a.google.com ([2a00:1450:400c:c09::22a]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1f3LCw-0006OU-AS for pgadmin-hackers@postgresql.org; Tue, 03 Apr 2018 12:38:41 +0000 Received: by mail-wm0-x22a.google.com with SMTP id i3so11112521wmf.3 for ; Tue, 03 Apr 2018 05:38:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=MOqrPxSV43PYNj8cRnKzxKCGZClnJd/n9surPG8TeSg=; b=2SgStE/P+nKorbDyBMBo+Qn+briFt66cNIXFwVIThsBAIlXsoezIMtZggLY4rmfThu VZ/s1Wi5SUaGPTcFCfJKV87ZNPZGcjqgASShy5z/i3YoqYAQHTUzViFwu1a3OguTPPis RBBBiDoLDkJblg7vzWF2/2RZuMR4DMGJQhUGyNUoSHIp5BYTmmYbQHL5bdhydJHWz1LF GHS1LoLfEdm9DPCsBgInJ64htVD+LGQhgvjpkZHACJs42kvw+ZN8sR7acXQgPoV3NUdQ DlKHhm+SzxYoIbPCHDzV6ipKGo3HM1bAsmCwpYWfjQpLg0tctb7dcYqe87bYgN3MZJBj 4AxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=MOqrPxSV43PYNj8cRnKzxKCGZClnJd/n9surPG8TeSg=; b=bbIw1BiD48NuUkSVonPdlr3drteRc704bFNKqO7BVP61NyprcfsFkGW26/sSPYkWeU WOD5Pak8X5WtYW5runbAnwXHftPYe049tWNow9V7VoBjHC3OhIswZoQIhgp1QLoRBsmV /lmJHt8cCUp1Rd2hdYYq9e1+C5jUz7oFpmCApfyP11rUeo+2NHhSEV+5hc2KLioOkR+e baDZXx7TvDnOeBHvkALFZgFfW0u4WBblEYk70MogVq/Ltnit6HrVyrhsFLIslQJuy2t5 VcnSRruGcySwM7tk9U22yD9rDjgBlyatSANp01f5m6RF/GJ2P+cbzxfAOzDcAYKXDJck KxEQ== X-Gm-Message-State: ALQs6tCd9iVVgvX+crJh6QdX07ZUcGQ3kHpHUf7N7cRlu/LkhT1lI0p4 F7ub4Ht1qV1ebN+NdSsQfei3115AYMfpdSJf+kFI7Q== X-Google-Smtp-Source: AIpwx49LcZOojGT82weluV7KpFnLnk+mWmgrVLJlJcUFThAEJJya5Wzd0RIK8fhjz9BobvfzWTaONO1+x81SUQWNj48= X-Received: by 10.28.98.69 with SMTP id w66mr4493331wmb.64.1522759117064; Tue, 03 Apr 2018 05:38:37 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.69.220 with HTTP; Tue, 3 Apr 2018 05:38:36 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Tue, 3 Apr 2018 13:38:36 +0100 Message-ID: Subject: Re: Bug #3083 fix To: Joao De Almeida Pereira Cc: Akshay Joshi , Neethu Mariya Joy , pgadmin-hackers Content-Type: multipart/alternative; boundary="001a1148e3d240687b0568f0fc45" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --001a1148e3d240687b0568f0fc45 Content-Type: text/plain; charset="UTF-8" Hi On Thu, Mar 29, 2018 at 4:29 PM, Joao De Almeida Pereira < jdealmeidapereira@pivotal.io> wrote: > Hi Dave, > That looks like in the surrounding area of the change. We run our pipeline > and everything was green. > Can you provide more details, which python version are you using? OS? > That was on my travel laptop, which is macOS Sierra with the Apple supplied Python 2.7. Interestingly, I'm on my dev laptop today (same OS and Python) and it's working just fine. The difference is that the travel machine is a 12" Macbook, whilst the dev machine is > > Thanks > Joao > > On Thu, Mar 29, 2018 at 9:03 AM Dave Page wrote: > >> Hi >> >> On Wed, Mar 28, 2018 at 7:06 PM, Joao De Almeida Pereira < >> jdealmeidapereira@pivotal.io> wrote: >> >>> Hey Akshay and Neethu >>> >>> We refactored the patch to add tests for the resize feature. We were >>> able to write test cases for the drag event by using spies and setting the >>> rect dimensions. In cases like this, we can just test some components in >>> order to have enough confidence in the code. So we isolated the function >>> that implements the behavior of this feature and tested that it was >>> performing as expected. >>> >>> We ran the patch through the pipelines and all of the tests passed. >>> >> >> I'm consistently seeing the feature test failure below with this patch >> applied: >> >> ====================================================================== >> FAIL: runTest (pgadmin.feature_tests.view_data_dml_queries. >> CheckForViewDataTest) >> Validate Insert, Update operations in View/Edit data with given test data >> ---------------------------------------------------------------------- >> Traceback (most recent call last): >> File "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/view_data_dml_queries.py", >> line 125, in runTest >> self._verify_row_data(True) >> File "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/view_data_dml_queries.py", >> line 325, in _verify_row_data >> self.assertEquals(cells[idx], config_data[str(idx)][1]) >> AssertionError: u'[null]' != u'1' >> - [null] >> + 1 >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a1148e3d240687b0568f0fc45 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi

On Thu, Mar 29, 2018 at 4:29 PM, Joao De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:
Hi Dave,
That looks like in the surrounding= area of the change. We run our pipeline and everything was green.
Can you provide more details, which python version are you using? OS?

That was on my travel laptop, whic= h is macOS Sierra with the Apple supplied Python 2.7.

<= div>Interestingly, I'm on my dev laptop today (same OS and Python) and = it's working just fine. The difference is that the travel machine is a = 12" Macbook, whilst the dev machine is=C2=A0
=C2=A0

Thanks
Joao

On Thu, Mar 29, 2018 at 9:03 AM Dave Page <dpage@pgadmin.org> w= rote:
Hi

On Wed, M= ar 28, 2018 at 7:06 PM, Joao De Almeida Pereira <jdealmeidapere= ira@pivotal.io> wrote:
Hey Akshay and Neethu

We= refactored the patch to add tests for the resize feature.=C2=A0 We were ab= le to write test cases for the drag event by using spies and setting the re= ct dimensions.=C2=A0 In cases like this, we can just test some components i= n order to have enough confidence in the code.=C2=A0 So we isolated the fun= ction that implements the behavior of this feature and tested that it was p= erforming as expected.

We ran the patch through th= e pipelines and all of the tests passed.

<= /div>
I'm consistently seeing the feature test failur= e below with this patch applied:

=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
FAIL:= runTest (pgadmin.feature_tests.view_data_dml_queries.CheckForVie= wDataTest)
Validate Insert, Update operations in View/Edit data w= ith given test data
----------------------------------------= ------------------------------
Traceback (most recent call l= ast):
=C2=A0 File "/Users/dpage/git/pgadmin4/web/pgadmi= n/feature_tests/view_data_dml_queries.py", line 125, in runTest
=C2=A0 =C2=A0 self._verify_row_data(True)
=C2=A0 File &q= uot;/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/view_data= _dml_queries.py", line 325, in _verify_row_data
=C2=A0 =C2= =A0 self.assertEquals(cells[idx], config_data[str(idx)][1])
Asser= tionError: u'[null]' !=3D u'1'
- [null]
+ 1


--
Dave Page
Blog: http://pgsnake.blogspot.com=
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterpr= ise PostgreSQL Company



--
=
Dave Page=
Blog: http://= pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprised= b.com
The Enterprise PostgreSQL Company
--001a1148e3d240687b0568f0fc45--