Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ewYbd-000282-EO for pgadmin-hackers@arkaria.postgresql.org; Thu, 15 Mar 2018 19:32:05 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1ewYbb-0004fC-FK for pgadmin-hackers@arkaria.postgresql.org; Thu, 15 Mar 2018 19:32:03 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ewYba-0004f2-Tg for pgadmin-hackers@lists.postgresql.org; Thu, 15 Mar 2018 19:32:03 +0000 Received: from mail-wm0-x242.google.com ([2a00:1450:400c:c09::242]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ewYbW-0005Uf-W5 for pgadmin-hackers@postgresql.org; Thu, 15 Mar 2018 19:32:01 +0000 Received: by mail-wm0-x242.google.com with SMTP id t6so12710768wmt.5 for ; Thu, 15 Mar 2018 12:31:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=4KshT8pWt5nitst0OLRvJA4Lye3rDnFXBe83oAKvTwc=; b=ZIw1aEPRjve7rxiTTYRgJ2NTiSrhghS7b9Ao9cLgXZ+CecQP1vevvE5PbWNHOgUdIH fuXXX5RxJPXjQIvCeGtp7pS7vX6nBim1pvompcNTeEcawSj1LHN+szzoFCbVJPaExOlu zFTae5Py5rwUuWItzKzioV9+LxHHsJ3bhxjXwAc0P8onn7Ud1jJ7jld2y9usxc78fdEV ZmvCyEOhEZLV1f4XAffCQ8+hOxEzSWgP75dBatOXHJSov3MZoD4QyC+PL1Lc05oYB8bu nqQYuUcrZIcAlgqttx8gtbNOfzTclOnbSAXDAMYzr82W56k6e48y3rHZYgyEFWYWXKpt jwuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=4KshT8pWt5nitst0OLRvJA4Lye3rDnFXBe83oAKvTwc=; b=CEIyEKNSSa5nKTKZ5NJRfQpC20guvLobhLGGYyuaZs3SOYqhEVV+WqkWuaHjTKZONd lhHHnMfd9F3+2M5//DwmifKFDJBs+5FOLzLZsbwosOEtpJV02gpJqJjDB42HRV8ncAw8 YCzO/t3Nghr+TvP8Xrf8vRa19qTwt8nV2JQMPkUj1OG9Xo1x2ORs9VZMkCC74j6EckGj f6ivrUjsotp7mCBK2EOT9dz5lID+zczZo0Dq7qQ2lUa2kNmJg+NE9ymRDOGJHQLTtG92 MAraaAfDBvl4D+mwz+O5parCUB3nspzJBlgrP9c65pvH32uxjpTIdtF37QIv+35op3S+ QD4A== X-Gm-Message-State: AElRT7GqVyMpn5Z9NKfWWbQuOeWqA6uLHFI0TWV5kX7SyyY4CbtIrLLT Z1nbl6uU817QWZQ4jOGPO6WqSK/j3gf9Pbtfcyaa1A== X-Google-Smtp-Source: AG47ELvdA7MnZELy5sdBqrS6R0vBJ//2l5TW1VKEgqhpoaGYvC2zuo1DROXXC4jzeccVgI2t3eDf1/VTyDfmwLW1E8I= X-Received: by 10.28.61.65 with SMTP id k62mr6126504wma.140.1521142317365; Thu, 15 Mar 2018 12:31:57 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.109.7 with HTTP; Thu, 15 Mar 2018 12:31:56 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Thu, 15 Mar 2018 15:31:56 -0400 Message-ID: Subject: Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn To: Murtuza Zabuawala Cc: Ashesh Vashi , pgadmin-hackers Content-Type: multipart/alternative; boundary="001a114af6ce7ad22a0567788bbb" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --001a114af6ce7ad22a0567788bbb Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Mar 15, 2018 at 12:25 PM, Murtuza Zabuawala < murtuza.zabuawala@enterprisedb.com> wrote: > Hi Dave, > > On Thu, Mar 15, 2018 at 9:42 PM, Dave Page wrote: > >> >> >> On Thu, Mar 15, 2018 at 8:30 AM, Murtuza Zabuawala < >> murtuza.zabuawala@enterprisedb.com> wrote: >> >>> On Thu, Mar 15, 2018 at 4:53 PM, Dave Page wrote: >>> >>>> Hi >>>> >>>> On Thu, Mar 15, 2018 at 7:14 AM, Ashesh Vashi < >>>> ashesh.vashi@enterprisedb.com> wrote: >>>> >>>>> Hi, >>>>> >>>>> I have just noticed, we're ignoring migrations directory too. >>>>> Should we not also check code styling for migrations directory? >>>>> >>>> >>>> Yeah, I was going to ask about that :-). Is there a specific reason wh= y >>>> we're ignoring the migrations Murtuza? >>>> >>> =E2=80=8BTo ease writing long SQL's. >>> >>> >> >> Perhaps we could just skip the long line check for those files? >> > =E2=80=8BWe have to create separate config for that and then run pycodest= yle using > that config for migration.=E2=80=8B > > =E2=80=8B1) pycodestyle --config=3D.pycodestyle > =E2=80=8B2) pycodestyle --config=3D.pycodestyle_migration > > something like that, Because I checked the documentation and I didn't fin= d > any option to have single config file for individual directories. > Urgh. I suppose we could keep a config file in the migration directory, but even then, we'll get two sets of stats out for running two tests. > > >> >>> >>>> >>>>> >>>>> -- >>>>> >>>>> Thanks & Regards, >>>>> >>>>> Ashesh Vashi >>>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company >>>>> >>>>> >>>>> >>>>> *http://www.linkedin.com/in/asheshvashi* >>>>> >>>>> >>>>> On Thu, Mar 15, 2018 at 4:40 PM, Dave Page wrote: >>>>> >>>>>> Ignore config_local.py and config_distro.py when running PEP-8 check= s. >>>>>> >>>>>> Branch >>>>>> ------ >>>>>> master >>>>>> >>>>>> Details >>>>>> ------- >>>>>> https://git.postgresql.org/gitweb?p=3Dpgadmin4.git;a=3Dcommitdif >>>>>> f;h=3D53ae960aeba0dde6109b91c171f22758b1b04ebe >>>>>> >>>>>> Modified Files >>>>>> -------------- >>>>>> web/.pycodestyle | 2 +- >>>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>>> >>>>>> >>>>> >>>> >>>> >>>> -- >>>> Dave Page >>>> Blog: http://pgsnake.blogspot.com >>>> Twitter: @pgsnake >>>> >>>> EnterpriseDB UK: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>> >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > --=20 Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a114af6ce7ad22a0567788bbb Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Thu, Mar 15, 2018 at 12:25 PM, Murtuza Zabuawala &= lt;= murtuza.zabuawala@enterprisedb.com> wrote:
Hi Dave,

On Thu, Mar 15, 2018 at 9:42 PM, Dave Pa= ge <dpage@pgadmin.org> wrote:


=
On Thu, Mar 15, 2018 at 8:30 AM, Murtuza Zabuawa= la <murtuza.zabuawala@enterprisedb.com> wrote:
On Thu, M= ar 15, 2018 at 4:53 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

On Thu, Mar 15, 2018 at 7:1= 4 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com>= wrote:
Hi,

I have just noticed, we're ignoring mi= grations directory too.
Should we not also check code styling for= migrations directory?

Yeah= , I was going to ask about that :-). Is there a specific reason why we'= re ignoring the migrations Murtuza?
=E2=80=8BTo ease writing long SQL's.
=C2=A0

Perhaps we could just skip= the long line check for those files?
<= /span>
=E2=80=8BWe have to create separate config for that and th= en run pycodestyle using that config for migration.=E2=80=8B
=C2=A0
= =E2=80=8B1) pycodestyle --config=3D.pycodestyle
=E2=80=8B2)=C2=A0pycodestyle --= config=3D.pycodestyle_migration

something like that, Because I checked th= e documentation and I didn't find any option to have single config file= for individual directories.=C2=A0

Urgh. I suppose we could keep a config file in the mi= gration directory, but even then, we'll get two sets of stats out for r= unning two tests.
=C2=A0
=C2=A0
=C2=A0

= --

Thanks & Regards,

Ashesh Vashi
Ente= rpriseDB INDIA: Enterprise PostgreSQL Company


http://www.linkedin.com/in/asheshvashi


On Thu, Mar 15, 2018 at 4:40 PM, Dave Page <= span dir=3D"ltr"><dpage@pgadmin.org> wrote:
Ignore config_local.py and config_distro.py when running= PEP-8 checks.

Branch
------
master

Details
-------
https://git.postgresql.org/gitweb?p=3Dpgadmin4.git;a=3Dcom= mitdiff;h=3D53ae960aeba0dde6109b91c171f22758b1b04ebe

Modified Files
--------------
web/.pycodestyle | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)




<= font color=3D"#888888">

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company<= br>




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

Ent= erpriseDB UK: htt= p://www.enterprisedb.com
The Enterprise PostgreSQL Company




--
Dave Page
Blog: = http://pgsnake.bl= ogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com<= br>The Enterprise PostgreSQL Company
--001a114af6ce7ad22a0567788bbb--