MIME-Version: 1.0
References: 
 <CAFSMqn-YcFFUdSApFn6-=CeGFtARRJNkZv+tGJ7ORMe7ahftEQ@mail.gmail.com>
In-Reply-To: 
 <CAFSMqn-YcFFUdSApFn6-=CeGFtARRJNkZv+tGJ7ORMe7ahftEQ@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Fri, 26 Jul 2019 13:02:56 +0100
Message-ID: 
 <CA+OCxowy7yP8SY=tLMkJ7yLwPt+n=Etww9qhzOtjLqW3EakHDA@mail.gmail.com>
Subject: Re: [GSoC] Support editing resultsets from tables with OIDs
To: Yosry Muhammad <yosrym93@gmail.com>,
 Akshay Joshi <akshay.joshi@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="0000000000006aec3a058e945379"
Precedence: bulk

--0000000000006aec3a058e945379
Content-Type: text/plain; charset="UTF-8"

Akshay; can you take a look at this and commit if appropriate please? I'm
somewhat busy at the moment :-(

On the subject of the regression test - I assume at one point the messages
window was including the command tags in it's output. This failure would
indicate we broken that. Anyone got any ideas how that happened?

On Thu, Jul 25, 2019 at 1:01 PM Yosry Muhammad <yosrym93@gmail.com> wrote:

> Hi,
> Please find a patch attached to add supporting of resultsets from tables
> with OIDs as updatable resultsets (with updated test cases and docs) - this
> is a part of a GSoC project. Please review !
> This patch also includes a small refactor of the previous patch and a
> small bug fix that occurred when the query resultset had no rows but was
> updatable (row additions were not permitted, although they should be).
>
>
> On a different note, one of the feature tests fails (on master), probably
> due to a small typo. In query_tool_tests.py this function call:
>
> self.page.find_by_xpath(
>     '//div[contains(@class, "sql-editor-message") and '
>     'contains(string(), "CREATE TABLE")]'
> )
>
> on lines 371-374 produces an exception that the element cannot be found,
> this is probably due to the fact that the message returned by the query
> executed before this call does not contain the string "CREATE TABLE". Just
> letting you know about this.
>
> Thanks and regards!
> --
>
> *Yosry Muhammad Yosry*
>
> Computer Engineering student,
> The Faculty of Engineering,
> Cairo University (2021).
> Class representative of CMP 2021.
> https://www.linkedin.com/in/yosrym93/
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--0000000000006aec3a058e945379
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Akshay; can you take a look at this and commit if appropri=
ate please? I&#39;m somewhat busy at the moment :-(<div><br></div><div>On t=
he subject of the regression test - I assume at one point the messages wind=
ow was including the command tags in it&#39;s output. This failure would in=
dicate we broken that. Anyone got any ideas how that happened?</div></div><=
br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Thu,=
 Jul 25, 2019 at 1:01 PM Yosry Muhammad &lt;<a href=3D"mailto:yosrym93@gmai=
l.com">yosrym93@gmail.com</a>&gt; wrote:<br></div><blockquote class=3D"gmai=
l_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,20=
4,204);padding-left:1ex"><div dir=3D"ltr"><div>Hi,</div><div>Please find a =
patch attached to add supporting of resultsets from tables with OIDs as upd=
atable resultsets (with updated test cases and docs) - this is a part of a =
GSoC project. Please review !</div><div>This patch also includes a small re=
factor of the previous patch and a small bug fix that occurred when the que=
ry resultset had no rows but was updatable (row additions were not permitte=
d, although they should be).<br></div><div><br></div><div><br></div><div>On=
 a different note, one of the feature tests fails (on master), probably due=
 to a small typo. In query_tool_tests.py this function call:</div><div><pre=
 style=3D"background-color:rgb(255,255,255);color:rgb(0,0,0);font-family:&q=
uot;DejaVu Sans Mono&quot;;font-size:10.5pt"><span style=3D"color:rgb(148,8=
5,141)">self</span>.page.find_by_xpath(<br>    <span style=3D"color:rgb(0,1=
28,128);font-weight:bold">&#39;//div[contains(@class, &quot;sql-editor-mess=
age&quot;) and &#39;<br></span><span style=3D"color:rgb(0,128,128);font-wei=
ght:bold">    &#39;contains(string(), &quot;CREATE TABLE&quot;)]&#39;<br></=
span>)</pre></div><div>on lines 371-374 produces an exception that the elem=
ent cannot be found, this is probably due to the fact that the message retu=
rned by the query executed before this call does not contain the string &qu=
ot;CREATE TABLE&quot;. Just letting you know about this.</div><div><br></di=
v><div>Thanks and regards!<br></div><div>--=C2=A0</div><div><br></div><div>=
<div dir=3D"ltr" class=3D"gmail-m_-6802185917449442421gmail_signature"><div=
 dir=3D"ltr"><div style=3D"text-align:left"><i><b>Yosry Muhammad Yosry</b><=
/i></div><div style=3D"text-align:left"><i><b><br></b></i></div><div style=
=3D"text-align:left">Computer Engineering student,</div><div style=3D"text-=
align:left"> The Faculty of Engineering,</div><div style=3D"text-align:left=
">Cairo University (2021).</div><div style=3D"text-align:left">Class repres=
entative of CMP 2021.<br></div><div style=3D"text-align:left"><a href=3D"ht=
tps://www.linkedin.com/in/yosrym93/" target=3D"_blank">https://www.linkedin=
.com/in/yosrym93/</a><br></div></div></div></div></div>
</blockquote></div><br clear=3D"all"><div><br></div>-- <br><div dir=3D"ltr"=
 class=3D"gmail_signature">Dave Page<br>Blog: <a href=3D"http://pgsnake.blo=
gspot.com" target=3D"_blank">http://pgsnake.blogspot.com</a><br>Twitter: @p=
gsnake<br><br>EnterpriseDB UK: <a href=3D"http://www.enterprisedb.com" targ=
et=3D"_blank">http://www.enterprisedb.com</a><br>The Enterprise PostgreSQL =
Company<br></div>

--0000000000006aec3a058e945379--