Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ce1UK-0002Xa-3I for pgadmin-hackers@arkaria.postgresql.org; Wed, 15 Feb 2017 15:27:24 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1ce1UJ-0008NT-2E for pgadmin-hackers@arkaria.postgresql.org; Wed, 15 Feb 2017 15:27:23 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ce1UI-0008LJ-9p for pgadmin-hackers@postgresql.org; Wed, 15 Feb 2017 15:27:22 +0000 Received: from mail-io0-x229.google.com ([2607:f8b0:4001:c06::229]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1ce1UE-0005WX-Vo for pgadmin-hackers@postgresql.org; Wed, 15 Feb 2017 15:27:21 +0000 Received: by mail-io0-x229.google.com with SMTP id l66so91475563ioi.1 for ; Wed, 15 Feb 2017 07:27:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=fbm1/byGBJDCjcgw/TaMb+2P22IG0+EtXtGYAPYfUu8=; b=H8grOfPbcQ7FDz669c9ZlK2u+jABY6g8cIslrDgVgJTw/edgS18yzJETFLrzpVnJKR TtC83QQsf3SUzWcZpVpLSC+BsUirXkck8zWMA4wX1V9g8MQebAQEhb9L4cVaI3T3FsaH BvHpWutuyO+9E+OJKGSU8vgt0M7VYOCaoD5qEU8zWE88XmQ4YwpKZrVKeXv9JeuJSKHN JDD3v7rdf5QpomQLRMJ3TB2ryxU7S/sAvWT6+wgAL51n2QPvMMvXGPclzdxU9g89I+11 IXbLp45Zf4JRrXg5+4YLB1bjpf03AlzIlEM5Sn/owPYZH1PYACo7mofxBq693iHJYPND l5kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=fbm1/byGBJDCjcgw/TaMb+2P22IG0+EtXtGYAPYfUu8=; b=l+TDUwyzqRmHUUfdF2taEl9PuKYt5bFySJj2ROOdiijBGG5hIx06R/py98cKS8R6vZ +T2Zw3d/i9W7FiChQteSL/SjjZ+APkOmVJWw98mp7wpt9zcUSgne7BU2eTeZQQSPeHrB pP1VULxRMTqvd4GtN44uQcyycRrH9Gi8GemXIvY0YM/Fq3k4elyZi/XPteOUSONP3sKl JmHqFLhYIAMJ2Xdsh+tORIccnqYwfjG+UXQ0CqYkiw4aCgxWJPqUMeItgyCpRELcXEav H5gymApP7xrKswvQ6MrjfiQDUSCrCSm/WieJ+CEFi90i91s2fxfZtuTDhPg7Dg7AeCxR Wk0Q== X-Gm-Message-State: AMke39l0n9BBCAl7gx57Jey54mVMFpiWSJECiC5vCOgb2N/6rNnClgaeaM3BNfvxA75GhdDPKE0O0GDUr5qEZhUr0hgdZu9ArW0T0HlveMWlNRbNYXdbNmVNT/wmYuEKZgcgMvt2qssrBkAsIGuh9oSHo0CgIog0Ahf7L9GKpuQm53Ak8pP54t7pO91qIPXcma5aby/Q6A== X-Received: by 10.107.5.137 with SMTP id 131mr34866126iof.87.1487172436838; Wed, 15 Feb 2017 07:27:16 -0800 (PST) Received: from mail-it0-f49.google.com (mail-it0-f49.google.com. [209.85.214.49]) by smtp.gmail.com with ESMTPSA id 202sm2832792ity.8.2017.02.15.07.27.15 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 15 Feb 2017 07:27:15 -0800 (PST) Received: by mail-it0-f49.google.com with SMTP id d9so25760374itc.0 for ; Wed, 15 Feb 2017 07:27:15 -0800 (PST) X-Received: by 10.36.39.78 with SMTP id g75mr9157653ita.94.1487172435487; Wed, 15 Feb 2017 07:27:15 -0800 (PST) MIME-Version: 1.0 Received: by 10.64.224.198 with HTTP; Wed, 15 Feb 2017 07:27:14 -0800 (PST) In-Reply-To: References: From: Dave Page Date: Wed, 15 Feb 2017 15:27:14 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [pgAdmin4][Patch]: RM 2089 - PARALLEL SAFE support for functions missing To: Khushboo Vashi Cc: Akshay Joshi , pgadmin-hackers Content-Type: multipart/alternative; boundary=001a1146f2b4bcca0505489350ef X-Pg-Spam-Score: -2.1 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a1146f2b4bcca0505489350ef Content-Type: text/plain; charset=UTF-8 Hi On Fri, Feb 10, 2017 at 7:28 AM, Khushboo Vashi < khushboo.vashi@enterprisedb.com> wrote: > Hi, > > Please find the attached updated patch. > > Thanks, > Khushboo > > On Fri, Feb 3, 2017 at 7:53 PM, Dave Page > wrote: > >> >> >> On Fri, Feb 3, 2017 at 1:59 PM, Khushboo Vashi < >> khushboo.vashi@enterprisedb.com> wrote: >> >>> >>> >>> On Fri, Feb 3, 2017 at 7:02 PM, Dave Page >>> wrote: >>> >>>> I doubt the order matters, but feel free to change it if it bugs you :-) >>>> >>>> >>> I have tried to create the function with both SQL commands. >>> There is no bug, its just in pgAdmin4, if its not leakproof then we >>> mentioned 'NOT LEAKPROOF' in the SQL. >>> So, I am not sure, we should remove it or not. >>> >> >> Well we should be consistent - we either list the full set of all >> options, or just the non-default ones. The main thing is that we don't >> explicitly show options that are the default in some cases, but not in >> others. >> >> > Agreed. Fixed for LEAKPROOF and PARALLEL options. > This seems to work in edit mode, but not in create mode, where the PARALLEL option that's selected is simply ignored in the msql. -- Dave Page VP, Chief Architect, Tools & Installers EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company Blog: http://pgsnake.blogspot.com Twitter: @pgsnake --001a1146f2b4bcca0505489350ef Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi

On Fri, Feb 10, 2017 at 7:28 AM, Khushboo Vashi <khushboo.= vashi@enterprisedb.com> wrote:
Hi,

Please find the attached update= d patch.

Thanks,
Khushboo

On Fri, Fe= b 3, 2017 at 7:53 PM, Dave Page <dave.page@enterprisedb.com&g= t; wrote:


On Fri, Feb 3, 2017 at 1:59 PM, Khushboo Vashi = <kh= ushboo.vashi@enterprisedb.com> wrote:


On Fri, Feb 3, 2017 at 7:02 PM, Dave Page <= ;dave.page@= enterprisedb.com> wrote:
I doubt the order matters, but feel free to change it if it bugs you :-)


I have tried to create the function wi= th both SQL commands.=C2=A0
There is no bug, its just in pgAdmin4= , if its not leakproof then we mentioned 'NOT LEAKPROOF' =C2=A0in t= he SQL.
So, I am not sure, we should remove it or not.

Well we should be cons= istent - we either list the full set of all options, or just the non-defaul= t ones. The main thing is that we don't explicitly show options that ar= e the default in some cases, but not in others.
=C2=A0
=
Agreed.=C2=A0 Fixed for LEAKPROOF and PARALLEL opt= ions.

This se= ems to work in edit mode, but not in create mode, where the PARALLEL option= that's selected is simply ignored in the msql.
=C2=A0
<= /div>--
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB= : http://www.ente= rprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.= com
Twitter: @pgsnake
--001a1146f2b4bcca0505489350ef--