Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cYD5J-0004VN-1F for pgadmin-hackers@arkaria.postgresql.org; Mon, 30 Jan 2017 14:37:33 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1cYD5I-0000Ti-I9 for pgadmin-hackers@arkaria.postgresql.org; Mon, 30 Jan 2017 14:37:32 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cYD54-0000EX-U4 for pgadmin-hackers@postgresql.org; Mon, 30 Jan 2017 14:37:19 +0000 Received: from mail-io0-x232.google.com ([2607:f8b0:4001:c06::232]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1cYD51-0002aE-0h for pgadmin-hackers@postgresql.org; Mon, 30 Jan 2017 14:37:17 +0000 Received: by mail-io0-x232.google.com with SMTP id j13so107993199iod.3 for ; Mon, 30 Jan 2017 06:37:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=AyIuYBCg9iPOzKZcliKA6Rh0JxdUjRlDRPxn4XmKFIw=; b=SpOIeDAGuc/f91t8YLNAR6+LzqCn/2RfUJqTzRi1OetS/L+X9uXHZEwUguJQAa9Elu u+gDqM8vRGqygD3YQj15OkcVs7ZFXJuLGRBl2zbmZwp+VGdfU7WzVY8UbCI27Q8S5gyX lJbHuiVuzZi0KVOKkeVvqfu6i7j6bvuOkcr59dh0Rm2iII9zHjdcXdekUFOqVeupHmTu s7TsNSqw6fubK/BONytIS0FrTA6XsyKCQ0HI7hxexuEhAy4g0LmfE+D9M2z58DymvfW3 fKfLN15YuYEL0yUcQfTpW/bC8t1f6Xf2jziqi7luq8cNCKyqXVGn77dKkLA9iEnHRZhk KS0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=AyIuYBCg9iPOzKZcliKA6Rh0JxdUjRlDRPxn4XmKFIw=; b=iJEPkUMW2h8p8QeQTuziZ6Q/HXVBDplVDavT+sOj+fxvPvSB/TVxpTTZoGHR/qTEjT dcsg2viPzkN+84UHcYjzRQ7zYMA6AsrkE5cUw3RaWNKiqn9qODt84qP8iE0hReUsRNe3 1RXsgAucTwIyYnXDiDoNXBR00km/Y8QRBFTd1H1cgFYjIfVuEsT7ExL0B5QJk/6Lkzx8 /2TEv7nVEFn/rIbCHD03ijzXbE1CcrJx144nG2/YI811FieUQyqJTnbHkNe1I5D5CPOg 8YfGjIcggjtiR/l7sXZuezfMggGfHN7Sl/fwJ4Q6DjxFkny7rBOwFEhXGLvXW7MyhUJ8 Z9Eg== X-Gm-Message-State: AIkVDXJ73QrleAiLfpC1hZl1DwY+TzldwZmH7/t+arxVbJS7C7eqJgaia0HImr5c/3ixHWMVmHoFtk4jZRIWTQ== X-Received: by 10.107.18.230 with SMTP id 99mr18119994ios.45.1485787033898; Mon, 30 Jan 2017 06:37:13 -0800 (PST) MIME-Version: 1.0 Received: by 10.64.224.198 with HTTP; Mon, 30 Jan 2017 06:37:13 -0800 (PST) In-Reply-To: References: From: Dave Page Date: Mon, 30 Jan 2017 14:37:13 +0000 Message-ID: Subject: Re: [pgAdmin4][PATCH] To fix the issue in handling of timestamp type To: Murtuza Zabuawala Cc: pgadmin-hackers Content-Type: text/plain; charset=UTF-8 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org Can you rebase this please? Thanks. On Mon, Jan 30, 2017 at 5:37 AM, Murtuza Zabuawala wrote: > Hi, > > Please find a patch to fix the issue in timestamp & time type when user > tries to provide scale/lengt to them. > I did some refactoring in code to handle it at one place, affected nodes > would be Type, Table & Column. > RM#2076 > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers