MIME-Version: 1.0
In-Reply-To: 
 <CANxoLDecb+ArijBx+cvz4fNEiWYyOcBA4mbFXk3X=wMeJGoOzQ@mail.gmail.com>
References: 
 <CANxoLDecb+ArijBx+cvz4fNEiWYyOcBA4mbFXk3X=wMeJGoOzQ@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Thu, 14 Jun 2018 08:44:18 +0100
Message-ID: 
 <CA+OCxox1t8LR7byMFmNSexxxoVhLw6n6o3AbAoSV46ci8mDPuA@mail.gmail.com>
Subject: Re: [pgadmin4][Patch]: Feature #2686 Property to switch lower/upper
 case auto completion
To: Akshay Joshi <akshay.joshi@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000627a5e056e9544c1"
Precedence: bulk

--000000000000627a5e056e9544c1
Content-Type: text/plain; charset="UTF-8"

Hi

On Thu, Jun 14, 2018 at 8:41 AM, Akshay Joshi <akshay.joshi@enterprisedb.com
> wrote:

> Hi Hackers,
>
> Attached is the patch for the Feature #2686 Property to switch lower/upper
> case auto completion. I have added new preferences settings "Keywords in
> uppercase" if it is set to True then all the keywords are shown in upper
> case in auto completion.
>
> I have also implemented the second request in the RM to change the
> selected text to upper/lower case. For that I have added new keyboard
> shortcut "Toggle case of selected text" in preferences dialog. Default
> key is "Ctrl + Shift + u".
>
> Please review it.
>

I don't see any doc updates in the patch - seems like that was forgotten?

Any opportunities to re-factor the code in that area into more testable
functions?

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--000000000000627a5e056e9544c1
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi<br><div class=3D"gmail_extra"><br><div class=3D"gmail_q=
uote">On Thu, Jun 14, 2018 at 8:41 AM, Akshay Joshi <span dir=3D"ltr">&lt;<=
a href=3D"mailto:akshay.joshi@enterprisedb.com" target=3D"_blank">akshay.jo=
shi@enterprisedb.com</a>&gt;</span> wrote:<br><blockquote class=3D"gmail_qu=
ote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex=
"><div dir=3D"ltr">Hi Hackers,<div><br></div><div>Attached is the patch for=
 the Feature=C2=A0#2686 Property to switch lower/upper case auto completion=
. I have added new preferences settings &quot;Keywords in uppercase&quot; i=
f it is set to True then all the keywords are shown in upper case in auto c=
ompletion.</div><div><br></div><div>I have also implemented the second requ=
est in the RM to change the selected text to upper/lower case. For that I h=
ave added new keyboard shortcut &quot;Toggle case of selected text&quot; in=
 preferences <span id=3D"m_1614708080903655300:2qv.1">dialog</span>. Defaul=
t key is &quot;<span id=3D"m_1614708080903655300:2qv.2">Ctrl</span> + Shift=
 + u&quot;.</div><div><br></div><div>Please review it.=C2=A0</div></div></b=
lockquote><div><br></div><div>I don&#39;t see any doc updates in the patch =
- seems like that was forgotten?</div><div><br></div><div>Any opportunities=
 to re-factor the code in that area into more testable functions?=C2=A0</di=
v></div><div><br></div>-- <br><div class=3D"gmail_signature" data-smartmail=
=3D"gmail_signature">Dave Page<br>Blog: <a href=3D"http://pgsnake.blogspot.=
com" target=3D"_blank">http://pgsnake.blogspot.com</a><br>Twitter: @pgsnake=
<br><br>EnterpriseDB UK: <a href=3D"http://www.enterprisedb.com" target=3D"=
_blank">http://www.enterprisedb.com</a><br>The Enterprise PostgreSQL Compan=
y<br></div>
</div></div>

--000000000000627a5e056e9544c1--