MIME-Version: 1.0
In-Reply-To: 
 <CAE+jjamZ94=4w+dR7bCYcPv0iQMj5bNmtpZdDCppVf2G_KNReA@mail.gmail.com>
References: 
 <CAKKotZSRSKPWzapTT6fJQiCAprRs_h644mXkeP_ba-NbynJufg@mail.gmail.com>
 <CAE+jjamZ94=4w+dR7bCYcPv0iQMj5bNmtpZdDCppVf2G_KNReA@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Wed, 7 Mar 2018 12:42:40 +0000
Message-ID: 
 <CA+OCxox3gREiVKvXSh2=OjooseZH3cveT90C97k6mH6s0AYGnA@mail.gmail.com>
Subject: Re: [pgAdmin4][RM#2989] To fix the issue in Table node
To: Joao De Almeida Pereira <jdealmeidapereira@pivotal.io>
Cc: Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>,
	pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="f403045fab6c141a290566d1e567"
Precedence: bulk

--f403045fab6c141a290566d1e567
Content-Type: text/plain; charset="UTF-8"

Hi

On Tue, Mar 6, 2018 at 4:06 PM, Joao De Almeida Pereira <
jdealmeidapereira@pivotal.io> wrote:

> Hi Murtuza,
>
> The code change works, and I passed the patches through our pipeline and
> everything is green.
> Personally I would love this bug fixes to have refactored the function
> into smaller chunk and made it more readable so that the next time someone
> need to check out a problem in the same area it is easier. I understand
> that without a good test coverage it is hard to have confidence while
> refactoring, but we need to start somewhere.
>

Are you planning to look into this Murtuza?


>
> @Hackers
> Here is a video that I saw some time ago about refactoring existing code
> and code complexity that is very interesting
> https://www.youtube.com/watch?v=8bZh5LMaSmE
> In this video Sandi Metz does the Gilded Rose Kata in a talk in RailsConf
> 2014, and with it tries to demonstrate that code can be refactored and with
> that it make the code much more simpler. But the journey is not always
> simple and the complexity will increase before it get simpler. It is a good
> example of something that we can try with our code.
>

Nice!

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--f403045fab6c141a290566d1e567
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi<br><div class=3D"gmail_extra"><br><div class=3D"gmail_q=
uote">On Tue, Mar 6, 2018 at 4:06 PM, Joao De Almeida Pereira <span dir=3D"=
ltr">&lt;<a href=3D"mailto:jdealmeidapereira@pivotal.io" target=3D"_blank">=
jdealmeidapereira@pivotal.io</a>&gt;</span> wrote:<br><blockquote class=3D"=
gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-=
left:1ex"><div dir=3D"ltr">Hi Murtuza,<div><br></div><div>The code change w=
orks, and I passed the patches through our pipeline and everything is green=
.</div><div>Personally I would love this bug fixes to have refactored the f=
unction into smaller chunk and made it more readable so that the next time =
someone need to check out a problem in the same area it is easier. I unders=
tand that without a good test coverage it is hard to have confidence while =
refactoring, but we need to start somewhere.</div></div></blockquote><div><=
br></div><div>Are you planning to look into this Murtuza?</div><div>=C2=A0<=
/div><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-le=
ft:1px #ccc solid;padding-left:1ex"><div dir=3D"ltr"><div><br></div><div>@H=
ackers</div><div>Here is a video that I saw some time ago about refactoring=
 existing code and code complexity that is very interesting</div><div><a hr=
ef=3D"https://www.youtube.com/watch?v=3D8bZh5LMaSmE" target=3D"_blank">http=
s://www.youtube.com/watch?<wbr>v=3D8bZh5LMaSmE</a><br></div><div>In this vi=
deo Sandi Metz does the Gilded Rose Kata in a talk in RailsConf 2014, and w=
ith it tries to demonstrate that code can be refactored and with that it ma=
ke the code much more simpler. But the journey is not always simple and the=
 complexity will increase before it get simpler. It is a good example of so=
mething that we can try with our code.</div></div></blockquote><div><br></d=
iv><div>Nice!=C2=A0</div></div><div><br></div>-- <br><div class=3D"gmail_si=
gnature" data-smartmail=3D"gmail_signature">Dave Page<br>Blog: <a href=3D"h=
ttp://pgsnake.blogspot.com" target=3D"_blank">http://pgsnake.blogspot.com</=
a><br>Twitter: @pgsnake<br><br>EnterpriseDB UK: <a href=3D"http://www.enter=
prisedb.com" target=3D"_blank">http://www.enterprisedb.com</a><br>The Enter=
prise PostgreSQL Company<br></div>
</div></div>

--f403045fab6c141a290566d1e567--