Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hg9I6-0006ZM-Lt for pgadmin-hackers@arkaria.postgresql.org; Wed, 26 Jun 2019 14:52:55 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hg9I5-0004kI-FF for pgadmin-hackers@arkaria.postgresql.org; Wed, 26 Jun 2019 14:52:53 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hg9I5-0004ih-2I for pgadmin-hackers@lists.postgresql.org; Wed, 26 Jun 2019 14:52:53 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hg9I2-0000Im-5W for pgadmin-hackers@postgresql.org; Wed, 26 Jun 2019 14:52:52 +0000 Received: by mail-wm1-x343.google.com with SMTP id c66so2435918wmf.0 for ; Wed, 26 Jun 2019 07:52:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KE/DNGdfv4rXzVGoTzivTksGBk5+kXtwBmSl6ao5M5M=; b=mPWw1Ukyjb41EB9NtaU7ms6hFBpOOs+Fnj/YWyGguuUPDWQAdrfviurbZUVhsOxXSn aZ8og12o3VMCSqpcQXJmq8UFJ9QUUWFzH9V6PUjETbMC6J+aGbLBhgWxma6/goL52JIe 2jSu56GV3yW/Uuqsv0VmY1rb3WyGxyDkx+fuSZ6DhTWkecyKj4rdugjHaOPY6g8KELx8 /XnvnHVoG4iIJkesyZrn64x7vMTYk5wbh3cNfc42gsuI6VVFV3Tjos0vPhNkfTMc1cZV y0WY9oAlDIOZ6+V2sIxqpu/Z2D/T+1717eLrUwcbCu0uPIf2++Jy0GaaxzK7iDgzKx9e DqSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KE/DNGdfv4rXzVGoTzivTksGBk5+kXtwBmSl6ao5M5M=; b=kPEhTO/iLzP/+CGxrVCWPx8JKAihdjQJwEiBa/1CraPDwHVpiSIQPc5D6Lbr0LAJJi TTAkgPgmQczWsl1MrnZwP8jShJ2BC8NKTh4u+PcLAIuQ5KhRKHTZLqHQunQD999+wICR e9Im7RHTliYFELNuqyhC3rPBgB3nREsyYTIeE9vpJKntrkv4ajtXqaq/Fk0dVh4ovZLZ wF0IEFU2CxjbH0+HOVMi172zxgWSBfb0+Zg5thuTH/6YsjwOJ/3ZZBfJyxs9fIvcpmOz sgPtp8eHqXoOZYjGU8/96QxMmrPaznZBjiaqyTcwBtZiL/swyLz0m1L5Pm/xYGdjgFCJ Bq3g== X-Gm-Message-State: APjAAAWwSqOH+8Uflp+XYXhqh2oz3yNjH7J31pNKcVgsFYg0YQE5l/+A EkUZ/SOwFZZ+coJya5qUO4VQxKDhV2bISijznYJP4A== X-Google-Smtp-Source: APXvYqxL1xUoJfTl+v4PkV669u9iPPs9xGuuyZkyddwDe1YluRaeUlzN0FpCx130Q2dLwZVTSWUqFK6wAYlgQ5G4s6o= X-Received: by 2002:a05:600c:20c3:: with SMTP id y3mr3138495wmm.3.1561560767454; Wed, 26 Jun 2019 07:52:47 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dave Page Date: Wed, 26 Jun 2019 10:52:35 -0400 Message-ID: Subject: Re: [pgAdmin][RM4335] Add EXPLAIN option SETTINGS and SUMMARY To: Aditya Toshniwal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000d6fb35058c3b3228" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000d6fb35058c3b3228 Content-Type: text/plain; charset="UTF-8" Hi Something isn't working correctly - I turned on the summary option, and this is the query that was run when I hit the EXPLAIN button: EXPLAIN (FORMAT JSON,ANALYZE False,VERBOSE False,COSTS False,TIMING False,SUMMARY False,BUFFERS False) select * from pg_tables Aside from the formatting (s/True/true, s/False/false, missing spaces etc), shouldn't it say SUMMARY true? I've cleared the browser and bundle caches, rebundled etc. Shouldn't there also be documentation updates? On Wed, Jun 26, 2019 at 7:59 AM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to add support for SETTINGS(v12+) and SUMMARY(v10+) > explain options. These options will be visible only if version is supported. > > I have also created and fixed RM4395. The explain options changed on one > query tool should not change explain options on other query tools or > preferences. The initial values will be taken from preferences are usual. > > Kindly review. > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --000000000000d6fb35058c3b3228 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi

Something isn't working correctl= y - I turned on the summary option, and this is the query that was run when= I hit the EXPLAIN button:

EXPLAIN (FORMAT JSON,AN= ALYZE False,VERBOSE False,COSTS False,TIMING False,SUMMARY False,BUFFERS Fa= lse) select * from pg_tables

Aside from the fo= rmatting (s/True/true, s/False/false, missing spaces etc), shouldn't it= say SUMMARY true? I've cleared the browser and bundle caches, rebundle= d etc.

Shouldn't there also be documentation u= pdates?

On Wed, Jun 26, 2019 at 7:59 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb= .com> wrote:
Hi Hackers,

Attached is the patch to add support for SE= TTINGS(v12+) and SUMMARY(v10+) explain options. These options will be visib= le only if version is supported.

I have also created and fixed RM4395.= The explain options changed on one query tool should not change explain op= tions on other query tools or preferences. The initial values will be taken= from preferences are usual.

Kindly review.

-- <= br>
<= div dir=3D"ltr">
Thanks and Regards,=
Aditya Toshniwal<= /div>
Software Engineer |= =C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Complain about Heat, Plant a TREE&quo= t;


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @p= gsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL = Company
--000000000000d6fb35058c3b3228--