Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1evoxq-0007Fq-4n for pgadmin-hackers@arkaria.postgresql.org; Tue, 13 Mar 2018 18:47:58 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1evoxo-0005yg-UZ for pgadmin-hackers@arkaria.postgresql.org; Tue, 13 Mar 2018 18:47:56 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1evoxo-0005yW-3x for pgadmin-hackers@lists.postgresql.org; Tue, 13 Mar 2018 18:47:56 +0000 Received: from mail-wr0-x242.google.com ([2a00:1450:400c:c0c::242]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1evoxk-000874-2R for pgadmin-hackers@postgresql.org; Tue, 13 Mar 2018 18:47:54 +0000 Received: by mail-wr0-x242.google.com with SMTP id f14so1783296wre.8 for ; Tue, 13 Mar 2018 11:47:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=5+XaBcAMgk1hQSZMdFZmy5Nh28w1I7jnFTZ4+lO5Aik=; b=UDfL/qXKonAR3sFqD1tppfXvxLxplqvz9e1VE+ZJZQ6cVGEaJsFqLoWF739rT+Ufwa 3Sb/Qyg5O5xHIojVRpRrPib9tX3QJog53VppRxEfqtnQT/x9d0P//qVyKOhMxYpI/2J+ xM4C06D4+WW5MFrK+kNbyXKgvHWdWij4crwWSUBHhLjNSljMdLGSuVfSUGrDyL4XWXu4 58w1Buu/Zcuz5g2whLPfnxp+8j0DTlZ2u1zbk87urFcGIkYfyNLUZ/+9c76pwMTYA4nY HAA3wdRNZ/U+Mxlrkx/rlVEiOE81Lc/trpjeD2Ao5uRR3lSGnByH5/W+HNVpVBFFvt4A ApIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=5+XaBcAMgk1hQSZMdFZmy5Nh28w1I7jnFTZ4+lO5Aik=; b=G0gAfHwEcXl9uxs9GxIlemo1LIQ4Kt2s3sDuYdb4sgZpMeJeBkYdc7guDvdmgz0ZO+ 7T0DW2kytXk4utXXgt6gTwRHXhdJDn1+TVCTZSwileU+r3A0aqAZzjAJbNVROL3jYrnI wDePjpZ1yB8xV2yIe/jZ2avAgxLx3HlbYFOjxYKM1ssFWkmYZ2yNFzl7TQCUmG4IMnSh 4xkg54PD8MIdR31/yVF3zvdBZYBh17kXwM2VW351/UIKBEr5wziEKG2dQ04DUv35kvFm V00tsRpIpCeYLZ7mpcFScCq8hwAot81MZPjUXiuXGl+hCh/YqAr5ti6tuDxq4tszG0KQ UoSQ== X-Gm-Message-State: AElRT7Hm0xtnrjF8AQNNvIw82Qb6TAdywEr9CmJImyuUCEhRJO5Hbbzq uEmqtD/Dr3M7k9sbyh1g+MNJFm53S6PqC+ADcXWzgg== X-Google-Smtp-Source: AG47ELvHqvnz4du52EAw6v8xB0GmMgWWTjXBNOcRgu6kg9sH1uLmK60rcFIkTLlUWB5S1CX7QR8UUS4RdVVtjzf5nP8= X-Received: by 10.223.129.80 with SMTP id 74mr1400103wrm.190.1520966870499; Tue, 13 Mar 2018 11:47:50 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.109.7 with HTTP; Tue, 13 Mar 2018 11:47:49 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Tue, 13 Mar 2018 14:47:49 -0400 Message-ID: Subject: Re: [pgAdmin4][RM#3140] Add service parameter To: Victoria Henry Cc: Joao De Almeida Pereira , Murtuza Zabuawala , pgadmin-hackers Content-Type: multipart/alternative; boundary="94eb2c05f2e40835cd05674fb2af" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --94eb2c05f2e40835cd05674fb2af Content-Type: text/plain; charset="UTF-8" Thanks, patches applied! On Tue, Mar 13, 2018 at 9:53 AM, Victoria Henry wrote: > Hi Dave, > > We've made updated our previous patch to fix the error messages. Attached > are our updated patches. > > On Mon, Mar 12, 2018 at 8:48 PM, Dave Page wrote: > >> Hi >> >> On Mon, Mar 12, 2018 at 5:18 PM, Joao De Almeida Pereira < >> jdealmeidapereira@pivotal.io> wrote: >> >>> Hi Dave and Murtuza, >>> >>> Regarding this patch we refactored the Javascript code so that is lives >>> in a different file and added some tests. >>> >>> Also we found an issue with karma-jasmine that does not allow us to use >>> jasmine 3.1 yet. You can find attached a patch that reverts that commit. >>> >> >> Sounds good, but neither patch will apply (in fact, the Jasmine one looks >> entirely backwards). One of the error messages was changed in Murtuza's >> patch, and wasn't reflected in your update for example. >> >> Can you rebase please? >> >> Thanks. >> >> >>> >>> Thanks >>> Victoria && Joao >>> >>> On Mon, Mar 12, 2018 at 4:46 PM Dave Page wrote: >>> >>>> Thanks, patch applied! >>>> >>>> On Mon, Mar 12, 2018 at 3:31 AM, Murtuza Zabuawala < >>>> murtuza.zabuawala@enterprisedb.com> wrote: >>>> >>>>> Hi Dave, >>>>> >>>>> PFA updated patch. >>>>> >>>>> -- >>>>> Regards, >>>>> Murtuza Zabuawala >>>>> EnterpriseDB: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>>> >>>>> On Fri, Mar 9, 2018 at 9:29 PM, Murtuza Zabuawala < >>>>> murtuza.zabuawala@enterprisedb.com> wrote: >>>>> >>>>>> Hi Dave, >>>>>> >>>>>> I'll change the name and send you updated patch. >>>>>> >>>>>> >>>>>> On Fri, Mar 9, 2018 at 9:25 PM, Dave Page wrote: >>>>>> >>>>>>> HI >>>>>>> >>>>>>> On Fri, Mar 9, 2018 at 11:47 AM, Murtuza Zabuawala < >>>>>>> murtuza.zabuawala@enterprisedb.com> wrote: >>>>>>> >>>>>>>> Hi, >>>>>>>> >>>>>>>> PFA patch to add service parameter in server dialog. >>>>>>>> - Docs updated >>>>>>>> - Test case added for Service ID parameter >>>>>>>> >>>>>>>> Please note, >>>>>>>> I have extracted Connection class and Server manager class from our >>>>>>>> own custom Psycopg2 driver module. >>>>>>>> >>>>>>>> Patch also covers RM#3120 >>>>>>>> >>>>>>> >>>>>>> This patch seems a little confused. The "Service" and "Service ID" >>>>>>> fields from pgAdmin 3 are very different things. The Redmine ticket seems >>>>>>> to be asking for the Service field (the pg_service.conf service name), >>>>>>> *not* Service ID (the operating system's service ID, used to start/stop the >>>>>>> database server service). >>>>>>> >>>>>>> -- >>>>>>> Dave Page >>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>> Twitter: @pgsnake >>>>>>> >>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>> The Enterprise PostgreSQL Company >>>>>>> >>>>>> >>>>>> >>>>> >>>> >>>> >>>> -- >>>> Dave Page >>>> Blog: http://pgsnake.blogspot.com >>>> Twitter: @pgsnake >>>> >>>> EnterpriseDB UK: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --94eb2c05f2e40835cd05674fb2af Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patches applied!
<= br>
On Tue, Mar 13, 2018 at 9:53 AM, Victoria Hen= ry <vhenry@pivotal.io> wrote:
Hi Dave,

We've made updated our= previous patch to fix the error messages.=C2=A0 Attached are our updated p= atches.

On Mon, Mar 12, 2018 at 8:48 PM, = Dave Page <dpage@pgadmin.org> wrote:
Hi

On Mon, Mar 12, 2018 at 5:18 PM, Joao De Almeida Per= eira <jdealmeidapereira@pivotal.io> wrote:
Hi Dave and Murtuza,

<= /div>
Regarding this patch we refactored the Javascript code so that is= lives in a different file and added some tests.

A= lso we found an issue with karma-jasmine that does not allow us to use jasm= ine 3.1 yet. You can find attached a patch that reverts that commit.
<= /div>

Sounds good, but neither patch= will apply (in fact, the Jasmine one looks entirely backwards). One of the= error messages was changed in Murtuza's patch, and wasn't reflecte= d in your update for example.

Can you rebase pleas= e?

Thanks.
=C2=A0
=

Thanks
Victoria && Joao

On Mon, Mar 12, 2018 at 4:46 PM Dave Page &l= t;dpage@pgadmin.org<= /a>> wrote:

On Mon, Mar 12, 2018 at 3:31 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Dave,

PFA updated patch.

--
Regards,
Murtuza Zabuawala
EnterpriseDB:=C2=A0h= ttp://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Fri, Mar 9, 2018 at 9:29 PM, Murtuza Zabu= awala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Dave,

I'll change the name and s= end you updated patch.


On Fri, Mar 9, 2018 at 9:25 PM, Dave Page <= dpage@pgadmin.org> wrote:
<= div dir=3D"ltr">HI

On Fri, Mar 9, 2018 at 11:47 AM, Murtuza Zabuawala &= lt;= murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA patch to add=C2=A0service parameter in se= rver dialog.
- Docs updated
- Test case added for Service ID parameter

Please note,
I have= extracted Connection class and Server manager class from our own custom Ps= ycopg2 driver module.

Patch also covers RM#3120
<= br>
=C2=A0This patch seems a little confused. The "Service&q= uot; and "Service ID" fields from pgAdmin 3 are very different th= ings. The Redmine ticket seems to be asking for the Service field (the pg_s= ervice.conf service name), *not* Service ID (the operating system's ser= vice ID, used to start/stop the database server service).

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twi= tter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise Pos= tgreSQL Company





--
Dave Page=
Blog: http://= pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprised= b.com
The Enterprise PostgreSQL Company
=


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

Enterprise= DB UK: http://www= .enterprisedb.com
The Enterprise PostgreSQL Company




--
=
Dave Page=
Blog: http://= pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprised= b.com
The Enterprise PostgreSQL Company
--94eb2c05f2e40835cd05674fb2af--