Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d81bW-0004wd-Lb for pgadmin-hackers@arkaria.postgresql.org; Tue, 09 May 2017 09:38:50 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1d81bW-0003e6-8F for pgadmin-hackers@arkaria.postgresql.org; Tue, 09 May 2017 09:38:50 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1d81bV-0003dt-7z for pgadmin-hackers@postgresql.org; Tue, 09 May 2017 09:38:49 +0000 Received: from mail-io0-x230.google.com ([2607:f8b0:4001:c06::230]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1d81bR-0000ao-UD for pgadmin-hackers@postgresql.org; Tue, 09 May 2017 09:38:47 +0000 Received: by mail-io0-x230.google.com with SMTP id k91so66468952ioi.1 for ; Tue, 09 May 2017 02:38:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=ee9umgwf8XzPG1f4GHzbGc03ONb8fLwwuiqE3pmPF9Q=; b=GRa4tb3Gf4ATai8fKpyMDGKvHKUCvlMDSdh8wBXeLhjIHGs4bpygxZ6Ag0c7/E0+cy q1vBn69/YisK3kvrLU9zkzwq9dy8u1ArHq8CHYSxqFg7uFogxipr/ay2OsNB0MiREHB3 NdQsphfX+4WOGXlWukawg0ox1jd2pXHfgIAgwORVyal/eyAB+A4Jr/mupZkOMR19Pxg+ 7Q1TldS6LkoQ9lnKJJc8x2yQR2728dPgOvxkQSPl3zn1U+B3KlxL0hYCXEBcjMk8fbic E4++d6cH97Y6dw3qI7jWa7+zaFgTCXlGFisCHTh7YrRgC/e52C8Enb//faFb03Z5EEWi EsWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=ee9umgwf8XzPG1f4GHzbGc03ONb8fLwwuiqE3pmPF9Q=; b=rKwV7ueS5JtqUIipVo/lNSozRphcNZ58Fcv9B6BADtGott5kej/FG/gINrx5BURvr3 wkHLK1egJ4aEz3H8U8CvrA69iqyqT58gomtkFCUozGaFGHxQ2AAFrLhKlyNTZRbTaIlF pq+M8ReRsFD9zPnsw0WUt6Zei3fJmFN+nnBbE/y7jwkq3rrPY9asud6+TUaU3a8hQKnE JUpo0eyjT/9t9hKZu3OCpyIzFZltEMHgdnfb7VOgrI4QCGIclXFMnJCayOvZj9Zsasjh BzkoYSWdWGGIU7ywGNt5RMevicN5+hKQM1iLUwxj9lF5vX8tbU8cP3a9d6rThrBww2sA YTUg== X-Gm-Message-State: AODbwcAqUj2IbpPxTEM6H+AJh3NDp/X+uTAxYK+ewOze6bIYBtpn8AWm 7awnyyhzd5gzQUptfIm/N8OLImVU55PaoO3OHGtIk+6BbpT2TJrsULl7vGukLYxNDG0mLXlQE5O OoZJcWWDO753YZ85B9sODdKGiTWNi2Ik78njwCSyVa8h7KMbAWvHF9jlZAE5SNu2xsEMotbsm X-Received: by 10.107.35.20 with SMTP id j20mr998306ioj.35.1494322724839; Tue, 09 May 2017 02:38:44 -0700 (PDT) Received: from mail-it0-f53.google.com (mail-it0-f53.google.com. [209.85.214.53]) by smtp.gmail.com with ESMTPSA id 123sm17178671iow.28.2017.05.09.02.38.43 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 May 2017 02:38:44 -0700 (PDT) Received: by mail-it0-f53.google.com with SMTP id g126so5531882ith.0 for ; Tue, 09 May 2017 02:38:43 -0700 (PDT) X-Received: by 10.36.31.200 with SMTP id d191mr23028814itd.85.1494322723735; Tue, 09 May 2017 02:38:43 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.174.167 with HTTP; Tue, 9 May 2017 02:38:43 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Tue, 9 May 2017 10:38:43 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [pgAdmin4][runtime]: RM #2328 - Unable to launch query tool and debugger in new browser tab To: Neel Patel Cc: Akshay Joshi , pgadmin-hackers Content-Type: multipart/alternative; boundary=001a11446e8620e620054f141fc7 X-Pg-Spam-Score: -2.1 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a11446e8620e620054f141fc7 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi On Tue, May 9, 2017 at 10:28 AM, Neel Patel wrote: > Hi Dave, > > Here there are 2 compilation issue. We have fixed 'QNetworkCookieJar' > related compilation error in Qt4. BUT > > Below compilation error is coming because we have not applied the latest > patch of webkit which was fixed in annulen/webkit repo which was raised a= t > below path. > > https://github.com/annulen/webkit/issues/519 > > BrowserWindow.cpp:842:59: error: =E2=80=98RequestClose=E2=80=99 is not a = member of > =E2=80=98QWebPage=E2=80=99 > webviewPtr->page()->triggerAction(QWebPage:: > RequestClose); > > To fix the above compilation error currently we have two solution. > > - Apply the given patch in webkit ( qwebpage.cpp & qwebpage.h file ) . > - Comment the below line temporary for compilation until we get the > releases from annulen/webkit. > > webviewPtr->page()->triggerAction(QWebPage::RequestClose); > > Other compilation issues, (Me and Akshay) will fix and commit it but need > your input on above issue. > For various reasons we need to retain compatibility with the previous versions of qtwebkit. Can we detect at build time what version we have, and enable/disable that code as appropriate? > > Thanks, > Neel Patel > > On Tue, May 9, 2017 at 2:02 PM, Dave Page > wrote: > >> It's running CentOS 7.3, with packages from EPEL: >> >> [dpage@jenkins ~]$ rpm -qa |grep qt >> qt5-qtbase-common-5.6.1-10.el7.noarch >> qt5-qtbase-devel-5.6.1-10.el7.x86_64 >> qt-4.8.5-13.el7.x86_64 >> qt5-qtbase-5.6.1-10.el7.x86_64 >> qt5-qtxmlpatterns-5.6.1-10.el7.x86_64 >> qt5-qtwebchannel-5.6.1-10.el7.x86_64 >> qt5-qtwebkit-5.6.1-3.b889f46git.el7.x86_64 >> qt5-qtdeclarative-devel-5.6.1-10.el7.x86_64 >> qt-devel-4.8.5-13.el7.x86_64 >> qt-settings-19-23.5.el7.centos.noarch >> qt5-qtbase-gui-5.6.1-10.el7.x86_64 >> qt5-qtlocation-5.6.1-10.el7.x86_64 >> qt5-qtwebsockets-5.6.1-10.el7.x86_64 >> qt5-qtwebkit-devel-5.6.1-3.b889f46git.el7.x86_64 >> qtwebkit-2.3.4-6.el7.x86_64 >> qt3-3.3.8b-51.el7.x86_64 >> qt5-qtdeclarative-5.6.1-10.el7.x86_64 >> qt5-rpm-macros-5.6.1-10.el7.noarch >> qtwebkit-devel-2.3.4-6.el7.x86_64 >> qt-x11-4.8.5-13.el7.x86_64 >> qt5-qtsensors-5.6.1-10.el7.x86_64 >> >> On Tue, May 9, 2017 at 9:28 AM, Neel Patel >> wrote: >> >>> Hi Dave, >>> >>> Yes, It looks like compilation fails on Qt4. We will fix this issue but >>> which version of Qt4 we are using in Jenkins ? >>> >>> Thanks, >>> Neel Patel >>> >>> On Tue, May 9, 2017 at 1:56 PM, Dave Page >>> wrote: >>> >>>> >>>> >>>> On Tue, May 9, 2017 at 9:18 AM, Akshay Joshi < >>>> akshay.joshi@enterprisedb.com> wrote: >>>> >>>>> Hi >>>>> >>>>> On Tue, May 9, 2017 at 1:42 PM, Dave Page >>>>> wrote: >>>>> >>>>>> This appears to have made Jenkins get all angry and red :-( >>>>>> >>>>>> https://jenkins.pgadmin.org/ >>>>>> >>>>> >>>>> We(Neel and I) have tested it and working fine. >>>>> >>>> >>>> It clearly doesn't compile on QT4. Please review the Jenkins logs. >>>> >>>> >>>>> >>>>>> >>>>>> On Tue, May 9, 2017 at 8:39 AM, Akshay Joshi < >>>>>> akshay.joshi@enterprisedb.com> wrote: >>>>>> >>>>>>> Thanks patch applied. >>>>>>> >>>>>>> On Mon, May 8, 2017 at 3:21 PM, Dave Page wrote= : >>>>>>> >>>>>>>> Akshay, could you review this please? >>>>>>>> >>>>>>>> Thanks. >>>>>>>> >>>>>>>> On Fri, May 5, 2017 at 11:53 AM, Neel Patel < >>>>>>>> neel.patel@enterprisedb.com> wrote: >>>>>>>> >>>>>>>>> Hi, >>>>>>>>> >>>>>>>>> Please find attached patch file with the fix of RM #2328 - >>>>>>>>> [Runtime]: Unable to launch query tool and debugger in new browse= r tab. >>>>>>>>> >>>>>>>>> I have used Qt 5.8 with webkit mentioned in below URL. >>>>>>>>> >>>>>>>>> https://github.com/annulen/webkit/releases >>>>>>>>> >>>>>>>>> >>>>>>>>> As there was a bug in QWebKit regarding "unload" event. We have >>>>>>>>> raised and also they have provided patch file to fix this issue. = I have >>>>>>>>> applied the patch in linux and compile the webkit and tested the = attached >>>>>>>>> patch with compiled webkit which is now working fine. >>>>>>>>> >>>>>>>>> Below is the link for reference regarding unload issue. They have >>>>>>>>> provided test webkit release for Mac in below URL but for other p= latform we >>>>>>>>> need to apply the patch and compile the webkit until they provide >>>>>>>>> webkit-releases for all platforms. >>>>>>>>> >>>>>>>>> https://github.com/annulen/webkit/issues/519 >>>>>>>>> >>>>>>>>> Do review it and let me know in case of any issue. >>>>>>>>> >>>>>>>>> Thanks, >>>>>>>>> Neel Patel >>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> Sent via pgadmin-hackers mailing list ( >>>>>>>>> pgadmin-hackers@postgresql.org) >>>>>>>>> To make changes to your subscription: >>>>>>>>> http://www.postgresql.org/mailpref/pgadmin-hackers >>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Dave Page >>>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>>> Twitter: @pgsnake >>>>>>>> >>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>>> The Enterprise PostgreSQL Company >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> *Akshay Joshi* >>>>>>> *Principal Software Engineer * >>>>>>> >>>>>>> >>>>>>> >>>>>>> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 >>>>>>> 976-788-8246 <+91%2097678%2088246>* >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Dave Page >>>>>> VP, Chief Architect, Tools & Installers >>>>>> EnterpriseDB: http://www.enterprisedb.com >>>>>> The Enterprise PostgreSQL Company >>>>>> >>>>>> Blog: http://pgsnake.blogspot.com >>>>>> Twitter: @pgsnake >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> *Akshay Joshi* >>>>> *Principal Software Engineer * >>>>> >>>>> >>>>> >>>>> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 >>>>> 976-788-8246 <+91%2097678%2088246>* >>>>> >>>> >>>> >>>> >>>> -- >>>> Dave Page >>>> VP, Chief Architect, Tools & Installers >>>> EnterpriseDB: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>>> Blog: http://pgsnake.blogspot.com >>>> Twitter: @pgsnake >>>> >>> >>> >> >> >> -- >> Dave Page >> VP, Chief Architect, Tools & Installers >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> > > --=20 Dave Page VP, Chief Architect, Tools & Installers EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company Blog: http://pgsnake.blogspot.com Twitter: @pgsnake --001a11446e8620e620054f141fc7 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi

On Tue, May 9, 2017 at 10:28 AM, Neel Patel <neel.patel@en= terprisedb.com> wrote:
Hi Dave,

Here there are 2 compilation issue= . We have fixed 'QNetworkCookieJar' related compilation error in Qt= 4. BUT

Below compilation error is coming because w= e have not applied the latest patch of webkit which was fixed in annulen/we= bkit repo which was raised at below path.


BrowserWindow.cpp:842:59: error: =E2=80=98RequestClose=E2=80=99 is not a = member of =E2=80=98QWebPage=E2=80=99
=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0webviewPtr-&g= t;page()->triggerAction(QWebPage::RequestClose);

To fix the above compilation error currently we have two = solution.
  • Apply the given patch in webkit ( qwebpage.cpp = & qwebpage.h file ) .
  • Comment the below line temporary for comp= ilation until we get the releases from annulen/webkit.
=C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0webviewPtr->page()->= triggerAction(QWebPage::RequestClose);

Other compilation issues, (Me and Akshay) will fix and commit it b= ut need your input on above issue.

<= div>For various reasons we need to retain compatibility with the previous v= ersions of qtwebkit. Can we detect at build time what version we have, and = enable/disable that code as appropriate?
=C2=A0

Thanks,
N= eel Patel

On Tue, May 9, 2017 at 2:02 PM,= Dave Page <dave.page@enterprisedb.com> wrote:
<= blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px= #ccc solid;padding-left:1ex">
It's running CentOS 7.3,= with packages from EPEL:

[dpage@jenkins ~]$ rpm -q= a |grep qt
qt5-qtbase-common-5.6.1-10.el7.noarch
q= t5-qtbase-devel-5.6.1-10.el7.x86_64
qt-4.8.5-13.el7.x86_64
qt5-qtbase-5.6.1-10.el7.x86_64
qt5-qtxmlpatterns-5.6.1-1= 0.el7.x86_64
qt5-qtwebchannel-5.6.1-10.el7.x86_64
=
qt5-qtwebkit-5.6.1-3.b889f46git.el7.x86_64
qt5-qtdeclar= ative-devel-5.6.1-10.el7.x86_64
qt-devel-4.8.5-13.el7.x86_64=
qt-settings-19-23.5.el7.centos.noarch
qt5-qtbase-= gui-5.6.1-10.el7.x86_64
qt5-qtlocation-5.6.1-10.el7.x86= _64
qt5-qtwebsockets-5.6.1-10.el7.x86_64
qt5-qtweb= kit-devel-5.6.1-3.b889f46git.el7.x86_64
qtwebkit-2.3.4-6.el7= .x86_64
qt3-3.3.8b-51.el7.x86_64
qt5-qtdeclarative-5.6.= 1-10.el7.x86_64
qtwebkit-devel-= 2.3.4-6.el7.x86_64
qt-x11-4.8.5-13.el7.x86_64
qt5-= qtsensors-5.6.1-10.el7.x86_64

On Tue, May 9, 2017 at 9:28 AM, N= eel Patel <neel.patel@enterprisedb.com> wrote:
=
Hi Dave,

Yes, It looks like compilation fails on Qt4. We will fix this issue but wh= ich version of Qt4 we are using in Jenkins ?

Thank= s,
Neel Patel

On Tue= , May 9, 2017 at 1:56 PM, Dave Page <dave.page@enterprisedb.com> wrote:

On Tue, Ma= y 9, 2017 at 9:18 AM, Akshay Joshi <akshay.joshi@enterprisedb.= com> wrote:
Hi

= On Tue, May 9, 2017 at 1:42 PM, Dave Page <dave.page@enterprisedb= .com> wrote:
This appear= s to have made Jenkins get all angry and red :-(


=C2=A0 =C2=A0W= e(Neel and I) have tested it and working fine.=C2=A0=C2=A0

It clearly doesn't compi= le on QT4. Please review the Jenkins logs.
=C2=A0

=

On Tue, May 9, 2017 at 8:39 AM, Akshay Joshi = <aksh= ay.joshi@enterprisedb.com> wrote:
=
Thanks patch applied.

On Mon, May 8, 2017 at 3:21 PM, Dave Pag= e <dpage@pgadmin.org> wrote:
Akshay, could you review this please?

Thanks.

On Fri, May 5, 2017 at 11:53 AM, Neel Patel <= neel.patel@enterprisedb.com> wrote:
Hi,

Please find attached patch file with the fix of RM #2328 - [Runtime]: Unab= le to launch query tool and debugger in new browser tab.

I have used Qt 5.8 with webkit menti= oned in below URL.

https://github.com/annulen/webkit/releases


As there was a bug in QWebKit r= egarding "unload" event. We have raised and also they have provid= ed patch file to fix this issue. I have applied the patch in linux and comp= ile the webkit and tested the attached patch with compiled webkit which is = now working fine.

Below is the link for reference regarding unload issu= e. They have provided test webkit release for Mac in below URL but for othe= r platform we need to apply the patch and compile the webkit until they pro= vide webkit-releases for all platforms.

Do review it and let me know in cas= e of any issue.

Thanks,
Neel= Patel


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-ha= ckers




--
Dave Page
Blog: http://pgsnake.blogspot.com=
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterpr= ise PostgreSQL Company



--
Aksha= y Joshi
Principal Software Engineer=C2=A0





--
Dave Page
VP, Chief Ar= chitect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Ente= rprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake=



--
Akshay Joshi
Principal Software Engineer=C2= =A0


=
Pho= ne: +91 20-3058-9517
Mobile: +91 976-788-8246<= /b>



<= /div>--
Dave Page
VP, Chief Architect, Tools & Installers
E= nterpriseDB: http= ://www.enterprisedb.com
The Enterprise PostgreSQL Company

Blo= g: http://pgsnake= .blogspot.com
Twitter: @pgsnake




--
=
Dave Page
VP, Chief Architect, Tools &= amp; Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQ= L Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake




--
=
Dave Page=
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com=
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Tw= itter: @pgsnake
--001a11446e8620e620054f141fc7--