Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1eqdqa-0001mn-98 for pgadmin-hackers@arkaria.postgresql.org; Tue, 27 Feb 2018 11:55:04 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1eqdqY-0001SG-AN for pgadmin-hackers@arkaria.postgresql.org; Tue, 27 Feb 2018 11:55:02 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1eqdqY-0001Rv-1q for pgadmin-hackers@lists.postgresql.org; Tue, 27 Feb 2018 11:55:02 +0000 Received: from mail-wr0-x235.google.com ([2a00:1450:400c:c0c::235]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1eqdqT-0001tx-PW for pgadmin-hackers@postgresql.org; Tue, 27 Feb 2018 11:55:00 +0000 Received: by mail-wr0-x235.google.com with SMTP id o76so24574845wrb.7 for ; Tue, 27 Feb 2018 03:54:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=3ySL1av4CVFFS7alHlTNO6aWCj9n6ty8+OfRZxyn0xQ=; b=BFfwUYBO9NT99RLReelaf1pBOkNMREhKZgze8lFf7pjSzsxz2mMXq+/3iUPNkLqCH8 lb8KHMWTPJAackXcrbOs+jMvc/Z0SKi8DGqXAtKF/lg3TQzKOaHRv+UtgeCYcQPYkixF Ga6hco8/yB3SuH71waCZ4d5wgI+kmuBNbEVFZ+i73IUUSfrZ2nIkwwZQ+F4FCS7iUt20 RtDsJEEsPFiYq8eyMzX98UxrWhoH+cFL9X+NFXm6Y2PIR137g9UboAz9eb4p0KpU/TXW ZsCHs02Qzb/TUMUX3lBmVAKnFQaC1zGCJciwF+QU/K3RxuKuItqcwWlzM0vxQhYy/h5m wZFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=3ySL1av4CVFFS7alHlTNO6aWCj9n6ty8+OfRZxyn0xQ=; b=Uvrp/Hxsemjpx6BBY2Dg2Qivz6PO7hyoolsbFu7xR6LIV1s5/BRojMxt7pueLIThEp A2DeyU3ONiGwo4li95Wc0R214tgh3V6AUrJ1rxYmAWmmZ6+QVbzeWlzl5TmOr8xS4Iqp xSHaCN4XKyuXXVuBvCKEM9HZ7gu9BM9PRf3wfWknj+PF0ToaIH7NBALJ6+dBpYn4H4sb R/DkwyzOd6yTVpCGPpe4bw9gyRLA0AMyHDJ1z81ijeLHBnQnOkFGWTON+TjgoqGqSjII N/aiqVPOlqfDp4qHLVAwpZhj1HiCrgQsSnybmfHKOBtV1xeqJrs4DJLeNFwr4ojyuCss SvfA== X-Gm-Message-State: APf1xPCm2Gmjt6kxO1pI9RFb3Bp4rKyYEZHcUEEd2rrb1ULeMkMLCu+O G4F0fhirVVqZgdzm77+OK8k1KlgA4rAjy7NcftBrFtFu X-Google-Smtp-Source: AH8x227lhlvTirS907d2DYFZwSodkknTBXVHe90s1Fwx7Rw2NS2fmsiA2cvjonqfT/I/l7E6LKrBV1fIsq+2KoAXcio= X-Received: by 10.223.184.230 with SMTP id c35mr11560499wrg.190.1519732494860; Tue, 27 Feb 2018 03:54:54 -0800 (PST) MIME-Version: 1.0 Received: by 10.28.109.7 with HTTP; Tue, 27 Feb 2018 03:54:54 -0800 (PST) In-Reply-To: References: From: Dave Page Date: Tue, 27 Feb 2018 11:54:54 +0000 Message-ID: Subject: Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI To: Murtuza Zabuawala Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="f403045fab6c8295b00566304bf6" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --f403045fab6c8295b00566304bf6 Content-Type: text/plain; charset="UTF-8" Hi Still not quite right - see the attached screenshot which is the result of simply viewing the properties of an existing job. Note that the start time is shown in the grid but not the subnode control. Thanks. On Tue, Feb 27, 2018 at 8:26 AM, Murtuza Zabuawala < murtuza.zabuawala@enterprisedb.com> wrote: > Hi Dave, > > As validation related patch was committed with RM#3148 [ Sorry about that > I forgot to checkout :) ] > PFA patch to fix the issues you mentioned, I have also removed extra error > message from sub node collection control and made it optional via flag. > > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > On Mon, Feb 26, 2018 at 10:14 PM, Dave Page wrote: > >> Hi >> >> On Mon, Feb 26, 2018 at 2:46 PM, Murtuza Zabuawala < >> murtuza.zabuawala@enterprisedb.com> wrote: >> >>> Hi, >>> >>> PFA patch to fix the issue where user was not able to create pgAgent job >>> from UI without entering End date in schedule section. >>> >> >> Whilst this does resolve the validation issue, there are still a couple >> of other related problems, as can be seen in the attached screenshots: >> >> - The Start date/time in the subnode control doesn't seem to be properly >> synchronised with the value in the grid. >> >> - If you leave the End date/time blank (but maybe click into it first), >> the grid will show "Invalid date". >> >> It's possible there are other oddities as well - please check carefully >> for anything else. >> >> Thanks. >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --f403045fab6c8295b00566304bf6 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi

Still not quite right - see the atta= ched screenshot which is the result of simply viewing the properties of an = existing job. Note that the start time is shown in the grid but not the sub= node control.

Thanks.

On Tue, Feb 27, 2018 at 8:26 AM, M= urtuza Zabuawala <murtuza.zabuawala@enterprisedb.com&= gt; wrote:
Hi Dave,

As validatio= n related patch was committed with RM#3148 [ Sorry about that I forgot to c= heckout :)=C2=A0]
PFA patch to fix the issues you menti= oned, I have also removed extra error message from sub node collection cont= rol and made it optional via flag.



--
Regards,
<= font size=3D"2">Murtuz= a Zabuawala
EnterpriseDB:=C2=A0http://www.enterprisedb.comThe Enterprise PostgreSQL Company


On Mon, Feb 26, 2018 at 10:14 PM, Dave Page = <dpage@pgadmin.org> wrote:
Hi

On Mon, Feb 26, 2018 at 2:46 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA patch to fix the issue where user was not able to create = pgAgent job from UI without entering End date in schedule section.

=C2=A0Whilst this does resolve the vali= dation issue, there are still a couple of other related problems, as can be= seen in the attached screenshots:

- The Start dat= e/time in the subnode control doesn't seem to be properly synchronised = with the value in the grid.

- If you leave the End= date/time blank (but maybe click into it first), the grid will show "= Invalid date".

It'= s possible there are other oddities as well - please check carefully for an= ything else.

Thanks.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

Ent= erpriseDB UK: htt= p://www.enterprisedb.com
The Enterprise PostgreSQL Company




--
Dave Page
Blog: = http://pgsnake.bl= ogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com<= br>The Enterprise PostgreSQL Company
--f403045fab6c8295b00566304bf6--