MIME-Version: 1.0
In-Reply-To: 
 <CAOAJCYpsPXH3oKen-zH3oLjuOqdrt=XE4FiazYm0MsVQWtXk9g@mail.gmail.com>
References: 
 <CAOAJCYpsPXH3oKen-zH3oLjuOqdrt=XE4FiazYm0MsVQWtXk9g@mail.gmail.com>
From: Dave Page <dave.page@enterprisedb.com>
Date: Tue, 13 Sep 2016 09:48:08 +0100
Message-ID: 
 <CA+OCxox=16k4tAhdZLDk_D0bqSG34=rd4QfXgcqGx=61GjL-uA@mail.gmail.com>
Subject: Re: Server specific advanced config file for testsuite
To: Navnath Gadakh <navnath.gadakh@enterprisedb.com>
Cc: Kanchan Mohitey <kanchan.mohitey@enterprisedb.com>,
	pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

Hi

On Mon, Sep 12, 2016 at 6:26 PM, Navnath Gadakh
<navnath.gadakh@enterprisedb.com> wrote:
> Hi Dave,
>      As we know that, we are using two JSON files one is for basic
> configuration of server(test_config.json) and second for detailed
> configuration of server(test_advanced_config.json).
> In test_advanced_config.json, we give detail for database, schema,
> extension, collation etc. These details are generic I mean these details =
are
> not server specific.
> - Do we need to allow user to give server specific details?

I don't see any reason to do so. Honestly I don't see much need for
test_advanced_config.json at all - I can't see anyone ever customising
the tests. I certainly doubt I will.

> If yes, there should be some identification(like =E2=80=98server_type=E2=
=80=99, =E2=80=98version=E2=80=99)
> for each detail so that we can read server appropriate details.
> We have one approach in mind, to attach 'server_type' & 'version' to each
> detail
> So, modified test_advanced_config.json can be like this,
> {
> "add_database_data=E2=80=9D:[
> {
>  "conn_limit": -1,
>  =E2=80=9Cowner=E2=80=9D: =E2=80=9Cpostres=E2=80=9D,
>   .
>   .
>   .
>   .
>  =E2=80=9Cserver_type=E2=80=9D: =E2=80=9Cpg=E2=80=9D,
>  =E2=80=9Cversion=E2=80=9D: =E2=80=9Cpg9.4=E2=80=9D
> },
> {
> {
>  "conn_limit": -1,
>  =E2=80=9Cowner=E2=80=9D: =E2=80=9Centerprisedb=E2=80=9D,
>   .
>   .
>   .
>   .
>  =E2=80=9Cserver_type=E2=80=9D: =E2=80=9Cppas=E2=80=9D,
>  =E2=80=9Cversion=E2=80=9D: =E2=80=9Cppas9.6=E2=80=9D
> }
> }],
> =E2=80=9Cschema_credentials=E2=80=9D:
> [{"func_acl": [],
>   "seq_acl": [],
>   .
>   .
>   .
>   .
>   =E2=80=9Cserver_type=E2=80=9D: =E2=80=9Cpg=E2=80=9D,
>   =E2=80=9Cversion=E2=80=9D: =E2=80=9Cpg9.4=E2=80=9D
> }]
> .
> .
> .
> .
> .
> }
>
> Any suggestions?
>
> For multiple server currently we used 'owner' to identify the server, but
> that fails if two servers have the same owner.
>
>
> --
> Thanks,
> Navnath Gadakh
> Software Engineer
> EnterpriseDB Corporation
> Mobile: +91 9975389878
>
>


--=20
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake


--=20
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers