Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1eqLhU-00029U-0D for pgadmin-hackers@arkaria.postgresql.org; Mon, 26 Feb 2018 16:32:28 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1eqLhS-0004Ad-UF for pgadmin-hackers@arkaria.postgresql.org; Mon, 26 Feb 2018 16:32:26 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1eqLhS-00047e-Ou for pgadmin-hackers@lists.postgresql.org; Mon, 26 Feb 2018 16:32:26 +0000 Received: from mail-wm0-x233.google.com ([2a00:1450:400c:c09::233]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1eqLhL-0005eg-FK for pgadmin-hackers@postgresql.org; Mon, 26 Feb 2018 16:32:22 +0000 Received: by mail-wm0-x233.google.com with SMTP id t3so18655157wmc.2 for ; Mon, 26 Feb 2018 08:32:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=0VdNid8LLu3jYi9RXjXSDOu2M+16Om4+kze/1HdhNjM=; b=Ve0ZVM8hNplqM9fesNbfS+8kUTmnwG2bff3LebBS0XsYeqzzKxQIIsSrHsli0X79ic XKnkUIPNliFiBVHgqo+Sgy4s2RWEHzhRWKlwXucsfL1w1sszuJSxsUhI2b6L9OUhgbGi 7dS0Nwh43CI9UQPbfYBzj/qmhtUWNGllJ2sghuykcL6+iqn3mfdRYfGDdWopdr9KskvV /aAWxPaxGNOQ3CgBGMN7CEOj7kaJ7R0eNoD1ewwxd1cgfbjnH5JKGBThz2okJvGO6FtZ KVnEokOT3bl3YINIRzkSP+A1SOoOwr9DrcvicxP2Qr55cjDgW8woLATmJrqFze4dVu+T Egkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=0VdNid8LLu3jYi9RXjXSDOu2M+16Om4+kze/1HdhNjM=; b=gX4wBD7/Cmnz8kOauwq781kK96m8MjAzg1jQ2co+mbDbdhKjxcJF7BnXkvibWfxleL KsfjtuXgH3YJOLhpLexei5CZ02aLiYUz8WhkK7H06voR99tili5Z4PDE/w6TU6WTmq7b MqI0GgUSZvgL/jjafWWbcGx1CjMA8kx5eoPek4jUfzIBRIHL9YzzLuYI/nqt8Ug5QsWg KLpF61nGb9K5vgVIebIQyK0xu44YhWuZ6sv5U8eVnbPRES65yxtBufwwct4dzFHIZEF3 WG7GiTLrZ1KdJ1sl9JA6XcUfRJMCEoz3K81w/r9AQb9Nqaea1CHjdvy5dmP8LS+1fwid 8BHw== X-Gm-Message-State: APf1xPBEyp5Ocotv8UL7BQKzIJmW/1YghD0TEdEk17vSr6rb8c7EL4Qk 5XJcAhntIYjfALI7u9yy1fn0hQNl14Cj8mSjw4fROg== X-Google-Smtp-Source: AG47ELue0cRRU5qLwP3Uoh6SPTrpofUl50NbNS/JsT2jbddmEJyj5et+FDPcgDT7BE5HJAcQ57Pubx4xzPFrqL7fBVs= X-Received: by 10.28.41.3 with SMTP id p3mr9677205wmp.140.1519662737382; Mon, 26 Feb 2018 08:32:17 -0800 (PST) MIME-Version: 1.0 Received: by 10.28.109.7 with HTTP; Mon, 26 Feb 2018 08:32:16 -0800 (PST) In-Reply-To: References: From: Dave Page Date: Mon, 26 Feb 2018 16:32:16 +0000 Message-ID: Subject: Re: pgAdmin 4 commit: Ensure we pick up the messages from the current query To: Murtuza Zabuawala Cc: Khushboo Vashi , pgadmin-hackers Content-Type: multipart/alternative; boundary="001a114e3cc6a402f70566200dca" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --001a114e3cc6a402f70566200dca Content-Type: text/plain; charset="UTF-8" Argh, I ran some tests, but didn't spot any lost messages in the tests I ran. I'll revert the patch. Khushboo; Please look at the following: - Fix the patch so it doesn't drop messages. - Add regression tests to make sure it doesn't break in the future. This may require creating one or more functions the spew out a whole lot of notices, and then running a couple of queries and checking the output. - Check the messages panel on the history tab. I just noticed it seems to only be showing an even smaller subset of the messages. Thanks. On Mon, Feb 26, 2018 at 4:23 PM, Murtuza Zabuawala < murtuza.zabuawala@enterprisedb.com> wrote: > Sent bit early, > > You can run 'VACUUM FULL VERBOSE' in query tool and verify the populated > messages (pgAdmin3 vs. pgAdmin4). > > > On Mon, Feb 26, 2018 at 9:48 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi Khushboo/Dave, >> >> With given commit, I'm again seeing the issue raised in >> https://redmine.postgresql.org/issues/1523 :( >> >> >> >> >> -- >> Regards, >> Murtuza Zabuawala >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> >> On Mon, Feb 26, 2018 at 7:49 PM, Dave Page wrote: >> >>> Ensure we pick up the messages from the current query and not a previous >>> one. Fixes #3094 >>> >>> Branch >>> ------ >>> master >>> >>> Details >>> ------- >>> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdif >>> f;h=08b3ccc01a4d57e8ea3657f8882a53dcd1b99386 >>> Author: Khushboo Vashi >>> >>> Modified Files >>> -------------- >>> web/pgadmin/utils/driver/abstract.py | 1 + >>> web/pgadmin/utils/driver/psycopg2/__init__.py | 64 >>> +++++++++------------------ >>> 2 files changed, 21 insertions(+), 44 deletions(-) >>> >>> >> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a114e3cc6a402f70566200dca Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Argh, I ran some tests, but didn't spot any lost messa= ges in the tests I ran. I'll revert the patch.

Khush= boo;

Please look at the following:

<= /div>
- Fix the patch so it doesn't drop messages.
- Add = regression tests to make sure it doesn't break in the future. This may = require creating one or more functions the spew out a whole lot of notices,= and then running a couple of queries and checking the output.
- = Check the messages panel on the history tab. I just noticed it seems to onl= y be showing an even smaller subset of the messages.

Thanks.

On Mon, Feb 26, 2018 at 4:23 PM, Murtuza Zabuawala &l= t;m= urtuza.zabuawala@enterprisedb.com> wrote:
Sent bit early,=C2=A0

You can run 'VACUUM FULL VERBOSE' in query = tool and verify the populated messages (pgAdmin3 vs. pgAdmin4).=C2=A0
=


On Mon, Feb 26, 2018 at 9:48 PM, Murtuza Zabuawala <<= a href=3D"mailto:murtuza.zabuawala@enterprisedb.com" target=3D"_blank">murt= uza.zabuawala@enterprisedb.com> wrote:
Hi Khushboo/Dave,

With given commi= t, I'm again seeing the issue raised in https://redmine.postgresql.org/issues/1523 :(




--
<= font size=3D"2" face=3D"verdana, sans-serif" color=3D"#444444">Regards,
Murtuza Zabuawala
EnterpriseDB:=C2=A0http://www.enterprisedb.= com
The Enterprise PostgreSQL Company
=
=

On Mon, Feb 26, 2018 at 7:49 PM, Dave Page <= span dir=3D"ltr"><dpage@pgadmin.org> wrote:
Ensure we pick up the messages from the current query an= d not a previous one. Fixes #3094

Branch
------
master

Details
-------
https://git.postgresql.org/gitweb?p=3Dpgadmin4.git;a=3Dcom= mitdiff;h=3D08b3ccc01a4d57e8ea3657f8882a53dcd1b99386
Author: Khushboo Vashi <khushboo.vashi@enterprisedb.com>

Modified Files
--------------
web/pgadmin/utils/driver/abstract.py=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= |=C2=A0 1 +
web/pgadmin/utils/driver/psycopg2/__init__.py | 64 +++++++++----------= --------
2 files changed, 21 insertions(+), 44 deletions(-)






--
Dave Page
Blog: = http://pgsnake.bl= ogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com<= br>The Enterprise PostgreSQL Company
--001a114e3cc6a402f70566200dca--