MIME-Version: 1.0
References: <E1gaJUl-0004l2-J3@gothos.postgresql.org>
 <CA+OCxoyp8XjOa0xdiqoohiQ1Bm0fcrruXTWu-Y_mqY5LaGeBoQ@mail.gmail.com>
 <CAM9w-_ngsgJxJOJKngc-3W8tqNymKeZjBCuW2_VN-nb4k5du=g@mail.gmail.com>
 <CA+OCxoxHWJK+XA6zROKWznJkJf1=adDEoafqCoz9BPnMvmtzAg@mail.gmail.com>
 <CA+OCxoyuDXfZR2zNKONy-CWWYbo_xAeLZRVZwVZ=1_gU+4zUAg@mail.gmail.com>
 <CAM9w-_mXaptQzE45a3eRfLB5qG0R+qUm6JnAnR4C6rOZ8fiJFw@mail.gmail.com>
 <CA+OCxowym3tJZfDkOJkqfsNbaxT=Z=nnxCEQWF4nm+HL5q8_qQ@mail.gmail.com>
 <CAM9w-_nXoXLjm4jyJKsZ1vOXJLei7akyrBQMOY+p_jmDzmEmdg@mail.gmail.com>
 <CA+OCxow69BHrCT7JcdfVyFwn0JnWEszaMdwxuWaxBddKf=h4mg@mail.gmail.com>
 <CAM9w-_myZ=B-Nzt9DGAnvXVQgz3szAbe13cLPC4kSSXbUQXt6w@mail.gmail.com>
 <CAM9w-_=sK8X=VXE8mqVY6+McuM=EXwg8_xJ56tf_0pHDvvH7uQ@mail.gmail.com>
 <CAM9w-_nkvOB5VTGwLkhDiNUYGF1yho0H6BniUoKFM8vveb3zKg@mail.gmail.com>
 <CANxoLDeLe0YKm4hZOpwFX79p+DuR0ocibYkH8WFLtk6XwLNK2w@mail.gmail.com>
 <CAM9w-_niKinU7MWXxth4Em9BQc=xDKOwgbApL58viZq2zJ=phw@mail.gmail.com>
 <CA+OCxow9Kw-KAL366JBPxZ1p4cRDuMe=DWv7v5AygAcm8v19hQ@mail.gmail.com>
 <CAM9w-_k95kK6PHtcgh-eQwH_h6HYV64gbLqdS3Lp7zwWDrw0hA@mail.gmail.com>
 <CA+OCxoyBjf2bV+ybc6Cj8759K_FzL+585LKgCo8kersTK+eeHQ@mail.gmail.com>
 <CAM9w-_=8Fz0Ly4KuvzED-ayjgqDvVwTsfWuQpFB8YQvcF-TgTQ@mail.gmail.com>
 <CA+OCxoz419cvzChkxULcK4MvvaE+D=u5GEVjV1u3SYGF9g5+LA@mail.gmail.com>
 <CAM9w-_=+ONV6MNjDPStk6KsQoYqKQ3OW1U_1Wk7396qDMGgN=g@mail.gmail.com>
In-Reply-To: 
 <CAM9w-_=+ONV6MNjDPStk6KsQoYqKQ3OW1U_1Wk7396qDMGgN=g@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Mon, 7 Jan 2019 14:24:58 +0530
Message-ID: 
 <CA+OCxoxAut_n6_zaoTP=CWHwiZzj0Z+sXAciNZeEQs3fhcO9cg@mail.gmail.com>
Subject: Re: pgAdmin 4 commit: Improvement in the look and feel of the whole
 applica
To: Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>
Cc: Akshay Joshi <akshay.joshi@enterprisedb.com>,
	pgadmin-hackers <pgadmin-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Thanks - applied!

On Mon, Jan 7, 2019 at 10:44 AM Aditya Toshniwal
<aditya.toshniwal@enterprisedb.com> wrote:
>
> Hi Hackers,
>
> Attached is the patch to incorporate the changes discussed in trailing ma=
il(s).
>
> Kindly review.
>
> On Fri, Jan 4, 2019 at 3:31 PM Dave Page <dpage@pgadmin.org> wrote:
>>
>> On Fri, Jan 4, 2019 at 9:58 AM Aditya Toshniwal
>> <aditya.toshniwal@enterprisedb.com> wrote:
>> >
>> > Hi,
>> >
>> > On Fri, Jan 4, 2019 at 2:53 PM Dave Page <dpage@pgadmin.org> wrote:
>> >>
>> >> Hi
>> >>
>> >> On Fri, Jan 4, 2019 at 4:51 AM Aditya Toshniwal <aditya.toshniwal@ent=
erprisedb.com> wrote:
>> >>>
>> >>> Hi Dave,
>> >>>
>> >>> On Thu, Jan 3, 2019 at 8:39 PM Dave Page <dpage@pgadmin.org> wrote:
>> >>>>
>> >>>>
>> >>>> A few other things that I noticed (or have been bugging me):
>> >>>>
>> >>>> - The menu bar seems a little cramped. Taking pg-navbar from 32 to =
40px and setting the font-weight to normal on the menu options (but not the=
 product name) seems much better to me (and adjusting everything else as re=
quired of course).
>> >>>
>> >>> Giving too much space for the navbar will reduce the usable space fo=
r other things. It is good enough(32) to be used easily, and is equal to al=
l the other headers in app (including tabs) giving a feel of native desktop=
 application. You'll find even smaller menu heights in native desktop appli=
cation. We can make font weight to normal and may be slightly increase hori=
zontal spacing between the menu links.
>> >>
>> >>
>> >> 8 pixels isn't going to make a noticeable difference to the workspace=
 for users, and would leave the bar smaller than the 50px it's been for the=
 last couple of years (iirc). I think it needs it to avoid looking cramped =
- please make the change.
>> >
>> > Will do.
>> > One more doubt regarding bold headers, should I remove bold headers in=
 dashboard graph header, subnode headers (eg.table->columns), properties ta=
b accrordian headers ?
>>
>> No, please don't. I left them bold and the styling seemed like it
>> worked. We can tweak again if others disagree later.
>>
>> Thanks!
>>
>> BTW - Chrome 71 shows the offset headers in the file dialogue as well.
>>
>> >>>>
>> >>>> - In the file dialogue, the column headers don't line up with the c=
olumns in the rows.
>> >>>
>> >>> I could not see this on my machine (screenshot attached). Could you =
please share the screenshot.
>> >>
>> >>
>> >> Attached - thanks! This is Chrome 70.0.3538.102 on MacOS.
>> >>
>> >> --
>> >> Dave Page
>> >> Blog: http://pgsnake.blogspot.com
>> >> Twitter: @pgsnake
>> >>
>> >> EnterpriseDB UK: http://www.enterprisedb.com
>> >> The Enterprise PostgreSQL Company
>> >
>> >
>> >
>> > --
>> > Thanks and Regards,
>> > Aditya Toshniwal
>> > Software Engineer | EnterpriseDB Software Solutions | Pune
>> > "Don't Complain about Heat, Plant a tree"
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"


--=20
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company