Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ewEPd-0004oS-Na for pgadmin-hackers@arkaria.postgresql.org; Wed, 14 Mar 2018 21:58:21 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1ewEPc-00020M-Kx for pgadmin-hackers@arkaria.postgresql.org; Wed, 14 Mar 2018 21:58:20 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ewEPc-000206-CB for pgadmin-hackers@lists.postgresql.org; Wed, 14 Mar 2018 21:58:20 +0000 Received: from mail-wr0-x241.google.com ([2a00:1450:400c:c0c::241]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ewEPY-0002aK-RN for pgadmin-hackers@postgresql.org; Wed, 14 Mar 2018 21:58:19 +0000 Received: by mail-wr0-x241.google.com with SMTP id f14so6254122wre.8 for ; Wed, 14 Mar 2018 14:58:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=/KKQireuJtfg21VJ/kvE5ViJJPCYPgPNkDa+wz+SXzk=; b=AA+Dw01PPQVpVG6me+Pt4DEDQfCzHHq3vK6nMEOWPok15JHjObBfLBD8auFrJOVx5a fqKyY5ggfgq0cPND+3VTCMonAhZpl0G3AdssFKqcBjgljLnFRsCBKcNzK93draB8tY42 O94xT6uIlv3DzRKdZhGS65e6XI2c++jLWTq62yF5kCYT77eZhjSaaC1Zhe0OFhRhe4SY gIV8vh5Yov2gLU+8NktLOrvbBuoUKTassB6Pkptx9NjZcZjIF81VDACrEMVThakp81G/ iIOApm97ue+Owny4Kqt64RLu9Syy8MD2XbwanajxYYxvAgbg2eMY8sLuVCys5sUCS5Vh BQeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=/KKQireuJtfg21VJ/kvE5ViJJPCYPgPNkDa+wz+SXzk=; b=ISFyYmTvFC/VqCuFDTckfMXfaTw+gilf1nDynLGZ9KASu8xHVqtRylut1K94rOzmQf 1VkRUVdRCrcbZUUoz3KxISYEVrMRF3lVDcXNajWT/YiJnalbA1Zu9FNbchFdGApNgxAy OxzmjIq5cKszpOFnMsrRHn37SiQzmG5JZLqW8fLszNbS4TAu75GuyQIeJqSKiGpxbAwx n8u/4XIe3lhdcU5/Gn4GyNrVpWhFF41U+w3eVhVALnH7z6CSXtZgZpg2gT0GdyI2vzSm haxRLHUgtRNBzLanNFRgQGCg0dS/sfwNZU5wJF0AzQScyswx33bbMUswfvnV22DMtIho PaAQ== X-Gm-Message-State: AElRT7E3t4+cbTzYkAECt2lwPkjchnHBo0DTbPL7raeQrXEBYMn9Nf5U GSCfSqpUhVVhCfgGLEhAjmyVDA9VRSkb1Zo/nkTcl318 X-Google-Smtp-Source: AG47ELuieT8Gl8vl5n/V0jDMxcca8wl1KcSKceaCe1mBG1d4F6yLy+/D3jCbwGpt1VzDequMmpzBUBZIAwFWTUfzNc0= X-Received: by 10.223.195.124 with SMTP id e57mr4857618wrg.135.1521064694877; Wed, 14 Mar 2018 14:58:14 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.109.7 with HTTP; Wed, 14 Mar 2018 14:58:13 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Wed, 14 Mar 2018 17:58:13 -0400 Message-ID: Subject: Re: pgAdmin 4 commit: Refactor server dialogue validation for better unit t To: Joao De Almeida Pereira Cc: Khushboo Vashi , Victoria Henry , pgadmin-hackers Content-Type: multipart/alternative; boundary="f403045c4e22d19b1405676678f1" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --f403045c4e22d19b1405676678f1 Content-Type: text/plain; charset="UTF-8" Thanks, applied. On Wed, Mar 14, 2018 at 12:10 PM, Joao De Almeida Pereira < jdealmeidapereira@pivotal.io> wrote: > Hi Khushboo, > Good catch, attached you can find the fix for the problem. > > Thanks > Victoria & Joao > > On Wed, Mar 14, 2018 at 10:37 AM Khushboo Vashi < > khushboo.vashi@enterprisedb.com> wrote: > >> Hi Joao/Victoria, >> >> I am getting an error while editing the server properties. Please refer >> the attached screen-shot for the same. >> >> Thanks, >> Khushboo >> >> On Wed, Mar 14, 2018 at 12:17 AM, Dave Page wrote: >> >>> Refactor server dialogue validation for better unit testing. >>> >>> Victoria & Joao @ Pivotal. >>> >>> Branch >>> ------ >>> master >>> >>> Details >>> ------- >>> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h= >>> 6b03cb78af607b04c75de44d635bf201babb4c5a >>> Author: Victoria Henry >>> >>> Modified Files >>> -------------- >>> web/package.json | 3 +- >>> .../server_groups/servers/static/js/server.js | 113 >>> ++------------------- >>> web/pgadmin/static/bundle/browser.js | 2 +- >>> web/pgadmin/static/js/browser/index.js | 10 ++ >>> .../static/js/browser/server_groups/index.js | 10 ++ >>> .../server_groups/servers/databases/index.js | 10 ++ >>> .../js/browser/server_groups/servers/index.js | 11 ++ >>> .../server_groups/servers/model_validation.js | 104 >>> +++++++++++++++++++ >>> .../server_groups/servers/model_validation_spec.js | 101 >>> ++++++++++++++++++ >>> web/yarn.lock | 46 ++++++++- >>> 10 files changed, 299 insertions(+), 111 deletions(-) >>> >>> >> -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --f403045c4e22d19b1405676678f1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, applied.

On Wed, Mar 14, 2018 at 12:10 PM, Joao De Almeida Per= eira <jdealmeidapereira@pivotal.io> wrote:
Hi Khushboo,
Good catch, a= ttached you can find the fix for the problem.

Than= ks
Victoria & Joao

On Wed, Mar 14, 2018 at 10:37 AM Khushboo= Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi Joao/Victoria,
I am getting an error while editing the server properties. Please re= fer the attached screen-shot for the same.

Thanks,
=
Khushboo

On Wed, Mar 14, 2018 at 12:17 AM, Dave Page <<= a href=3D"mailto:dpage@pgadmin.org" target=3D"_blank">dpage@pgadmin.org= > wrote:
Refactor server dialog= ue validation for better unit testing.

Victoria & Joao @ Pivotal.

Branch
------
master

Details
-------
https://git.postgresql.org/gitweb?p=3Dpgadmin4.git;a=3Dcommitdiff;h=3D6b03cb78af607b04c75de44d635bf201babb4c5a
Author: Victoria Henry <vhenry@pivotal.io>

Modified Files
--------------
web/package.json=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 = =C2=A03 +-
.../server_groups/servers/static/js/server.js=C2=A0 =C2=A0 =C2=A0 | 11= 3 ++-------------------
web/pgadmin/static/bundle/browser.js=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A02 +-
web/pgadmin/static/js/browser/index.js=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0|=C2=A0 10 ++
.../static/js/browser/server_groups/index.js=C2=A0 =C2=A0 =C2=A0 =C2= =A0|=C2=A0 10 ++
.../server_groups/servers/databases/index.js=C2=A0 =C2=A0 =C2=A0 =C2= =A0|=C2=A0 10 ++
.../js/browser/server_groups/servers/index.js=C2=A0 =C2=A0 =C2=A0 |=C2= =A0 11 ++
.../server_groups/servers/model_validation.js=C2=A0 =C2=A0 =C2=A0 | 10= 4 +++++++++++++++++++
.../server_groups/servers/model_validation_spec.js | 101 +++++++++++++= +++++
web/yarn.lock=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2= =A0 46 ++++++++-
10 files changed, 299 insertions(+), 111 deletions(-)





--
Dave Page
Blog: = http://pgsnake.bl= ogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com<= br>The Enterprise PostgreSQL Company
--f403045c4e22d19b1405676678f1--