public inbox for [email protected]  

help / color / mirror / Atom feed

From: Dave Page <[email protected]>
To: Magnus Hagander <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: Sequence queries on pg_depend lacking classid filter
Date: Fri, 16 Sep 2016 11:25:51 +0100
Message-ID: <CA+OCxoxBiyeYLcj4S7=chx+KaSeLTUf4JEpemz=Cr46GN1sydA@mail.gmail.com> (raw)
In-Reply-To: <CABUevEwVtw1zL03TTmo66-g9P9BfTsy8s22beUthrWhDRfc9aQ@mail.gmail.com>
References: <CABUevEwVtw1zL03TTmo66-g9P9BfTsy8s22beUthrWhDRfc9aQ@mail.gmail.com>
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Thanks - committed with a minor change to remove a duplicate WHERE
clause that you added to one of the queries.

On Thu, Sep 15, 2016 at 5:22 PM, Magnus Hagander <[email protected]> wrote:
> There are a number of cases where queries in both pgadmin4 and pgadmin3 are
> done against pg_depend but falis to constrain the query on classid.
>
> In particular, if for example a constraint and a sequence exists with the
> same oid (which is perfectly valid, as they are in different tables), a
> column will suddenly refer sequences that are completely incorrect. When we
> look up sequences, we have to make sure we only match dependencies against
> pg_class.
>
> AFAICT, the following patch catches the important ones. I could go ahead and
> push it, but given that we're in RC I'd appreciate a round of review before
> doing that, even though it looks fairly simple.
>
> I've got the same changes in a patch to pgadmin3, as these queries are
> basically a copy/paste from there. But let's focus the review on the one for
> pgadmin4 :)
>
> --
>  Magnus Hagander
>  Me: http://www.hagander.net/
>  Work: http://www.redpill-linpro.com/
>
>
> --
> Sent via pgadmin-hackers mailing list ([email protected])
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

view thread (2+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Sequence queries on pg_depend lacking classid filter
  In-Reply-To: <CA+OCxoxBiyeYLcj4S7=chx+KaSeLTUf4JEpemz=Cr46GN1sydA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox