Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1anSyn-0004nD-R8 for pgadmin-hackers@arkaria.postgresql.org; Tue, 05 Apr 2016 15:33:21 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1anSyn-0003Cw-Dj for pgadmin-hackers@arkaria.postgresql.org; Tue, 05 Apr 2016 15:33:21 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1anSyZ-0002xz-MK for pgadmin-hackers@postgresql.org; Tue, 05 Apr 2016 15:33:07 +0000 Received: from mail-ig0-x22b.google.com ([2607:f8b0:4001:c05::22b]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1anSyV-000717-Bc for pgadmin-hackers@postgresql.org; Tue, 05 Apr 2016 15:33:07 +0000 Received: by mail-ig0-x22b.google.com with SMTP id g8so17266413igr.0 for ; Tue, 05 Apr 2016 08:33:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=I7uFXxkmhcsQQOStxz9Kuq/ypUrZe+eOsagnfVnXlDU=; b=02F1paowlHyiYKgd8BQye656rRhOdpVOf/L5wt38YSIExcT0Qv1N0vsc7TrKvPxl0w XmeorFqU5o/VRLEyWSWpDpHvSJk6ABNrwnWdJQkuC6qTK0dwPEG/xfDJn8HXByn2G68m M1EIqoqJQRFwkcFRCPUgvq1ufesqaCbGNWaTyrLH1g8OuzKQUvMzqh0CIXWgv4S0HW1J WGsGLBxzv5Wr9G/yLQGxS2bOYpivZa3w3jP/30iatznysthzFbIZjaiylLjXVyzG5FIj ocGYBs4bz1n2oJQIfdbvhmny0f/qVe6XZkH5gijKi0OE6YahUOrQ00hxVDxmZKd+yEl9 AKhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=I7uFXxkmhcsQQOStxz9Kuq/ypUrZe+eOsagnfVnXlDU=; b=OfaEl+kFNWjrN6IG505M587UsZJyHV09dKD3O7GIjlpOrGN/FvzUmgy4z8x1mf7sb2 eudMXR9xQvoB5BCpWspL7NKQjpr+zta5nkKJTJrpXuSMIU741y4f7K0R1+fDt6zuGw6Q dDPgnJW1Uw/P0Yii05CpbeLleny5mMThcN5z8AIfgsNMUTEi8sqJdCW48dBg5ehHdnAv 5OkQxgE1kTKb0cXPYdKjuf/g3QGqFtEbm3IZrWj6k+2QLOmrSLh8ygLGNre563ipjh2J TtTmSKmTQHTXnSjYIEJY3BFMYhq9wwAn4a3GwoNj5ri6wBbLojFuJ51FX3OvqvObbZnk OIxg== X-Gm-Message-State: AD7BkJJ9wQkumSLQvrrX/ujdhxcXb7dFAKDRw8QFkWsEooxmW1pPnfPdCBAk7UHLV/9lkyM3m15+pTtwYGDa9A== MIME-Version: 1.0 X-Received: by 10.50.59.210 with SMTP id b18mr18373900igr.11.1459870378709; Tue, 05 Apr 2016 08:32:58 -0700 (PDT) Received: by 10.64.105.131 with HTTP; Tue, 5 Apr 2016 08:32:58 -0700 (PDT) In-Reply-To: References: Date: Tue, 5 Apr 2016 16:32:58 +0100 Message-ID: Subject: Re: pgAdmin4 PATCH: Domain Module From: Dave Page To: Khushboo Vashi Cc: pgadmin-hackers Content-Type: text/plain; charset=UTF-8 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org Thanks - committed. On Thu, Mar 24, 2016 at 3:25 PM, Khushboo Vashi wrote: > Hi, > > Please find the attached updated patch for the Domains Module. > > Thanks, > Khushboo > > On Thu, Mar 24, 2016 at 5:29 PM, Dave Page wrote: >> >> Hi >> >> You're going to hate me for this.... >> >> - I added an un-validated constraint to a domain, then opened the >> domain properties and clicked the Validate? option for it. The SQL is >> generated, but the Save button is not enabled. > > Done. >> >> >> - If I right-click a domain, I get Create options for "Domain" (with a >> constraint icon) and "Domain..." with a domain icon. >> > As per the discussion with Ashesh, He has updated the context menu JS file > with the new version and that is causing the issue. > He is going to fix this issue as this is generic for the all context menu. > I will create a new task for this in kanban and assign it to Ashesh. > >> See attached screenshot. >> >> Thanks. >> >> On Thu, Mar 24, 2016 at 9:54 AM, Khushboo Vashi >> wrote: >> > Hi, >> > >> > Please find the attached updated patch for the Domain module. >> > >> > Thanks, >> > Khushboo >> > >> > On Wed, Mar 23, 2016 at 6:35 PM, Dave Page wrote: >> >> >> >> Hi >> >> >> >> Almost there :-s >> >> >> >> - The hint for default should be a placeholder in the textbox itself >> >> (like combos have "Select from the list" >> > >> > Done >> >> >> >> - I should be able to check the "Validate?" option on one or more >> >> constraints from within the Domain dialogue >> > >> > Done. >> > Constraint Name can also be changed through the Domain dialogue. >> >> >> >> - Please ensure the capitalisation of all property labels is >> >> consistent - it should be "Base type" not "Base Type", "System >> >> domain?" not "System Domain?" etc. >> > >> > Done >> >> >> >> - The check constraint reverse engineered SQL should include the path >> >> to the constraint, e.g. >> >> >> > Done >> >> >> >> -- CHECK: schema.domain.check_at >> >> >> >> Once that's done, it can be committed I think. >> >> >> >> Thanks. >> >> >> >> On Wed, Mar 23, 2016 at 7:27 AM, Khushboo Vashi >> >> wrote: >> >> > Updated one comment. >> >> > >> >> > On Wed, Mar 23, 2016 at 12:48 PM, Khushboo Vashi >> >> > wrote: >> >> >> >> >> >> Hi, >> >> >> >> >> >> Please find attached updated patch for the Domains module. >> >> >> >> >> >> On Wed, Mar 16, 2016 at 9:40 PM, Dave Page >> >> >> wrote: >> >> >>> >> >> >>> Hi >> >> >>> >> >> >>> On Wed, Mar 16, 2016 at 2:03 PM, Khushboo Vashi >> >> >>> wrote: >> >> >>> > Hi, >> >> >>> > >> >> >>> > Please find the updated Domain Module Patch. >> >> >>> > >> >> >>> > To test this patch, please apply Backgrid Textarea Cell Patch >> >> >>> > before >> >> >>> > this. >> >> >>> >> >> >>> Thanks. I believe with the following fixes, we'll be done :-) >> >> >>> >> >> >>> - Default values should be auto-quoted when necessary (ie. strings, >> >> >>> on >> >> >>> a text-based domain). >> >> >> >> >> >> As per our discussion, this should leave unquoted. >> >> > >> >> > And also added a hint to the field stated 'Enter an expression or a >> >> > value.' >> >> >> >> >> >> >> >> >>> - "System Domain?" should be in the General section, between owner >> >> >>> and >> >> >>> comment. >> >> >> >> >> >> Done >> >> >>> >> >> >>> - The switches should use the same colouring/styling as other >> >> >>> objects, >> >> >>> e.g. >> >> >>> >> >> >>> options: { >> >> >>> 'onText': 'Yes', 'offText': 'No', >> >> >>> 'onColor': 'success', 'offColor': 'primary', >> >> >>> 'size': 'small' >> >> >>> } >> >> >> >> >> >> Done >> >> >>> >> >> >>> - Please remove the Schema property from the main properties tab >> >> >>> (not >> >> >>> the properties dialogue). >> >> >> >> >> >> Done >> >> >>> >> >> >>> - No icon is show for Checks on the Dependents tab for a domain. >> >> >> >> >> >> Done >> >> >>> >> >> >>> - The add button on the Security Labels tab is spelt "Add". Why is >> >> >>> that? Other instances of this grid use "ADD" which is the default >> >> >>> in >> >> >>> backform.pgadmin.js. >> >> >> >> >> >> Done >> >> >>> >> >> >>> - Dependencies on domain check constraints are listed as being on a >> >> >>> "Type" not a "Domain". >> >> >> >> >> >> Done >> >> >>> >> >> >>> - If adding a domain constraint using the grid on the Domain >> >> >>> dialogue, >> >> >>> I cannot specify "NOT VALID". We need a checkbox for that in a >> >> >>> narrow >> >> >>> columns at the end. Unchecking it for an existing constraint should >> >> >>> be >> >> >>> the equivalent of doing "ALTER DOMAIN ... VALIDATE CONSTRAINT" >> >> >> >> >> >> Done >> >> >>> >> >> >>> - If I switch the "Don't Validate" switch on a constraint, there >> >> >>> are >> >> >>> leading blank lines in the generated SQL. The same occurs when >> >> >>> adding >> >> >>> a comment to a constraint. >> >> >> >> >> >> Done >> >> >>> >> >> >>> - I think we need to reverse the meaning of "Don't Validate" and >> >> >>> rename to match the "Valid?" field that's on the properties list. >> >> >>> Otherwise it's not clear they're the same thing. >> >> >> >> >> >> Done >> >> >>> >> >> >>> - s/Not Null/Not Null?/ >> >> >> >> >> >> Done >> >> >>> >> >> >>> >> >> >>> >> >> >>> -- >> >> >>> Dave Page >> >> >>> Blog: http://pgsnake.blogspot.com >> >> >>> Twitter: @pgsnake >> >> >>> >> >> >>> EnterpriseDB UK: http://www.enterprisedb.com >> >> >>> The Enterprise PostgreSQL Company >> >> >> >> >> >> >> >> > >> >> >> >> >> >> >> >> -- >> >> Dave Page >> >> Blog: http://pgsnake.blogspot.com >> >> Twitter: @pgsnake >> >> >> >> EnterpriseDB UK: http://www.enterprisedb.com >> >> The Enterprise PostgreSQL Company >> > >> > >> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers