Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1agCp0-0006On-5z for pgadmin-hackers@arkaria.postgresql.org; Wed, 16 Mar 2016 14:53:14 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1agCoz-0006og-OG for pgadmin-hackers@arkaria.postgresql.org; Wed, 16 Mar 2016 14:53:13 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1agCol-0006Gi-Fx for pgadmin-hackers@postgresql.org; Wed, 16 Mar 2016 14:52:59 +0000 Received: from mail-io0-x22f.google.com ([2607:f8b0:4001:c06::22f]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1agCoe-0005Ct-4R for pgadmin-hackers@postgresql.org; Wed, 16 Mar 2016 14:52:59 +0000 Received: by mail-io0-x22f.google.com with SMTP id g203so62077861iof.2 for ; Wed, 16 Mar 2016 07:52:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=LU7h948AOs2ygq5vmb9R16DWcgD+cLsUEM2vZYoHU58=; b=LUa4MVo5WSgxF1KViH5KFzWH/2U+3E6VYCouINu8XAcU5tvQBY/pfpINBWbtFj2I1h tdy9Bg3cvfTUd837YWl+tRZbHyuB+R1pe8NRWlM1ukX+EKaV5rXYEsmrX6F8hd8OuR58 f+yILGOVp36YHZUislH2fIlpfRLbwnm1sa/nhCakeZukpigC1rYHrkfDSdau/m+PoX2l 0az2kRjLJ/+uu9g57mJKU/JtyqiLKYauoN3DauR8ZzE4q/Y4LUnv59/2JMRTG/K4U3W+ 9AyFIqA3Jo1pCWBCfLGzUsQEgGkN1ZSB2aQU3YllWYbz9Bf1WJMGmS/pVH+MkBdmvLiG 6iqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=LU7h948AOs2ygq5vmb9R16DWcgD+cLsUEM2vZYoHU58=; b=GAasjj0e/KZth0P/YQ11IdnC8bFFCVr2gpeC7iq+qS8RzFinurpVsruuVid8xOeVp/ dvohcwJ7tiGl8ReCpRxOp2PDbW5WQq/z1DhBkPFWWGCAUOxHttKu4gJPDo9PBBSv94f4 A0UbbGRJcLs/9hbJcsS6zE2Ywfck7sBd7W7Edq1pcCdBgEKsUXkfA2RcEcl2n7ym/Lnm Nrfo9Ko4y8g/pDiBpRPF1A8e1VXnq0q8hBTbtTNEdo+HismcdwsWExAaYGH5Z31/VrMn K2olB4b6fTGMgpOBMHjRaHcPUHTMYs+Xb2DoN7ZGirx8aUL00VNy0rk8O56mzgCmcLw8 RvOQ== X-Gm-Message-State: AD7BkJJPrTzA42jXQ9X1S5vmGdRn9vtzdc/NSvC+yagNC6+l+RmBhkGibVjQEqQ7z+sPcCGuqlohHYHEUF4vQw== MIME-Version: 1.0 X-Received: by 10.107.43.2 with SMTP id r2mr4189729ior.156.1458139970285; Wed, 16 Mar 2016 07:52:50 -0700 (PDT) Received: by 10.64.213.73 with HTTP; Wed, 16 Mar 2016 07:52:50 -0700 (PDT) In-Reply-To: References: Date: Wed, 16 Mar 2016 14:52:50 +0000 Message-ID: Subject: Re: PATCH: Added Node Type & Catalog objects [pgAdmin4] From: Dave Page To: Ashesh Vashi Cc: Murtuza Zabuawala , pgadmin-hackers Content-Type: multipart/alternative; boundary=001a113a69e2f647ee052e2baad6 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a113a69e2f647ee052e2baad6 Content-Type: text/plain; charset=UTF-8 On Wed, Mar 16, 2016 at 1:18 PM, Ashesh Vashi wrote: > On Wed, Mar 16, 2016 at 6:32 PM, Dave Page wrote: > >> Hi >> >> On Mon, Mar 14, 2016 at 12:21 PM, Murtuza Zabuawala >> wrote: >> > Hi Dave, >> > >> > Thank you for reviewing my patch. >> > >> > I have made changes according to your feedback. >> > >> > Please review updated patch. >> >> OK, I think it's in pretty good shape now. Here's what I hope are the >> last of the review comments, mostly minor things :-) >> >> - I'm allowed to edit ENUM label names, but PostgreSQL doesn't support >> that. >> >> - Security label fields resize in Edit mode. See recent changes by >> Arun to fix that elsewhere. >> >> - When editing a type, I cannot select a Grantee on the Privileges tab. >> > Is the grantor same as the current user? > > If yes - then it is a bug, otherwise it is by design. > Because - you can not change privileges of a grantee, when it was given by > some other grantor. > This is when adding new privileges - which basically doesn't work as the form won't validate because there is no grantee selected. > > But - if you delete the privileges for its grantor, it will remove > privileges for the privileges given by it too. (which is though, we have > not yet take care, and we will do it in later.) > > -- > > Thanks & Regards, > > Ashesh Vashi > EnterpriseDB INDIA: Enterprise PostgreSQL Company > > > > *http://www.linkedin.com/in/asheshvashi* > > >> >> - When adding a composite type, I cannot type/select directly in the >> grid, I have to expand the row. >> >> - If I click ADD to add a new member to a composite type whilst the >> previous row is expanded, the new row is added, but the expanded panel >> remains linked to the first row. >> >> - If I then click on the Edit button on the new row, I see two >> expanded panels, neither of which is attached to their row (and >> they're in the wrong order). I would only expect to see one panel at a >> time. >> >> - When creating an External type, the Input, Output, Send, Receive and >> Analyze function lists are all blank. Is this expected? I would have >> thought there would be system functions listed as there are for Typmod >> in/out. >> >> - Labels for Yes/No fields should typically end in a '?', e.g. >> "Variable?", "Preferred?" >> >> - s/Prefered/Preferred >> >> - Why does "Range" type have a frame around it? >> >> - If a field is there to select/display a function, it should have >> "function" at the end of its label, e.g. "Canonical function" >> >> - As above, but with type. E.g. "Element type" >> >> - Some of the combo boxes have hint text of "Select from the list", >> whilst others don't. This should be consistent. >> >> - The colouring of "No" on the switches should be blue (see "System >> Schema?") >> >> - s/Subtype/Sub-type/ >> >> - s/SubType diff/Sub-type diff function/ >> >> - Please remove the pre-9.1 support. >> >> - In def create(self, gid, sid, did, scid), ensure error messages are >> properly pluralised, e.g. 'Composite types require at least two >> members' or 'External types require both Input & Output conversion >> functions.' >> >> - additional_features.sql is poorly formatted (lack of proper indentation) >> >> Thanks! >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> >> -- >> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >> To make changes to your subscription: >> http://www.postgresql.org/mailpref/pgadmin-hackers >> > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a113a69e2f647ee052e2baad6 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On Wed, Mar 16, 2016 at 1:18 PM, Ashesh Vashi <ashesh.vash= i@enterprisedb.com> wrote:
=
On Wed, Mar 16, 2016 at 6:32 PM, Dave Pag= e <dpage@pgadmin.org> wrote:
Hi

On Mon, Mar 14, 2016 at 12:21 PM, Murtuza Zabuawala
<murtuza.zabuawala@enterprisedb.com> wrote:
> Hi Dave,
>
> Thank you for reviewing my patch.
>
> I have made changes according to your feedback.
>
> Please review updated patch.

OK, I think it's in pretty good shape now. Here's what I hop= e are the
last of the review comments, mostly minor things :-)

- I'm allowed to edit ENUM label names, but PostgreSQL doesn't supp= ort that.

- Security label fields resize in Edit mode. See recent changes by
Arun to fix that elsewhere.

- When editing a type, I cannot select a Grantee on the Privileges tab.
=
Is the grantor same as the current user?

If yes - then it is a bug, otherwise it is by design.
=
Because - you can not change privileges of a grantee, when it was give= n by some other grantor.

This is when adding new privileges - which basically doesn't work= as the form won't validate because there is no grantee selected.
=
=C2=A0

But - if yo= u delete the privileges for its grantor, it will remove privileges for the = privileges given by it too. (which is though, we have not yet take care, an= d we will do it in later.)

--

Thanks & Regards,

Ashe= sh Vashi
EnterpriseDB INDIA:=C2=A0Enterprise PostgreSQL Company



- When adding a composite type, I cannot type/select directly in the
grid, I have to expand the row.

- If I click ADD to add a new member to a composite type whilst the
previous row is expanded, the new row is added, but the expanded panel
remains linked to the first row.

- If I then click on the Edit button on the new row, I see two
expanded panels, neither of which is attached to their row (and
they're in the wrong order). I would only expect to see one panel at a<= br> time.

- When creating an External type, the Input, Output, Send, Receive and
Analyze function lists are all blank. Is this expected? I would have
thought there would be system functions listed as there are for Typmod
in/out.

- Labels for Yes/No fields should typically end in a '?', e.g.
"Variable?", "Preferred?"

- s/Prefered/Preferred

- Why does "Range" type have a frame around it?

- If a field is there to select/display a function, it should have
"function" at the end of its label, e.g. "Canonical function= "

- As above, but with type. E.g. "Element type"

- Some of the combo boxes have hint text of "Select from the list"= ;,
whilst others don't. This should be consistent.

- The colouring of "No" on the switches should be blue (see "= ;System Schema?")

- s/Subtype/Sub-type/

- s/SubType diff/Sub-type diff function/

- Please remove the pre-9.1 support.

- In def create(self, gid, sid, did, scid), ensure error messages are
properly pluralised, e.g. 'Composite types require at least two
members' or 'External types require both Input & Output convers= ion
functions.'

- additional_features.sql is poorly formatted (lack of proper indentation)<= br>
Thanks!

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Sent via pgadmin-hackers mailing list (pgadmin-h= ackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers=




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake=

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Compan= y
--001a113a69e2f647ee052e2baad6--